From patchwork Thu Jan 30 14:56:49 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Qian Cai X-Patchwork-Id: 11358201 Return-Path: Received: from mail.kernel.org (pdx-korg-mail-1.web.codeaurora.org [172.30.200.123]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id 2A6B314E3 for ; Thu, 30 Jan 2020 14:57:08 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id DE83E20707 for ; Thu, 30 Jan 2020 14:57:07 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (2048-bit key) header.d=lca.pw header.i=@lca.pw header.b="gPH3wrPi" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org DE83E20707 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=lca.pw Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id 18D526B0360; Thu, 30 Jan 2020 09:57:07 -0500 (EST) Delivered-To: linux-mm-outgoing@kvack.org Received: by kanga.kvack.org (Postfix, from userid 40) id 13D866B0361; Thu, 30 Jan 2020 09:57:07 -0500 (EST) X-Original-To: int-list-linux-mm@kvack.org X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 055416B0362; Thu, 30 Jan 2020 09:57:07 -0500 (EST) X-Original-To: linux-mm@kvack.org X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0155.hostedemail.com [216.40.44.155]) by kanga.kvack.org (Postfix) with ESMTP id E66566B0360 for ; Thu, 30 Jan 2020 09:57:06 -0500 (EST) Received: from smtpin24.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay04.hostedemail.com (Postfix) with ESMTP id AB0C3281A for ; Thu, 30 Jan 2020 14:57:06 +0000 (UTC) X-FDA: 76434603252.24.wrist16_20ecd0e601447 X-Spam-Summary: 2,0,0,bc0865a76a80eacc,d41d8cd98f00b204,cai@lca.pw,:akpm@linux-foundation.org:dennis@kernel.org:tj@kernel.org:cl@linux.com:elver@google.com::linux-kernel@vger.kernel.org:cai@lca.pw,RULES_HIT:41:355:379:541:800:960:973:988:989:1260:1311:1314:1345:1437:1515:1534:1541:1711:1730:1747:1777:1792:2194:2199:2393:2559:2562:2918:3138:3139:3140:3141:3142:3352:3865:3866:3867:3870:3871:3872:4321:5007:6261:6653:7903:10004:11026:11232:11473:11658:11914:12043:12296:12297:12438:12517:12519:12555:12895:12986:13069:13149:13161:13229:13230:13311:13357:13894:14018:14096:14104:14181:14384:14394:14721:21080:21444:21627:30054:30065,0,RBL:209.85.160.193:@lca.pw:.lbl8.mailshell.net-62.2.0.100 66.100.201.201,CacheIP:none,Bayesian:0.5,0.5,0.5,Netcheck:none,DomainCache:0,MSF:not bulk,SPF:fp,MSBL:0,DNSBL:neutral,Custom_rules:0:0:0,LFtime:66,LUA_SUMMARY:none X-HE-Tag: wrist16_20ecd0e601447 X-Filterd-Recvd-Size: 4799 Received: from mail-qt1-f193.google.com (mail-qt1-f193.google.com [209.85.160.193]) by imf23.hostedemail.com (Postfix) with ESMTP for ; Thu, 30 Jan 2020 14:57:06 +0000 (UTC) Received: by mail-qt1-f193.google.com with SMTP id h12so2692797qtu.1 for ; Thu, 30 Jan 2020 06:57:06 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=lca.pw; s=google; h=from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=ZNin1fkHvBE9eW3g8NlOf6UaO9vwNWq4JoMAU8rk968=; b=gPH3wrPiBhJ1X1dzwiOUlqSDcnz9fUG8KhH5CL2Tov+tnlNFQiCFr0vsZvf4DrD4ql 5vMSK2C6bUevX0L/2uJd3Papwp/y4DNkymkscVJl+1U0dxB/2YsCgl5m9DdhYvTtPAFz LzAKkp0XTgLvew6SAzlQluIq6qj4PcN4wLMTKqArt7aZzH34dxWJ2Xta8ZD2eG32AMNM 9Spr3lPTnBQiwNMBFpAuCioOJBR6YcHPH9tcc1CFvtOpQelhp39EOH1xYelfF8aKhRa4 z80vCrL2qaqu2zfxF8o3EyPvBEbaxRihHPFlOfp/TwNcX8tKcxk+wuxNpdFCZOvq+6eg 137w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=ZNin1fkHvBE9eW3g8NlOf6UaO9vwNWq4JoMAU8rk968=; b=g4YrBu51NmXCAtiA4zs8gGFzQkTPOIAUnoqfu6u7nwB8n2xqu0oiC0ErBiW6siwR2+ tt/Yv8YK30YuheHu1EFm11CgBYp7BRTjo0JftOqgy9ADpWkinkJY2O5glhnxY+DFosEV ic/55y1XOVS+BU94gLoIpJX+4XF05ekQYfdb8Y+dcPQ72MjL6N6GPxFWobkLDwpsgVtg I16pSBKsipnnN7Z4e4pcdw850Jx0eDMjE2LN2pxzq5yo9LAbS90mSyV4I/eL0uRKxUjA FX1KtSIvX05JRvQ+YeXCPzqzxv2rI/oua8nyoNfHGes0Od+rHgV3qDSodpe/iej98/32 O+6Q== X-Gm-Message-State: APjAAAXkOl2PW2X1xw4yiVsg5FERHjx20JNm2SCfOu53gRbXpildD11o i2XkDjTJRler0x/RtBuWcgeoRA== X-Google-Smtp-Source: APXvYqx8U57433kel8PKdYA6yz39yF4h49woso5+R7mtiD7se9+X7qmo36Zm/yFzJAHbhcO2yc93/w== X-Received: by 2002:ac8:4419:: with SMTP id j25mr5229623qtn.378.1580396225480; Thu, 30 Jan 2020 06:57:05 -0800 (PST) Received: from ovpn-120-129.rdu2.redhat.com (pool-71-184-117-43.bstnma.fios.verizon.net. [71.184.117.43]) by smtp.gmail.com with ESMTPSA id y27sm3219559qta.50.2020.01.30.06.57.04 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Thu, 30 Jan 2020 06:57:04 -0800 (PST) From: Qian Cai To: akpm@linux-foundation.org Cc: dennis@kernel.org, tj@kernel.org, cl@linux.com, elver@google.com, linux-mm@kvack.org, linux-kernel@vger.kernel.org, Qian Cai Subject: [PATCH -next] mm/util: annotate an intentional data race Date: Thu, 30 Jan 2020 09:56:49 -0500 Message-Id: <20200130145649.1240-1-cai@lca.pw> X-Mailer: git-send-email 2.21.0 (Apple Git-122.2) MIME-Version: 1.0 X-Bogosity: Ham, tests=bogofilter, spamicity=0.011480, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: "vm_committed_as.count" could be accessed concurrently as reported by KCSAN, read to 0xffffffff923164f8 of 8 bytes by task 1268 on cpu 38: __vm_enough_memory+0x43/0x280 mm/util.c:801 mmap_region+0x1b2/0xb90 mm/mmap.c:1726 do_mmap+0x45c/0x700 vm_mmap_pgoff+0xc0/0x130 vm_mmap+0x71/0x90 elf_map+0xa1/0x1b0 load_elf_binary+0x9de/0x2180 search_binary_handler+0xd8/0x2b0 __do_execve_file+0xb61/0x1080 __x64_sys_execve+0x5f/0x70 do_syscall_64+0x91/0xb47 entry_SYSCALL_64_after_hwframe+0x49/0xbe write to 0xffffffff923164f8 of 8 bytes by task 1265 on cpu 41: percpu_counter_add_batch+0x83/0xd0 lib/percpu_counter.c:91 exit_mmap+0x178/0x220 include/linux/mman.h:68 mmput+0x10e/0x270 flush_old_exec+0x572/0xfe0 load_elf_binary+0x467/0x2180 search_binary_handler+0xd8/0x2b0 __do_execve_file+0xb61/0x1080 __x64_sys_execve+0x5f/0x70 do_syscall_64+0x91/0xb47 entry_SYSCALL_64_after_hwframe+0x49/0xbe The warning is almost impossible to trigger according to the commit 82f71ae4a2b8 ("mm: catch memory commitment underflow") but leave it for now to catch any possible unbalanced vm_unacct_memory() in the future. Since only the read is operating as lockless, mark it as an intentional data race using the data_race() macro. Signed-off-by: Qian Cai Acked-by: Christoph Lameter Acked-by: Dennis Zhou --- mm/util.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/mm/util.c b/mm/util.c index 988d11e6c17c..528d2c710771 100644 --- a/mm/util.c +++ b/mm/util.c @@ -798,8 +798,8 @@ int __vm_enough_memory(struct mm_struct *mm, long pages, int cap_sys_admin) { long allowed; - VM_WARN_ONCE(percpu_counter_read(&vm_committed_as) < - -(s64)vm_committed_as_batch * num_online_cpus(), + VM_WARN_ONCE(data_race(percpu_counter_read(&vm_committed_as) < + -(s64)vm_committed_as_batch * num_online_cpus()), "memory commitment underflow"); vm_acct_memory(pages);