From patchwork Fri Jan 31 06:17:26 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Andrew Morton X-Patchwork-Id: 11359361 Return-Path: Received: from mail.kernel.org (pdx-korg-mail-1.web.codeaurora.org [172.30.200.123]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id 0CF3B92A for ; Fri, 31 Jan 2020 06:17:30 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id CD39524685 for ; Fri, 31 Jan 2020 06:17:29 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=kernel.org header.i=@kernel.org header.b="e4hzhuSJ" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org CD39524685 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=linux-foundation.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id 609AE6B05A1; Fri, 31 Jan 2020 01:17:28 -0500 (EST) Delivered-To: linux-mm-outgoing@kvack.org Received: by kanga.kvack.org (Postfix, from userid 40) id 596456B05A3; Fri, 31 Jan 2020 01:17:28 -0500 (EST) X-Original-To: int-list-linux-mm@kvack.org X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 483416B05A4; Fri, 31 Jan 2020 01:17:28 -0500 (EST) X-Original-To: linux-mm@kvack.org X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0043.hostedemail.com [216.40.44.43]) by kanga.kvack.org (Postfix) with ESMTP id 2DF516B05A1 for ; Fri, 31 Jan 2020 01:17:28 -0500 (EST) Received: from smtpin02.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay04.hostedemail.com (Postfix) with ESMTP id DB19D4DA2 for ; Fri, 31 Jan 2020 06:17:27 +0000 (UTC) X-FDA: 76436922534.02.crime28_41205314adc35 X-Spam-Summary: 2,0,0,9b9fa886e12f2972,d41d8cd98f00b204,akpm@linux-foundation.org,:akpm@linux-foundation.org:hushiyuan@huawei.com:jack@suse.cz:linfeilong@huawei.com::mm-commits@vger.kernel.org:torvalds@linux-foundation.org:yeyunfeng@huawei.com:zhengbin13@huawei.com,RULES_HIT:41:355:379:560:800:960:966:967:973:988:989:1260:1263:1345:1359:1381:1431:1437:1534:1541:1711:1730:1747:1777:1792:2196:2198:2199:2200:2393:2525:2553:2559:2563:2682:2685:2859:2902:2933:2937:2939:2942:2945:2947:2951:2954:3022:3138:3139:3140:3141:3142:3352:3865:3866:3870:3871:3934:3936:3938:3941:3944:3947:3950:3953:3956:3959:4250:4385:4605:5007:6261:6653:7576:7903:9025:9545:10004:11026:11257:11473:11658:11914:12043:12048:12114:12296:12297:12438:12517:12519:12679:12783:13069:13161:13229:13255:13311:13357:13846:14181:14384:14721:14849:21080:21220:21451:21627:21939:21972:21987:30054:30056:30070:30080:30090,0,RBL:error,CacheIP:none,Bayesian:0.5,0.5,0.5,Netcheck:none,DomainCache:0,MSF:not bulk,SPF:fp,MSBL:0,DNSBL: neutral, X-HE-Tag: crime28_41205314adc35 X-Filterd-Recvd-Size: 2674 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by imf46.hostedemail.com (Postfix) with ESMTP for ; Fri, 31 Jan 2020 06:17:27 +0000 (UTC) Received: from localhost.localdomain (c-73-231-172-41.hsd1.ca.comcast.net [73.231.172.41]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 84C1B2173E; Fri, 31 Jan 2020 06:17:26 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1580451446; bh=2olV08JFAEygyhE64KLJ/xKcryP35AMabelEAURKdnw=; h=Date:From:To:Subject:In-Reply-To:From; b=e4hzhuSJkNqTESFgJoIHvsDU5j1rxBQqqhwBP97ba025iNB0UW5pEo0EUhcwzyeAT IF8ccDElbeM3BV0OXfR03XOqCuwalWa5u2k22kBi/BAZ/uI3kBXHBAtbgWs6bar05D hsl3FqTQoThjE9qLpcOnVJHSM3PWHGdrjETvRVYY= Date: Thu, 30 Jan 2020 22:17:26 -0800 From: Andrew Morton To: akpm@linux-foundation.org, hushiyuan@huawei.com, jack@suse.cz, linfeilong@huawei.com, linux-mm@kvack.org, mm-commits@vger.kernel.org, torvalds@linux-foundation.org, yeyunfeng@huawei.com, zhengbin13@huawei.com Subject: [patch 115/118] reiserfs: prevent NULL pointer dereference in reiserfs_insert_item() Message-ID: <20200131061726.T8srbyKpw%akpm@linux-foundation.org> In-Reply-To: <20200130221021.5f0211c56346d5485af07923@linux-foundation.org> User-Agent: s-nail v14.8.16 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: From: Yunfeng Ye Subject: reiserfs: prevent NULL pointer dereference in reiserfs_insert_item() The variable inode may be NULL in reiserfs_insert_item(), but there is no check before accessing the member of inode. Fix this by adding NULL pointer check before calling reiserfs_debug(). Link: http://lkml.kernel.org/r/79c5135d-ff25-1cc9-4e99-9f572b88cc00@huawei.com Signed-off-by: Yunfeng Ye Cc: zhengbin Cc: Hu Shiyuan Cc: Feilong Lin Cc: Jan Kara Signed-off-by: Andrew Morton --- fs/reiserfs/stree.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) --- a/fs/reiserfs/stree.c~reiserfs-prevent-null-pointer-dereference-in-reiserfs_insert_item +++ a/fs/reiserfs/stree.c @@ -2246,7 +2246,8 @@ error_out: /* also releases the path */ unfix_nodes(&s_ins_balance); #ifdef REISERQUOTA_DEBUG - reiserfs_debug(th->t_super, REISERFS_DEBUG_CODE, + if (inode) + reiserfs_debug(th->t_super, REISERFS_DEBUG_CODE, "reiserquota insert_item(): freeing %u id=%u type=%c", quota_bytes, inode->i_uid, head2type(ih)); #endif