From patchwork Thu Feb 6 03:52:35 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Qian Cai X-Patchwork-Id: 11367633 Return-Path: Received: from mail.kernel.org (pdx-korg-mail-1.web.codeaurora.org [172.30.200.123]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id DA688109A for ; Thu, 6 Feb 2020 03:52:44 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id A6DE7217F4 for ; Thu, 6 Feb 2020 03:52:44 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (2048-bit key) header.d=lca.pw header.i=@lca.pw header.b="bAGKJFAO" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org A6DE7217F4 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=lca.pw Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id EB5E46B0006; Wed, 5 Feb 2020 22:52:43 -0500 (EST) Delivered-To: linux-mm-outgoing@kvack.org Received: by kanga.kvack.org (Postfix, from userid 40) id E66E26B0007; Wed, 5 Feb 2020 22:52:43 -0500 (EST) X-Original-To: int-list-linux-mm@kvack.org X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id DA40C6B0008; Wed, 5 Feb 2020 22:52:43 -0500 (EST) X-Original-To: linux-mm@kvack.org X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0195.hostedemail.com [216.40.44.195]) by kanga.kvack.org (Postfix) with ESMTP id C2B526B0006 for ; Wed, 5 Feb 2020 22:52:43 -0500 (EST) Received: from smtpin05.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay01.hostedemail.com (Postfix) with ESMTP id 6A7CF180AD802 for ; Thu, 6 Feb 2020 03:52:43 +0000 (UTC) X-FDA: 76458330606.05.cow17_17be71f8f3947 X-Spam-Summary: 2,0,0,d29a3660ecf35985,d41d8cd98f00b204,cai@lca.pw,:akpm@linux-foundation.org:jhubbard@nvidia.com:ira.weiny@intel.com:dan.j.williams@intel.com:jack@suse.cz::linux-kernel@vger.kernel.org:cai@lca.pw,RULES_HIT:41:355:379:541:800:960:973:988:989:1260:1311:1314:1345:1437:1515:1535:1542:1711:1730:1747:1777:1792:2198:2199:2393:2559:2562:2693:2918:3138:3139:3140:3141:3142:3353:3865:3866:3867:3868:3870:3872:4321:4605:5007:6238:6261:6653:7903:7904:8784:8957:9036:9163:10004:11026:11473:11658:11914:12043:12296:12297:12438:12517:12519:12555:12679:12740:12895:12986:13161:13229:13870:13894:14018:14096:14181:14394:14721:21080:21444:21451:21627:21990:30029:30054:30056:30065:30070,0,RBL:209.85.222.195:@lca.pw:.lbl8.mailshell.net-62.2.0.100 66.100.201.201,CacheIP:none,Bayesian:0.5,0.5,0.5,Netcheck:none,DomainCache:0,MSF:not bulk,SPF:fp,MSBL:0,DNSBL:neutral,Custom_rules:0:0:0,LFtime:23,LUA_SUMMARY:none X-HE-Tag: cow17_17be71f8f3947 X-Filterd-Recvd-Size: 5368 Received: from mail-qk1-f195.google.com (mail-qk1-f195.google.com [209.85.222.195]) by imf37.hostedemail.com (Postfix) with ESMTP for ; Thu, 6 Feb 2020 03:52:43 +0000 (UTC) Received: by mail-qk1-f195.google.com with SMTP id x1so4201155qkl.12 for ; Wed, 05 Feb 2020 19:52:43 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=lca.pw; s=google; h=from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=2Htl2QyOrnt7Rw22eVBkqGfdWYswdzSpMTMzVm1sOS8=; b=bAGKJFAOQVqic3EBF5r+8D09nAddX4/Tz+XBzSjQ8ykw/JH4+zly5hm9xkrAZAfZ87 Ecrwt8irdqym4sp9pb3iYx7+c86/FbvmREtTJeuSbH6P+PK4kDrG5aXe1Eixenq6p/oD g8mzhdHbcW/rcERdIzSTOlklowx15/J3l6sK5EE0xRQ8m/ZuP3BRUUVXUYI4rMnU7J4Z 6oq3PI8+O4VNhWEpDjdftK5TXhimkFytJy8j6jpGnMwWl5SnRYpGD1AlDaPKPz/r7vwL eXXUwaeLWussQ+Ahz9iSKn9cCpy+2OsjC2B0vvMqQ3DzcZD6BwewjH+KAfflNbLYRBNz DPMw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=2Htl2QyOrnt7Rw22eVBkqGfdWYswdzSpMTMzVm1sOS8=; b=uYXt5c1ecdFMGQiO3+84yeP4mApBpFd0kReNHpq3Gkhj4vzIwnVDxP7kHg4Goplcds +LgPpZ6RPlMmLlTWXK63CqRDi9YWskLVtLNPR7Dhuh5aikIjGAJEciCU9YFgsRieXQ/L xpRKA8MMF1QK79Q2R9LOz416eFLdvChMQUzqDBxeR3eWzP++QXfepGfdIGH5Zjjry4TL lgYncDed9O8p/BiD566wmPJ6iPA8i8OwgCzN8zpJesmYyxyfv5lPbIKhHvT98ga/1Y5B f6CA7i2tzHfJCgPMLuBATbevDdwN4cB9zdclPxkfjFrKUCUVQHt56SZPxHpIfRImpfPX 2/Jw== X-Gm-Message-State: APjAAAXXKZ/mSgXlbITeD+3jqvLlFiZBwkpXP7wU2/1DDedLWXEZHUtc D9qLUNHyBLAYJj7buOS+RsZasA== X-Google-Smtp-Source: APXvYqxZwwYqasmvJVARgELybgCbDWHzkLevPTLgtGpbOqLsvmH6u0Ei+qu4Ccd0ewfHkuPivTPgUw== X-Received: by 2002:ae9:e306:: with SMTP id v6mr828941qkf.162.1580961162500; Wed, 05 Feb 2020 19:52:42 -0800 (PST) Received: from ovpn-120-236.rdu2.redhat.com (pool-71-184-117-43.bstnma.fios.verizon.net. [71.184.117.43]) by smtp.gmail.com with ESMTPSA id k50sm1015337qtc.90.2020.02.05.19.52.41 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Wed, 05 Feb 2020 19:52:42 -0800 (PST) From: Qian Cai To: akpm@linux-foundation.org Cc: jhubbard@nvidia.com, ira.weiny@intel.com, dan.j.williams@intel.com, jack@suse.cz, linux-mm@kvack.org, linux-kernel@vger.kernel.org, Qian Cai Subject: [PATCH -next] mm: mark a intentional data race in page_zonenum() Date: Wed, 5 Feb 2020 22:52:35 -0500 Message-Id: <20200206035235.2537-1-cai@lca.pw> X-Mailer: git-send-email 2.21.0 (Apple Git-122.2) MIME-Version: 1.0 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000037, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: The commit 07d802699528 ("mm: devmap: refactor 1-based refcounting for ZONE_DEVICE pages") introduced a data race as page->flags could be accessed concurrently as noticied by KCSAN, BUG: KCSAN: data-race in page_cpupid_xchg_last / put_page write (marked) to 0xfffffc0d48ec1a00 of 8 bytes by task 91442 on cpu 3: page_cpupid_xchg_last+0x51/0x80 page_cpupid_xchg_last at mm/mmzone.c:109 (discriminator 11) wp_page_reuse+0x3e/0xc0 wp_page_reuse at mm/memory.c:2453 do_wp_page+0x472/0x7b0 do_wp_page at mm/memory.c:2798 __handle_mm_fault+0xcb0/0xd00 handle_pte_fault at mm/memory.c:4049 (inlined by) __handle_mm_fault at mm/memory.c:4163 handle_mm_fault+0xfc/0x2f0 handle_mm_fault at mm/memory.c:4200 do_page_fault+0x263/0x6f9 do_user_addr_fault at arch/x86/mm/fault.c:1465 (inlined by) do_page_fault at arch/x86/mm/fault.c:1539 page_fault+0x34/0x40 read to 0xfffffc0d48ec1a00 of 8 bytes by task 94817 on cpu 69: put_page+0x15a/0x1f0 page_zonenum at include/linux/mm.h:923 (inlined by) is_zone_device_page at include/linux/mm.h:929 (inlined by) page_is_devmap_managed at include/linux/mm.h:948 (inlined by) put_page at include/linux/mm.h:1023 wp_page_copy+0x571/0x930 wp_page_copy at mm/memory.c:2615 do_wp_page+0x107/0x7b0 __handle_mm_fault+0xcb0/0xd00 handle_mm_fault+0xfc/0x2f0 do_page_fault+0x263/0x6f9 page_fault+0x34/0x40 Reported by Kernel Concurrency Sanitizer on: CPU: 69 PID: 94817 Comm: systemd-udevd Tainted: G W O L 5.5.0-next-20200204+ #6 Hardware name: HPE ProLiant DL385 Gen10/ProLiant DL385 Gen10, BIOS A40 07/10/2019 Both the read and write are done only with the non-exclusive mmap_sem held. Since the read only check for a specific bit in the flag, even if load tearing happens, it will be harmless, so just mark it as an intentional data races using the data_race() macro. Signed-off-by: Qian Cai --- include/linux/mm.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/include/linux/mm.h b/include/linux/mm.h index 52269e56c514..cafccad584c2 100644 --- a/include/linux/mm.h +++ b/include/linux/mm.h @@ -920,7 +920,7 @@ vm_fault_t finish_mkwrite_fault(struct vm_fault *vmf); static inline enum zone_type page_zonenum(const struct page *page) { - return (page->flags >> ZONES_PGSHIFT) & ZONES_MASK; + return data_race((page->flags >> ZONES_PGSHIFT) & ZONES_MASK); } #ifdef CONFIG_ZONE_DEVICE