From patchwork Fri Feb 28 03:03:48 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Arjun Roy X-Patchwork-Id: 11411449 Return-Path: Received: from mail.kernel.org (pdx-korg-mail-1.web.codeaurora.org [172.30.200.123]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id 99C2514E3 for ; Fri, 28 Feb 2020 03:04:02 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 6598920658 for ; Fri, 28 Feb 2020 03:04:02 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="c8/CA0jI" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 6598920658 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=gmail.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id 8DDC06B0006; Thu, 27 Feb 2020 22:04:01 -0500 (EST) Delivered-To: linux-mm-outgoing@kvack.org Received: by kanga.kvack.org (Postfix, from userid 40) id 8663C6B0007; Thu, 27 Feb 2020 22:04:01 -0500 (EST) X-Original-To: int-list-linux-mm@kvack.org X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 77B3C6B0008; Thu, 27 Feb 2020 22:04:01 -0500 (EST) X-Original-To: linux-mm@kvack.org X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0181.hostedemail.com [216.40.44.181]) by kanga.kvack.org (Postfix) with ESMTP id 605EC6B0006 for ; Thu, 27 Feb 2020 22:04:01 -0500 (EST) Received: from smtpin20.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay03.hostedemail.com (Postfix) with ESMTP id EFF508248D51 for ; Fri, 28 Feb 2020 03:04:00 +0000 (UTC) X-FDA: 76538041482.20.fold55_5e9961cc0b02 X-Spam-Summary: 2,0,0,d0212e9570ca178e,d41d8cd98f00b204,arjunroy.kdev@gmail.com,,RULES_HIT:41:355:379:541:800:960:973:988:989:1260:1311:1314:1345:1359:1431:1437:1515:1535:1542:1711:1730:1747:1777:1792:2393:2559:2562:2740:3138:3139:3140:3141:3142:3354:3865:3866:3867:3868:3870:3871:3872:3874:5007:6119:6261:6653:7576:7875:7901:7903:9413:10004:11026:11658:11914:12043:12296:12297:12438:12517:12519:12555:12679:12895:12986:13053:13894:14181:14394:14687:14721:21080:21444:21451:21627:21666:21795:21990:30051:30054:30070,0,RBL:209.85.214.195:@gmail.com:.lbl8.mailshell.net-66.100.201.100 62.50.0.100,CacheIP:none,Bayesian:0.5,0.5,0.5,Netcheck:none,DomainCache:0,MSF:not bulk,SPF:fp,MSBL:0,DNSBL:neutral,Custom_rules:0:0:0,LFtime:23,LUA_SUMMARY:none X-HE-Tag: fold55_5e9961cc0b02 X-Filterd-Recvd-Size: 5838 Received: from mail-pl1-f195.google.com (mail-pl1-f195.google.com [209.85.214.195]) by imf35.hostedemail.com (Postfix) with ESMTP for ; Fri, 28 Feb 2020 03:04:00 +0000 (UTC) Received: by mail-pl1-f195.google.com with SMTP id y8so627319pll.13 for ; Thu, 27 Feb 2020 19:04:00 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=bTKV2gYw9SQ0hjOGIUuvXP/ZjKVlC3Sz++lbgl4oYsg=; b=c8/CA0jI/qMWjXoQQAQjI1ArNNmZqR5XsqjOfOVvjOMbYHWBy4fZM+PcLB0geqiwZc 7YG+cAf4EkeeIAMeJdmRONOy0KzQusGdGn0YB067wgzWG6wrnLFAd3+W5IU5OciMY4KN /rGaGs1+MBllfdX9WR+FlqVQKZKuSvWcBI0ZGVH5U3Filx1lmGxjtQNkVRHzPcLFbye0 wg9mQVQkvw44f8zxroqC6Pow8jekTuQOLgiLRVSbvdApxUpxCyeAyVtpny4zIBNmtHBn BzuHnc3GsPjkHImmPHk3tV/zx93OF3ESPgwKjvB/V84dh8U8bESx+GblQ9hHT/EqyUL7 K1XA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=bTKV2gYw9SQ0hjOGIUuvXP/ZjKVlC3Sz++lbgl4oYsg=; b=diu+CaAxmAhPc0T+bgQWmjAYm3xYDDRbs7kUatywcJTASsOyAsEJa0pSMV2JRkuF2I GrBNi2sqVljN4qITnakMDq9mCcWspK0JKgKUf+fMo1Zkn3mIboEcsQt08JvlOychuRMY A+6MI8ea/omUjzLIhX27KAORfmHEUBoX8gKOijlAja/dwvrHcSlSOOK5S+ZvthjD5973 B4vcrAUGC+myEl6sutV0esJXvu09p7PVqvyrIf40SUNDtHMtmhNxe6ZcWgmlcNNeOKmu ToNFnw62WpB6+rQZe8yz5m6dAJWmzlrdOdDeDo2xWjACp3z4pZT311MTL+llwTImPqAP VHzw== X-Gm-Message-State: APjAAAUueJhEiULoP8bCoNWvP4cSfpnYuaCwvauL11I6qhehiCWalfC7 ZV5xd2P/TFnhYJu9J1wxed4= X-Google-Smtp-Source: APXvYqxUpHxdGF0x6+EvAS5el6D7l/RrBqzft6fUQkf/ZNK4pkR3IGiZIXkNt2eKhBlUlSHSstXf7w== X-Received: by 2002:a17:902:8f91:: with SMTP id z17mr1946539plo.234.1582859039430; Thu, 27 Feb 2020 19:03:59 -0800 (PST) Received: from phantasmagoria.svl.corp.google.com ([2620:15c:2c4:201:2b0a:8c1:6a84:1aa0]) by smtp.gmail.com with ESMTPSA id d22sm8342821pfo.187.2020.02.27.19.03.58 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 27 Feb 2020 19:03:59 -0800 (PST) From: Arjun Roy To: davem@davemloft.net, akpm@linux-foundation.org, linux-mm@kvack.org Cc: arjunroy@google.com, soheil@google.com, edumazet@google.com, sfr@canb.auug.org.au, geert@linux-m68k.org Subject: [PATCH v2 mm 2/2] mm: vm_insert_pages() checks if pte_index defined. Date: Thu, 27 Feb 2020 19:03:48 -0800 Message-Id: <20200228030348.101745-2-arjunroy.kdev@gmail.com> X-Mailer: git-send-email 2.25.1.481.gfbce0eb801-goog In-Reply-To: <20200228030348.101745-1-arjunroy.kdev@gmail.com> References: <20200228030348.101745-1-arjunroy.kdev@gmail.com> MIME-Version: 1.0 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: From: Arjun Roy pte_index() is either defined as a macro (e.g. sparc64) or as an inlined function (e.g. x86). vm_insert_pages() depends on pte_index but it is not defined on all platforms (e.g. m68k). To fix compilation of vm_insert_pages() on architectures not providing pte_index(), we perform the following fix: 0. For platforms where it is meaningful, and defined as a macro, no change is needed. 1. For platforms where it is meaningful and defined as an inlined function, and we want to use it with vm_insert_pages(), we define a degenerate macro of the form: #define pte_index pte_index 2. vm_insert_pages() checks for the existence of a pte_index macro definition. If found, it implements a batched insert. If not found, it devolves to calling vm_insert_page() in a loop. This patch implements step 2. Signed-off-by: Arjun Roy --- mm/memory.c | 17 ++++++++++++++++- 1 file changed, 16 insertions(+), 1 deletion(-) diff --git a/mm/memory.c b/mm/memory.c index d6f834f7d145..33631a5b5c3f 100644 --- a/mm/memory.c +++ b/mm/memory.c @@ -1500,8 +1500,9 @@ static int insert_page(struct vm_area_struct *vma, unsigned long addr, return retval; } +#ifdef pte_index /* insert_pages() amortizes the cost of spinlock operations - * when inserting pages in a loop. + * when inserting pages in a loop. Arch *must* define pte_index. */ static int insert_pages(struct vm_area_struct *vma, unsigned long addr, struct page **pages, unsigned long *num, pgprot_t prot) @@ -1556,6 +1557,7 @@ static int insert_pages(struct vm_area_struct *vma, unsigned long addr, *num = remaining_pages_total; return ret; } +#endif /* ifdef pte_index */ /** * vm_insert_pages - insert multiple pages into user vma, batching the pmd lock. @@ -1575,6 +1577,7 @@ static int insert_pages(struct vm_area_struct *vma, unsigned long addr, int vm_insert_pages(struct vm_area_struct *vma, unsigned long addr, struct page **pages, unsigned long *num) { +#ifdef pte_index const unsigned long end_addr = addr + (*num * PAGE_SIZE) - 1; if (addr < vma->vm_start || end_addr >= vma->vm_end) @@ -1586,6 +1589,18 @@ int vm_insert_pages(struct vm_area_struct *vma, unsigned long addr, } /* Defer page refcount checking till we're about to map that page. */ return insert_pages(vma, addr, pages, num, vma->vm_page_prot); +#else + unsigned long idx = 0, pgcount = *num; + int err; + + for (; idx < pgcount; ++idx) { + err = vm_insert_page(vma, addr + (PAGE_SIZE * idx), pages[idx]); + if (err) + break; + } + *num = pgcount - idx; + return err; +#endif /* ifdef pte_index */ } EXPORT_SYMBOL(vm_insert_pages);