From patchwork Sun Mar 1 15:28:32 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Mateusz Nosek X-Patchwork-Id: 11414307 Return-Path: Received: from mail.kernel.org (pdx-korg-mail-1.web.codeaurora.org [172.30.200.123]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id C1D9B92A for ; Sun, 1 Mar 2020 15:30:36 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 7E30B2468A for ; Sun, 1 Mar 2020 15:30:36 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="R4niIOWr" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 7E30B2468A Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=gmail.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id B81AD6B0003; Sun, 1 Mar 2020 10:30:35 -0500 (EST) Delivered-To: linux-mm-outgoing@kvack.org Received: by kanga.kvack.org (Postfix, from userid 40) id B32986B0006; Sun, 1 Mar 2020 10:30:35 -0500 (EST) X-Original-To: int-list-linux-mm@kvack.org X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id A21706B0007; Sun, 1 Mar 2020 10:30:35 -0500 (EST) X-Original-To: linux-mm@kvack.org X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0088.hostedemail.com [216.40.44.88]) by kanga.kvack.org (Postfix) with ESMTP id 8852A6B0003 for ; Sun, 1 Mar 2020 10:30:35 -0500 (EST) Received: from smtpin13.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay04.hostedemail.com (Postfix) with ESMTP id 52EBB284BE for ; Sun, 1 Mar 2020 15:30:35 +0000 (UTC) X-FDA: 76547180430.13.ray08_5c6c399a91529 X-Spam-Summary: 2,0,0,2786a9c98ab00643,d41d8cd98f00b204,mateusznosek0@gmail.com,,RULES_HIT:41:355:379:541:800:960:968:973:988:989:1260:1345:1437:1534:1540:1711:1730:1747:1777:1792:2393:2559:2562:3138:3139:3140:3141:3142:3352:3865:3867:5007:6261:6653:7514:7576:7901:9413:10004:11026:11658:11914:12043:12297:12438:12517:12519:12555:12679:12895:13069:13311:13357:14096:14181:14384:14394:14721:21080:21444:21451:21627:21666:21990:30012:30054,0,RBL:209.85.208.195:@gmail.com:.lbl8.mailshell.net-62.18.0.100 66.100.201.100,CacheIP:none,Bayesian:0.5,0.5,0.5,Netcheck:none,DomainCache:0,MSF:not bulk,SPF:fp,MSBL:0,DNSBL:neutral,Custom_rules:0:0:0,LFtime:24,LUA_SUMMARY:none X-HE-Tag: ray08_5c6c399a91529 X-Filterd-Recvd-Size: 3549 Received: from mail-lj1-f195.google.com (mail-lj1-f195.google.com [209.85.208.195]) by imf30.hostedemail.com (Postfix) with ESMTP for ; Sun, 1 Mar 2020 15:30:35 +0000 (UTC) Received: by mail-lj1-f195.google.com with SMTP id q23so8954778ljm.4 for ; Sun, 01 Mar 2020 07:30:34 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id; bh=ubSe/iv847hRz3go2vcVkh5paHl2lJ7NU6C3tPrE1OQ=; b=R4niIOWre5oK0ZblTbLQzhTKf17NjJYu1fAvKbO8W+aBE05PXMYfrEKaT0rSMHY7mP A8Z1vGVG4MLqLJ+GohxngccxJQLR+wwr22XkTZJrQUEDLenEivFQFgcv7rNnkHLwchr5 AtX/ZC+8Bm1QhBzIK+3aUg/4R/HweizU3kms3QlY1/W2tpWdyenNe+2gS7R+1OelNGKV X7g0gS3F9a8J775AiIRhDpBbPyoLHtlY9tC+a7xRAmHuhnTnSfp6N8elggF0mDL7kv5n kBWj0cvjyRFtl4Bi5jfIhzwiBQgtlPumWEpdUNJQQEzgLbJnMZ+OnffdGrbObGQSJ66l V5gg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id; bh=ubSe/iv847hRz3go2vcVkh5paHl2lJ7NU6C3tPrE1OQ=; b=qVh94AcSPcrI9bjYW2pYbPnI9VE3dMCjVrKYu+fB8GuXBy7D7USQ5cwSpXlCBQKnJI SzM6HjmRYmeeoSiEvFzZRXK7wd0fEJsniWeQGwBcVuchZU2mKU627H0sR3ftyjiL0wcu Q04TXMNfM+QIBzao0MlKcCENfmZRrpcRB7jIx3Qtn3opvP3RQBxh9CGRRl5ExkDkbOj7 XeMVLfTqs129h7ZOguK46VX7yGlKi72QUnsuEIrUArqQcQ5jLJRxRhKjkRq0AxCZ7K0a XMMTe2FXBF2VAysvwH9vsZfi9I7y2+phdJo39MT/UfeYb/tnHDgb06baqowhO+dZXX9Q Q8dA== X-Gm-Message-State: ANhLgQ2Kg+vRmrXmDxxjvkIEvlzsz2w2sSVdprHedkh+sB1q6sDg43pK 3j8aAEqGL4IOO4BzS9sUVZzi2Kheb58= X-Google-Smtp-Source: ADFU+vvxXRdE5Fwx+uniobYvAmhUEaO8QHObek2+depma7eZfhEd9ma0PDMBas/14gjCNSwz+8iJ8w== X-Received: by 2002:a2e:3214:: with SMTP id y20mr8735810ljy.69.1583076633263; Sun, 01 Mar 2020 07:30:33 -0800 (PST) Received: from localhost.localdomain (188.146.100.83.nat.umts.dynamic.t-mobile.pl. [188.146.100.83]) by smtp.gmail.com with ESMTPSA id g21sm9876384ljj.53.2020.03.01.07.30.32 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 01 Mar 2020 07:30:32 -0800 (PST) From: mateusznosek0@gmail.com To: linux-mm@kvack.org, linux-kernel@vger.kernel.org Cc: Mateusz Nosek , hughd@google.com, akpm@linux-foundation.org Subject: [PATCH] mm/shmem.c: Clean code by removing unnecessary assignment Date: Sun, 1 Mar 2020 16:28:32 +0100 Message-Id: <20200301152832.24595-1-mateusznosek0@gmail.com> X-Mailer: git-send-email 2.17.1 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000376, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: From: Mateusz Nosek Previously 0 was assigned to variable 'error' but the variable was never read before reassignemnt later. So the assignment can be removed. Signed-off-by: Mateusz Nosek Reviewed-by: Matthew Wilcox (Oracle) --- mm/shmem.c | 9 +++------ 1 file changed, 3 insertions(+), 6 deletions(-) diff --git a/mm/shmem.c b/mm/shmem.c index 31b4bcc95f17..84eb14f5509c 100644 --- a/mm/shmem.c +++ b/mm/shmem.c @@ -3116,12 +3116,9 @@ static int shmem_symlink(struct inode *dir, struct dentry *dentry, const char *s error = security_inode_init_security(inode, dir, &dentry->d_name, shmem_initxattrs, NULL); - if (error) { - if (error != -EOPNOTSUPP) { - iput(inode); - return error; - } - error = 0; + if (error && error != -EOPNOTSUPP) { + iput(inode); + return error; } inode->i_size = len-1;