From patchwork Tue Mar 17 13:21:57 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Qian Cai X-Patchwork-Id: 11442917 Return-Path: Received: from mail.kernel.org (pdx-korg-mail-1.web.codeaurora.org [172.30.200.123]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id 4268A1667 for ; Tue, 17 Mar 2020 13:22:07 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 0E94320767 for ; Tue, 17 Mar 2020 13:22:07 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (2048-bit key) header.d=lca.pw header.i=@lca.pw header.b="X7ZelAWQ" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 0E94320767 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=lca.pw Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id 482FF6B0005; Tue, 17 Mar 2020 09:22:06 -0400 (EDT) Delivered-To: linux-mm-outgoing@kvack.org Received: by kanga.kvack.org (Postfix, from userid 40) id 432AC6B0006; Tue, 17 Mar 2020 09:22:06 -0400 (EDT) X-Original-To: int-list-linux-mm@kvack.org X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 2D3536B0007; Tue, 17 Mar 2020 09:22:06 -0400 (EDT) X-Original-To: linux-mm@kvack.org X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0038.hostedemail.com [216.40.44.38]) by kanga.kvack.org (Postfix) with ESMTP id 12A7B6B0005 for ; Tue, 17 Mar 2020 09:22:06 -0400 (EDT) Received: from smtpin22.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay01.hostedemail.com (Postfix) with ESMTP id D0F98180AD815 for ; Tue, 17 Mar 2020 13:22:05 +0000 (UTC) X-FDA: 76604917410.22.men75_2f55aa7f86a14 X-Spam-Summary: 2,0,0,ada6394889c3c9db,d41d8cd98f00b204,cai@lca.pw,,RULES_HIT:41:355:379:541:800:960:988:989:1260:1311:1314:1345:1437:1515:1534:1542:1711:1730:1747:1777:1792:1981:2194:2199:2393:2559:2562:2693:2918:3138:3139:3140:3141:3142:3353:3865:3866:3867:3870:3871:3872:4250:4321:5007:6261:6653:7903:8603:8660:10004:11026:11658:11914:12043:12296:12297:12438:12517:12519:12555:12679:12895:13148:13230:13894:14018:14096:14104:14181:14394:14721:21067:21080:21444:21627:21966:21990:30054:30065,0,RBL:209.85.222.194:@lca.pw:.lbl8.mailshell.net-66.201.201.201 62.14.0.100,CacheIP:none,Bayesian:0.5,0.5,0.5,Netcheck:none,DomainCache:0,MSF:not bulk,SPF:fp,MSBL:0,DNSBL:neutral,Custom_rules:0:0:0,LFtime:109,LUA_SUMMARY:none X-HE-Tag: men75_2f55aa7f86a14 X-Filterd-Recvd-Size: 4946 Received: from mail-qk1-f194.google.com (mail-qk1-f194.google.com [209.85.222.194]) by imf29.hostedemail.com (Postfix) with ESMTP for ; Tue, 17 Mar 2020 13:22:05 +0000 (UTC) Received: by mail-qk1-f194.google.com with SMTP id z25so27439453qkj.4 for ; Tue, 17 Mar 2020 06:22:04 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=lca.pw; s=google; h=from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=BooTS55gW36ai8J66FC6mGTgbiGzFCkI2TXTYLHqnGc=; b=X7ZelAWQ7nwxsy3GpfF6lmDBp6gFzEiRnpdbJeR5mX4XlZoTsXc6NA+BAlwT+LQbHS v18rFiFdYOYZArh7/h+1Ep/e9Uiw/i+uJbx7cQiv5K/+Li7B2vXeJ8qO0bP+N/AisdJ4 6Rzzq3kigFAVb4f6HrCuoEo4o7bCcJn4cl2Fy9h9ie58oR29vnGLqwHeaXrm0mZumdq9 ZWFTgEB2UOopuQRtzfywlfwXrsRTiur8omjm8TkteWXFSr2czztQ0kDyBZdXQdZ7IdHz NlvkTGz8ObmjeUdBT5RscuificYkpq4keZx5YLC1xFfrdX0W8ZDqNFeqOftZjIX6GcJJ kUfA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=BooTS55gW36ai8J66FC6mGTgbiGzFCkI2TXTYLHqnGc=; b=AkIQCfpUPDRg8pM/pyxQFuFZ6gEkUvSxBed9kEEhor7jL8aW5cSDYU10Ae2RW5fwXq f4BYYBYUjoUzC2bHrMxQFH4sYQH9EW18f1wYq8xrRqSVl3DSLw1NfCIzlkNP4aPev51q Qtc7d8AavZzv/rjzoJTcOgqkjvKHi97R1XYETYqK2HDeYis5XoxthGW//4o1ryJYCC5L KkJjMdxzNbrkZDDIe5ydYpFhHZHOuv82gAUhkytUtYKNJRapljKdntvJpW6Jzi5BLYZf JqjKhtBbhS1GzBQvS7H/oPt9NdHIRG7ZyH9wqKGVLAUKyA+fY6+0ZSFF4T5NdqqqP7QW lVzQ== X-Gm-Message-State: ANhLgQ3CWN0V2jzl/eSxETHIvtHk9T1MIfynbqhJdqE8oUBy1Q67PCdH z24iXrOHIqTwoT2AlL+bIaM/kg== X-Google-Smtp-Source: ADFU+vuoeqGw++ekYdgJ3cqO5Fw6bRoSYhCb6wK/ilXVoC2TYGulSobvHJm1dWdUV+euKh4JCX8JPg== X-Received: by 2002:a05:620a:21ce:: with SMTP id h14mr4469320qka.363.1584451324432; Tue, 17 Mar 2020 06:22:04 -0700 (PDT) Received: from ovpn-66-200.rdu2.redhat.com (pool-71-184-117-43.bstnma.fios.verizon.net. [71.184.117.43]) by smtp.gmail.com with ESMTPSA id d13sm2093752qto.33.2020.03.17.06.22.02 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Tue, 17 Mar 2020 06:22:03 -0700 (PDT) From: Qian Cai To: akpm@linux-foundation.org Cc: elver@google.com, catalin.marinas@arm.com, linux-mm@kvack.org, linux-kernel@vger.kernel.org, Qian Cai Subject: [PATCH -next] mm/kmemleak: annotate a data race in checksum Date: Tue, 17 Mar 2020 09:21:57 -0400 Message-Id: <20200317132157.1272-1-cai@lca.pw> X-Mailer: git-send-email 2.21.0 (Apple Git-122.2) MIME-Version: 1.0 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: Even if KCSAN is disabled for kmemleak, update_checksum() could still call crc32() (which is outside of kmemleak.c) to dereference object->pointer. Thus, the value of object->pointer could be accessed concurrently as noticed by KCSAN, BUG: KCSAN: data-race in crc32_le_base / do_raw_spin_lock write to 0xffffb0ea683a7d50 of 4 bytes by task 23575 on cpu 12: do_raw_spin_lock+0x114/0x200 debug_spin_lock_after at kernel/locking/spinlock_debug.c:91 (inlined by) do_raw_spin_lock at kernel/locking/spinlock_debug.c:115 _raw_spin_lock+0x40/0x50 __handle_mm_fault+0xa9e/0xd00 handle_mm_fault+0xfc/0x2f0 do_page_fault+0x263/0x6f9 page_fault+0x34/0x40 read to 0xffffb0ea683a7d50 of 4 bytes by task 839 on cpu 60: crc32_le_base+0x67/0x350 crc32_le_base+0x67/0x350: crc32_body at lib/crc32.c:106 (inlined by) crc32_le_generic at lib/crc32.c:179 (inlined by) crc32_le at lib/crc32.c:197 kmemleak_scan+0x528/0xd90 update_checksum at mm/kmemleak.c:1172 (inlined by) kmemleak_scan at mm/kmemleak.c:1497 kmemleak_scan_thread+0xcc/0xfa kthread+0x1e0/0x200 ret_from_fork+0x27/0x50 If a shattered value was returned due to a data race, it will be corrected in the next scan. Thus, annotate it as an intentional data race using the data_race() macro. Signed-off-by: Qian Cai --- mm/kmemleak.c | 7 ++++++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/mm/kmemleak.c b/mm/kmemleak.c index e362dc3d2028..d3327756c3a4 100644 --- a/mm/kmemleak.c +++ b/mm/kmemleak.c @@ -1169,7 +1169,12 @@ static bool update_checksum(struct kmemleak_object *object) u32 old_csum = object->checksum; kasan_disable_current(); - object->checksum = crc32(0, (void *)object->pointer, object->size); + /* + * crc32() will dereference object->pointer. If an unstable value was + * returned due to a data race, it will be corrected in the next scan. + */ + object->checksum = data_race(crc32(0, (void *)object->pointer, + object->size)); kasan_enable_current(); return object->checksum != old_csum;