From patchwork Tue Mar 17 17:56:40 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Qian Cai X-Patchwork-Id: 11443669 Return-Path: Received: from mail.kernel.org (pdx-korg-mail-1.web.codeaurora.org [172.30.200.123]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id 8C09A92A for ; Tue, 17 Mar 2020 17:56:54 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 4A13C20738 for ; Tue, 17 Mar 2020 17:56:54 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (2048-bit key) header.d=lca.pw header.i=@lca.pw header.b="l8YkbChH" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 4A13C20738 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=lca.pw Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id 5D7976B0005; Tue, 17 Mar 2020 13:56:53 -0400 (EDT) Delivered-To: linux-mm-outgoing@kvack.org Received: by kanga.kvack.org (Postfix, from userid 40) id 5B9706B0006; Tue, 17 Mar 2020 13:56:53 -0400 (EDT) X-Original-To: int-list-linux-mm@kvack.org X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 4C52C6B0007; Tue, 17 Mar 2020 13:56:53 -0400 (EDT) X-Original-To: linux-mm@kvack.org X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0074.hostedemail.com [216.40.44.74]) by kanga.kvack.org (Postfix) with ESMTP id 34D266B0005 for ; Tue, 17 Mar 2020 13:56:53 -0400 (EDT) Received: from smtpin10.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay04.hostedemail.com (Postfix) with ESMTP id 0680D5C0 for ; Tue, 17 Mar 2020 17:56:53 +0000 (UTC) X-FDA: 76605609906.10.voice23_76393fba68a4b X-Spam-Summary: 2,0,0,4bd9b7cf6d4ca3e7,d41d8cd98f00b204,cai@lca.pw,,RULES_HIT:2:41:69:355:379:541:800:960:973:982:988:989:1260:1311:1314:1345:1437:1515:1535:1606:1730:1747:1777:1792:2194:2199:2393:2559:2562:2898:3138:3139:3140:3141:3142:3355:3865:3866:3867:3870:3871:3872:3874:4119:4250:4321:4605:5007:6261:6653:7903:7904:7974:8660:8784:8957:9010:9040:9121:9163:10004:11026:11233:11473:11658:11914:12043:12296:12297:12438:12517:12519:12555:12679:12740:12895:12986:13148:13230:13894:13972:14018:14096:14394:21080:21324:21444:21451:21611:21627:21987:21990:30003:30029:30054:30056:30065:30070:30075:30080,0,RBL:209.85.160.195:@lca.pw:.lbl8.mailshell.net-66.201.201.201 62.14.0.100,CacheIP:none,Bayesian:0.5,0.5,0.5,Netcheck:none,DomainCache:0,MSF:not bulk,SPF:fp,MSBL:0,DNSBL:neutral,Custom_rules:0:0:0,LFtime:130,LUA_SUMMARY:none X-HE-Tag: voice23_76393fba68a4b X-Filterd-Recvd-Size: 8235 Received: from mail-qt1-f195.google.com (mail-qt1-f195.google.com [209.85.160.195]) by imf03.hostedemail.com (Postfix) with ESMTP for ; Tue, 17 Mar 2020 17:56:52 +0000 (UTC) Received: by mail-qt1-f195.google.com with SMTP id v15so18283484qto.2 for ; Tue, 17 Mar 2020 10:56:51 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=lca.pw; s=google; h=from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=4WGq4CF/dR8iCUj35XbboYwcU6jq/WMDHaS7e14zUHU=; b=l8YkbChHMzRzyWgsYzMiOOaKQwqIBfBczFU/QbsilDui8FS7SvOG+wBcK5QvoH2xUV zsY+luGTXUMkvCfYw0krokGbr6uX3EkjAJpALUEVpwCScJqmdk4fS1801CVmf4pQ0Sg+ q4S2DcEsWuvZkJZnKL+l0GSNrj87Rf2WwAZ0agwI7kli4Q2lZi21DTKHnN/LFXCx3Nt+ uw1kc1QWxj/pw1xeQrpIc2WEbd57LCNMzNg3x7bZQSYzbCllPFHvLl6bwRn4sCQ5Kukk +xKfTx3z3Gkr/czGD+Sjaz3P/dxTuOUZoC//eKBNYJz7tJXvN4JLYod2vKY/Loaee7I+ K5UA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=4WGq4CF/dR8iCUj35XbboYwcU6jq/WMDHaS7e14zUHU=; b=F/RIxOTRGH91itBWnJOMwf44jHDlgi3dCJhpFuQpsXYBV6RWNu9gBXonUXNXmBjCZy mAuunlmq46WO5WPs1nM9OudAJ8Q8bOwapHWbwEO8ToS7FWOy29GLxl9sdJUKDEyW/zn8 MeN+Bn6wEYHkKYVIPsx/+zkYaHj13ZsksYsRnpie2jwhjE8z3pzxTNGAx69BP2sIjOtJ Uonq6JZjV7g37DFHmjMXlPyezBOGxmkDGy5QhmJ0jnZ6B77xF+sZD5WqSi56FCRkTYUF UOc0MT+iD3AI5Z4XyRoFwdt66cOJUYaECq5MblcKNxTYN5uQSpTXqp0a9+UZq9mmmfpb 3HXQ== X-Gm-Message-State: ANhLgQ3KqllXRxDqoDg/18sKCjJnpEba+9315Z/HBcyjp2+BLfGmy/S3 RP8VqI5ykhheyG+BZxnMP1FUxA== X-Google-Smtp-Source: ADFU+vuKg6hr6xOxDHVZru0yHgshRbjUlraQHnxbwMpRAaCMlvZfgToLAacWGLp4vMhXlyfRL13Ugg== X-Received: by 2002:ac8:7b39:: with SMTP id l25mr387464qtu.72.1584467811291; Tue, 17 Mar 2020 10:56:51 -0700 (PDT) Received: from ovpn-66-200.rdu2.redhat.com (pool-71-184-117-43.bstnma.fios.verizon.net. [71.184.117.43]) by smtp.gmail.com with ESMTPSA id r6sm2285068qkf.71.2020.03.17.10.56.49 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Tue, 17 Mar 2020 10:56:50 -0700 (PDT) From: Qian Cai To: akpm@linux-foundation.org Cc: jgg@ziepe.ca, paulmck@kernel.org, linux-mm@kvack.org, linux-kernel@vger.kernel.org, Qian Cai Subject: [PATCH] mm/mmu_notifier: silence PROVE_RCU_LIST warnings Date: Tue, 17 Mar 2020 13:56:40 -0400 Message-Id: <20200317175640.2047-1-cai@lca.pw> X-Mailer: git-send-email 2.21.0 (Apple Git-122.2) MIME-Version: 1.0 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000044, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: It is safe to traverse mm->notifier_subscriptions->list either under SRCU read lock or mm->notifier_subscriptions->lock using hlist_for_each_entry_rcu(). Silence the PROVE_RCU_LIST false positives, for example, WARNING: suspicious RCU usage ----------------------------- mm/mmu_notifier.c:484 RCU-list traversed in non-reader section!! other info that might help us debug this: rcu_scheduler_active = 2, debug_locks = 1 3 locks held by libvirtd/802: #0: ffff9321e3f58148 (&mm->mmap_sem#2){++++}, at: do_mprotect_pkey+0xe1/0x3e0 #1: ffffffff91ae6160 (mmu_notifier_invalidate_range_start){+.+.}, at: change_p4d_range+0x5fa/0x800 #2: ffffffff91ae6e08 (srcu){....}, at: __mmu_notifier_invalidate_range_start+0x178/0x460 stack backtrace: CPU: 7 PID: 802 Comm: libvirtd Tainted: G I 5.6.0-rc6-next-20200317+ #2 Hardware name: HP ProLiant BL460c Gen8, BIOS I31 11/02/2014 Call Trace: dump_stack+0xa4/0xfe lockdep_rcu_suspicious+0xeb/0xf5 __mmu_notifier_invalidate_range_start+0x3ff/0x460 change_p4d_range+0x746/0x800 change_protection+0x1df/0x300 mprotect_fixup+0x245/0x3e0 do_mprotect_pkey+0x23b/0x3e0 __x64_sys_mprotect+0x51/0x70 do_syscall_64+0x91/0xae8 entry_SYSCALL_64_after_hwframe+0x49/0xb3 Signed-off-by: Qian Cai Reviewed-by: Paul E. McKenney Reviewed-by: Jason Gunthorpe --- mm/mmu_notifier.c | 27 ++++++++++++++++++--------- 1 file changed, 18 insertions(+), 9 deletions(-) diff --git a/mm/mmu_notifier.c b/mm/mmu_notifier.c index ef3973a5d34a..06852b896fa6 100644 --- a/mm/mmu_notifier.c +++ b/mm/mmu_notifier.c @@ -307,7 +307,8 @@ static void mn_hlist_release(struct mmu_notifier_subscriptions *subscriptions, * ->release returns. */ id = srcu_read_lock(&srcu); - hlist_for_each_entry_rcu(subscription, &subscriptions->list, hlist) + hlist_for_each_entry_rcu(subscription, &subscriptions->list, hlist, + srcu_read_lock_held(&srcu)) /* * If ->release runs before mmu_notifier_unregister it must be * handled, as it's the only way for the driver to flush all @@ -370,7 +371,8 @@ int __mmu_notifier_clear_flush_young(struct mm_struct *mm, id = srcu_read_lock(&srcu); hlist_for_each_entry_rcu(subscription, - &mm->notifier_subscriptions->list, hlist) { + &mm->notifier_subscriptions->list, hlist, + srcu_read_lock_held(&srcu)) { if (subscription->ops->clear_flush_young) young |= subscription->ops->clear_flush_young( subscription, mm, start, end); @@ -389,7 +391,8 @@ int __mmu_notifier_clear_young(struct mm_struct *mm, id = srcu_read_lock(&srcu); hlist_for_each_entry_rcu(subscription, - &mm->notifier_subscriptions->list, hlist) { + &mm->notifier_subscriptions->list, hlist, + srcu_read_lock_held(&srcu)) { if (subscription->ops->clear_young) young |= subscription->ops->clear_young(subscription, mm, start, end); @@ -407,7 +410,8 @@ int __mmu_notifier_test_young(struct mm_struct *mm, id = srcu_read_lock(&srcu); hlist_for_each_entry_rcu(subscription, - &mm->notifier_subscriptions->list, hlist) { + &mm->notifier_subscriptions->list, hlist, + srcu_read_lock_held(&srcu)) { if (subscription->ops->test_young) { young = subscription->ops->test_young(subscription, mm, address); @@ -428,7 +432,8 @@ void __mmu_notifier_change_pte(struct mm_struct *mm, unsigned long address, id = srcu_read_lock(&srcu); hlist_for_each_entry_rcu(subscription, - &mm->notifier_subscriptions->list, hlist) { + &mm->notifier_subscriptions->list, hlist, + srcu_read_lock_held(&srcu)) { if (subscription->ops->change_pte) subscription->ops->change_pte(subscription, mm, address, pte); @@ -476,7 +481,8 @@ static int mn_hlist_invalidate_range_start( int id; id = srcu_read_lock(&srcu); - hlist_for_each_entry_rcu(subscription, &subscriptions->list, hlist) { + hlist_for_each_entry_rcu(subscription, &subscriptions->list, hlist, + srcu_read_lock_held(&srcu)) { const struct mmu_notifier_ops *ops = subscription->ops; if (ops->invalidate_range_start) { @@ -528,7 +534,8 @@ mn_hlist_invalidate_end(struct mmu_notifier_subscriptions *subscriptions, int id; id = srcu_read_lock(&srcu); - hlist_for_each_entry_rcu(subscription, &subscriptions->list, hlist) { + hlist_for_each_entry_rcu(subscription, &subscriptions->list, hlist, + srcu_read_lock_held(&srcu)) { /* * Call invalidate_range here too to avoid the need for the * subsystem of having to register an invalidate_range_end @@ -582,7 +589,8 @@ void __mmu_notifier_invalidate_range(struct mm_struct *mm, id = srcu_read_lock(&srcu); hlist_for_each_entry_rcu(subscription, - &mm->notifier_subscriptions->list, hlist) { + &mm->notifier_subscriptions->list, hlist, + srcu_read_lock_held(&srcu)) { if (subscription->ops->invalidate_range) subscription->ops->invalidate_range(subscription, mm, start, end); @@ -714,7 +722,8 @@ find_get_mmu_notifier(struct mm_struct *mm, const struct mmu_notifier_ops *ops) spin_lock(&mm->notifier_subscriptions->lock); hlist_for_each_entry_rcu(subscription, - &mm->notifier_subscriptions->list, hlist) { + &mm->notifier_subscriptions->list, hlist, + lockdep_is_held(&mm->notifier_subscriptions->lock)) { if (subscription->ops != ops) continue;