From patchwork Fri Apr 3 11:29:23 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: "Kirill A . Shutemov" X-Patchwork-Id: 11472557 Return-Path: Received: from mail.kernel.org (pdx-korg-mail-1.web.codeaurora.org [172.30.200.123]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id 4292B14DD for ; Fri, 3 Apr 2020 11:29:38 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 0DC202082F for ; Fri, 3 Apr 2020 11:29:38 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (2048-bit key) header.d=shutemov-name.20150623.gappssmtp.com header.i=@shutemov-name.20150623.gappssmtp.com header.b="sCxEbPsB" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 0DC202082F Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=shutemov.name Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id E267B8E0009; Fri, 3 Apr 2020 07:29:35 -0400 (EDT) Delivered-To: linux-mm-outgoing@kvack.org Received: by kanga.kvack.org (Postfix, from userid 40) id DD6068E0007; Fri, 3 Apr 2020 07:29:35 -0400 (EDT) X-Original-To: int-list-linux-mm@kvack.org X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id CC6248E0009; Fri, 3 Apr 2020 07:29:35 -0400 (EDT) X-Original-To: linux-mm@kvack.org X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0041.hostedemail.com [216.40.44.41]) by kanga.kvack.org (Postfix) with ESMTP id 93F768E0007 for ; Fri, 3 Apr 2020 07:29:35 -0400 (EDT) Received: from smtpin19.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay05.hostedemail.com (Postfix) with ESMTP id 53CF0181AEF1A for ; Fri, 3 Apr 2020 11:29:35 +0000 (UTC) X-FDA: 76666323510.19.coach28_369484cc46f47 X-Spam-Summary: 2,0,0,20f49ac07d78c40d,d41d8cd98f00b204,kirill@shutemov.name,,RULES_HIT:41:173:355:379:541:960:973:988:989:1260:1311:1314:1345:1359:1437:1515:1534:1539:1711:1714:1730:1747:1777:1792:2393:2559:2562:3138:3139:3140:3141:3142:3351:3865:3867:3868:3870:3872:4250:5007:6261:6653:10004:11026:11658:11914:12043:12297:12438:12517:12519:12555:12895:13069:13311:13357:13894:14096:14181:14384:14394:14721:21080:21324:21444:21451:21627:30054,0,RBL:209.85.208.176:@shutemov.name:.lbl8.mailshell.net-62.8.0.100 66.201.201.201,CacheIP:none,Bayesian:0.5,0.5,0.5,Netcheck:none,DomainCache:0,MSF:not bulk,SPF:fn,MSBL:0,DNSBL:neutral,Custom_rules:0:0:0,LFtime:25,LUA_SUMMARY:none X-HE-Tag: coach28_369484cc46f47 X-Filterd-Recvd-Size: 4081 Received: from mail-lj1-f176.google.com (mail-lj1-f176.google.com [209.85.208.176]) by imf43.hostedemail.com (Postfix) with ESMTP for ; Fri, 3 Apr 2020 11:29:34 +0000 (UTC) Received: by mail-lj1-f176.google.com with SMTP id g27so6512268ljn.10 for ; Fri, 03 Apr 2020 04:29:34 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=shutemov-name.20150623.gappssmtp.com; s=20150623; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=UDV67uaM0olVe42g3gcRUTFOTLKxm8Yf483YPZ3Dud8=; b=sCxEbPsBTakoE1xknw2RtO2rz8oxNAb6cCS8SzCviLU+wXJ5m+DFbQMKB/W7GcAtYQ D/0LK1slWaUCNicIxwMSPPcXyy0SuopgawhAqBDv8LGru/h2Rz//tPVcOCiAX0SeMfie Rtmac2n0Qy8TbXeXOE4KNNFMQCPwok9lSTX2O0YBd41GsuzvfaBW+oKM/+RQaey1e1CJ F7HBir5eC9AV6iJ3nDVZiaM9M6YOksUJ7CwPnmOYtDbgDLtLnz60hL49JSVAixZuYBQv zN9NlOYVLhwtvCwlZiirwMvkOanRxXL2qLV3wkgtzXR8972SVxScB7hqZL3eWlOC48Ye rPZg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=UDV67uaM0olVe42g3gcRUTFOTLKxm8Yf483YPZ3Dud8=; b=VwD4jq4cqi3IAe7vhBqhsO5Cdzq+NMqcWP8Rp57MuTX7+KLnoheyQSzxt0z4gzlB1q b+4sm3rN1hGPDnnSr8V9OcAstV3Tcy8eblaWNMiPG11ibKHPs0PQmgQadCJWAYpLbtwH pi6sw/hHq1NkX0g/Z8CnczQO7k/ywqy3qww2kCOHsDmiU3h8ETdmJPWWQ5JYnjiC6ncl ERRNGDtY5bbnMApyKtZ5gpQbP+pMkIxNkko5BYMlSdhfXGzdeWrffmu6PefJ95WvXpBx QnC8ofY4+KuYR2QyHSBp4Rj2dPnq4D+N88tGubgO2Ufa27FidodoDegmL9GvD8erBDdW kNHg== X-Gm-Message-State: AGi0PuY5cDow0UdqCmf7nuHK5znrrGFDxNJkpltGYHyOQ/Aj9gr7JwZn stPDr8H45I/NvwjsXITqIvLRTJqpw6o= X-Google-Smtp-Source: APiQypKJovl0REGHDL9yO1HGUDFWiM4HR9jobJ/t8s9UpGtLW4jkkAHDaE6pZx5lnJh/RuFHjMKwQA== X-Received: by 2002:a2e:3203:: with SMTP id y3mr4372576ljy.54.1585913373250; Fri, 03 Apr 2020 04:29:33 -0700 (PDT) Received: from box.localdomain ([86.57.175.117]) by smtp.gmail.com with ESMTPSA id g5sm4839412ljl.106.2020.04.03.04.29.31 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 03 Apr 2020 04:29:32 -0700 (PDT) From: "Kirill A. Shutemov" X-Google-Original-From: "Kirill A. Shutemov" Received: by box.localdomain (Postfix, from userid 1000) id 720FE101331; Fri, 3 Apr 2020 14:29:31 +0300 (+03) To: akpm@linux-foundation.org, Andrea Arcangeli Cc: Zi Yan , Yang Shi , linux-mm@kvack.org, linux-kernel@vger.kernel.org, "Kirill A. Shutemov" Subject: [PATCHv2 3/8] khugepaged: Drain all LRU caches before scanning pages Date: Fri, 3 Apr 2020 14:29:23 +0300 Message-Id: <20200403112928.19742-4-kirill.shutemov@linux.intel.com> X-Mailer: git-send-email 2.26.0 In-Reply-To: <20200403112928.19742-1-kirill.shutemov@linux.intel.com> References: <20200403112928.19742-1-kirill.shutemov@linux.intel.com> MIME-Version: 1.0 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: Having a page in LRU add cache offsets page refcount and gives false-negative on PageLRU(). It reduces collapse success rate. Drain all LRU add caches before scanning. It happens relatively rare and should not disturb the system too much. Signed-off-by: Kirill A. Shutemov Acked-by: Yang Shi --- mm/khugepaged.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/mm/khugepaged.c b/mm/khugepaged.c index 14d7afc90786..fdc10ffde1ca 100644 --- a/mm/khugepaged.c +++ b/mm/khugepaged.c @@ -2065,6 +2065,8 @@ static void khugepaged_do_scan(void) barrier(); /* write khugepaged_pages_to_scan to local stack */ + lru_add_drain_all(); + while (progress < pages) { if (!khugepaged_prealloc_page(&hpage, &wait)) break;