| Message ID | 20200422204708.2176080-17-guro@fb.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | The new cgroup slab memory controller | expand |
On 4/22/20 10:47 PM, Roman Gushchin wrote: > memcg_accumulate_slabinfo() is never called with a non-root > kmem_cache as a first argument, so the is_root_cache(s) check > is redundant and can be removed without any functional change. > > Signed-off-by: Roman Gushchin <guro@fb.com> Reviewed-by: Vlastimil Babka <vbabka@suse.cz> The check is also in memcg_cache() anyway. > --- > mm/slab_common.c | 3 --- > 1 file changed, 3 deletions(-) > > diff --git a/mm/slab_common.c b/mm/slab_common.c > index c045afb9724e..52164ad0f197 100644 > --- a/mm/slab_common.c > +++ b/mm/slab_common.c > @@ -1087,9 +1087,6 @@ memcg_accumulate_slabinfo(struct kmem_cache *s, struct slabinfo *info) > struct kmem_cache *c; > struct slabinfo sinfo; > > - if (!is_root_cache(s)) > - return; > - > c = memcg_cache(s); > if (c) { > memset(&sinfo, 0, sizeof(sinfo)); >
diff --git a/mm/slab_common.c b/mm/slab_common.c index c045afb9724e..52164ad0f197 100644 --- a/mm/slab_common.c +++ b/mm/slab_common.c @@ -1087,9 +1087,6 @@ memcg_accumulate_slabinfo(struct kmem_cache *s, struct slabinfo *info) struct kmem_cache *c; struct slabinfo sinfo; - if (!is_root_cache(s)) - return; - c = memcg_cache(s); if (c) { memset(&sinfo, 0, sizeof(sinfo));
memcg_accumulate_slabinfo() is never called with a non-root kmem_cache as a first argument, so the is_root_cache(s) check is redundant and can be removed without any functional change. Signed-off-by: Roman Gushchin <guro@fb.com> --- mm/slab_common.c | 3 --- 1 file changed, 3 deletions(-)