From patchwork Mon May 4 15:02:25 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Alexandre Chartre X-Patchwork-Id: 11526505 Return-Path: Received: from mail.kernel.org (pdx-korg-mail-1.web.codeaurora.org [172.30.200.123]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id C7CAC14C0 for ; Mon, 4 May 2020 15:06:34 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 862122087E for ; Mon, 4 May 2020 15:06:34 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=oracle.com header.i=@oracle.com header.b="b3WfzdZM" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 862122087E Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=oracle.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id A4B1F8E0044; Mon, 4 May 2020 11:06:33 -0400 (EDT) Delivered-To: linux-mm-outgoing@kvack.org Received: by kanga.kvack.org (Postfix, from userid 40) id 9D4378E0024; Mon, 4 May 2020 11:06:33 -0400 (EDT) X-Original-To: int-list-linux-mm@kvack.org X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 89C478E0044; Mon, 4 May 2020 11:06:33 -0400 (EDT) X-Original-To: linux-mm@kvack.org X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0235.hostedemail.com [216.40.44.235]) by kanga.kvack.org (Postfix) with ESMTP id 6F7F68E0024 for ; Mon, 4 May 2020 11:06:33 -0400 (EDT) Received: from smtpin12.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay02.hostedemail.com (Postfix) with ESMTP id 3D20C19B01 for ; Mon, 4 May 2020 15:06:33 +0000 (UTC) X-FDA: 76779363066.12.heart30_735fa5bf23563 X-Spam-Summary: 1,0,0,,d41d8cd98f00b204,alexandre.chartre@oracle.com,,RULES_HIT:30034:30054:30056:30064,0,RBL:141.146.126.78:@oracle.com:.lbl8.mailshell.net-64.10.201.10 62.18.0.100,CacheIP:none,Bayesian:0.5,0.5,0.5,Netcheck:none,DomainCache:0,MSF:not bulk,SPF:ft,MSBL:0,DNSBL:neutral,Custom_rules:0:0:0,LFtime:24,LUA_SUMMARY:none X-HE-Tag: heart30_735fa5bf23563 X-Filterd-Recvd-Size: 7499 Received: from aserp2120.oracle.com (aserp2120.oracle.com [141.146.126.78]) by imf36.hostedemail.com (Postfix) with ESMTP for ; Mon, 4 May 2020 15:06:32 +0000 (UTC) Received: from pps.filterd (aserp2120.oracle.com [127.0.0.1]) by aserp2120.oracle.com (8.16.0.42/8.16.0.42) with SMTP id 044En9fS024718; Mon, 4 May 2020 15:06:23 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oracle.com; h=from : to : cc : subject : date : message-id : in-reply-to : references; s=corp-2020-01-29; bh=GdpSgFkEZ+Ur+ACfjLTgXfvY2O4IFXjjIbm/9Da3I/U=; b=b3WfzdZMrbDnbmyd5xFgV2+BKRnWt5HgHioOzu3QHzViYK85ZAPRmsyfspWC8h6K4I0p KK8P43R8WJg+ECSwDg1e2Jggg8+Zph7kmTJQ9qLwLmMN0GBV2DpHDaZRsk9gFIxpqvjI YlD1HnMjYvQvyHkNZEtcnygNDw+Ni6GaSvIWwvW+OKxEdQCVJsJIluAjc4Qe2bWSUsEi 1BrhbiIQGpQt4bIGmnbc60+ravI29lRgjTA7U7B0YSDiY5EJX5ltLDsrw8gW5yhC33nC 7pGoBevJMsXbtID7LfM8j08e/aKEhzi3ql9IXOwZ96DBwPTLRM5ckNXdeoMUVLd39cag Mw== Received: from aserp3030.oracle.com (aserp3030.oracle.com [141.146.126.71]) by aserp2120.oracle.com with ESMTP id 30s0tm7f8a-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Mon, 04 May 2020 15:06:23 +0000 Received: from pps.filterd (aserp3030.oracle.com [127.0.0.1]) by aserp3030.oracle.com (8.16.0.42/8.16.0.42) with SMTP id 044Ekfvq094713; Mon, 4 May 2020 15:04:23 GMT Received: from userv0122.oracle.com (userv0122.oracle.com [156.151.31.75]) by aserp3030.oracle.com with ESMTP id 30sjdqqnra-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Mon, 04 May 2020 15:04:23 +0000 Received: from abhmp0004.oracle.com (abhmp0004.oracle.com [141.146.116.10]) by userv0122.oracle.com (8.14.4/8.14.4) with ESMTP id 044F4LKe025185; Mon, 4 May 2020 15:04:21 GMT Received: from linux-1.home.com (/10.175.9.166) by default (Oracle Beehive Gateway v4.0) with ESMTP ; Mon, 04 May 2020 08:04:20 -0700 From: Alexandre Chartre To: tglx@linutronix.de, mingo@redhat.com, bp@alien8.de, hpa@zytor.com, dave.hansen@linux.intel.com, luto@kernel.org, peterz@infradead.org, x86@kernel.org, linux-mm@kvack.org, linux-kernel@vger.kernel.org Cc: pbonzini@redhat.com, konrad.wilk@oracle.com, jan.setjeeilers@oracle.com, liran.alon@oracle.com, junaids@google.com, graf@amazon.de, rppt@linux.vnet.ibm.com, kuzuno@gmail.com, mgross@linux.intel.com, alexandre.chartre@oracle.com Subject: [RFC v4][PATCH part-3 04/14] asidrv: Sequence to test ASI access to mapped/unmapped memory Date: Mon, 4 May 2020 17:02:25 +0200 Message-Id: <20200504150235.12171-5-alexandre.chartre@oracle.com> X-Mailer: git-send-email 2.18.2 In-Reply-To: <20200504150235.12171-1-alexandre.chartre@oracle.com> References: <20200504150235.12171-1-alexandre.chartre@oracle.com> X-Proofpoint-Virus-Version: vendor=nai engine=6000 definitions=9610 signatures=668687 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 spamscore=0 suspectscore=0 mlxscore=0 bulkscore=0 adultscore=0 phishscore=0 mlxlogscore=999 malwarescore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2003020000 definitions=main-2005040123 X-Proofpoint-Virus-Version: vendor=nai engine=6000 definitions=9610 signatures=668687 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 malwarescore=0 mlxscore=0 priorityscore=1501 lowpriorityscore=0 spamscore=0 suspectscore=0 phishscore=0 clxscore=1015 bulkscore=0 mlxlogscore=999 adultscore=0 impostorscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2003020000 definitions=main-2005040123 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: Add a sequence to test if ASI exit or not when accessing a mapped or unmapped memory buffer. Signed-off-by: Alexandre Chartre --- drivers/staging/asi/asidrv.c | 70 ++++++++++++++++++++++++++++++++++++ drivers/staging/asi/asidrv.h | 3 ++ 2 files changed, 73 insertions(+) diff --git a/drivers/staging/asi/asidrv.c b/drivers/staging/asi/asidrv.c index 4f0548edb2f9..4231b56db167 100644 --- a/drivers/staging/asi/asidrv.c +++ b/drivers/staging/asi/asidrv.c @@ -14,9 +14,21 @@ #include "asidrv.h" +#define ASIDRV_TEST_BUFFER_SIZE PAGE_SIZE + +/* Number of read for mem/memmap test sequence */ +#define ASIDRV_MEM_READ_COUNT 1000 + +enum asidrv_state { + ASIDRV_STATE_NONE, + ASIDRV_STATE_INTR_WAITING, + ASIDRV_STATE_INTR_RECEIVED, +}; + struct asidrv_test { struct asi *asi; /* ASI for testing */ struct dpt *dpt; /* ASI decorated page-table */ + char *buffer; /* buffer for testing */ }; struct asidrv_sequence { @@ -42,6 +54,10 @@ static struct asidrv_test *asidrv_test_create(void) if (!test) return NULL; + test->buffer = kzalloc(ASIDRV_TEST_BUFFER_SIZE, GFP_KERNEL); + if (!test->buffer) + goto error; + /* * Create and fill a decorator page-table to be used with the ASI. */ @@ -96,6 +112,7 @@ static void asidrv_test_destroy(struct asidrv_test *test) if (test->asi) asi_destroy(test->asi); + kfree(test->buffer); kfree(test); } @@ -143,6 +160,51 @@ static int asidrv_asi_is_active(struct asi *asi) return false; } +/* + * Memory Buffer Access Test Sequences + */ + +#define OPTNONE __attribute__((optimize(0))) + +static enum asidrv_run_error OPTNONE asidrv_mem_run(struct asidrv_test *test) +{ + char c; + int i, index; + + /* + * Do random reads in the test buffer, and return if the ASI + * becomes inactive. + */ + for (i = 0; i < ASIDRV_MEM_READ_COUNT; i++) { + index = get_cycles() % ASIDRV_TEST_BUFFER_SIZE; + c = test->buffer[index]; + if (!asidrv_asi_is_active(test->asi)) { + pr_warn("ASI inactive after reading byte %d at %d\n", + i + 1, index); + break; + } + } + + return ASIDRV_RUN_ERR_NONE; +} + +static enum asidrv_run_error asidrv_memmap_setup(struct asidrv_test *test) +{ + int err; + + pr_debug("mapping test buffer %px\n", test->buffer); + err = dpt_map(test->dpt, test->buffer, ASIDRV_TEST_BUFFER_SIZE); + if (err) + return ASIDRV_RUN_ERR_MAP_BUFFER; + + return ASIDRV_RUN_ERR_NONE; +} + +static void asidrv_memmap_cleanup(struct asidrv_test *test) +{ + dpt_unmap(test->dpt, test->buffer); +} + /* * Printk Test Sequence */ @@ -161,6 +223,14 @@ struct asidrv_sequence asidrv_sequences[] = { "printk", NULL, asidrv_printk_run, NULL, }, + [ASIDRV_SEQ_MEM] = { + "mem", + NULL, asidrv_mem_run, NULL, + }, + [ASIDRV_SEQ_MEMMAP] = { + "memmap", + asidrv_memmap_setup, asidrv_mem_run, asidrv_memmap_cleanup, + }, }; static enum asidrv_run_error asidrv_run_init(struct asidrv_test *test) diff --git a/drivers/staging/asi/asidrv.h b/drivers/staging/asi/asidrv.h index 33acb058c443..1e820cc64f13 100644 --- a/drivers/staging/asi/asidrv.h +++ b/drivers/staging/asi/asidrv.h @@ -8,6 +8,8 @@ enum asidrv_seqnum { ASIDRV_SEQ_NOP, /* empty sequence */ ASIDRV_SEQ_PRINTK, /* printk sequence */ + ASIDRV_SEQ_MEM, /* access unmapped memory */ + ASIDRV_SEQ_MEMMAP, /* access mapped memory */ }; enum asidrv_run_error { @@ -17,6 +19,7 @@ enum asidrv_run_error { ASIDRV_RUN_ERR_MAP_TASK, /* failed to map current task */ ASIDRV_RUN_ERR_ENTER, /* failed to enter ASI */ ASIDRV_RUN_ERR_ACTIVE, /* ASI is not active after entering ASI */ + ASIDRV_RUN_ERR_MAP_BUFFER, /* failed to map buffer */ }; #define ASIDRV_IOCTL_RUN_SEQUENCE _IOWR('a', 1, struct asidrv_run_param)