From patchwork Sun Jun 14 12:39:23 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Muchun Song X-Patchwork-Id: 11603289 Return-Path: Received: from mail.kernel.org (pdx-korg-mail-1.web.codeaurora.org [172.30.200.123]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id 6A86D60D for ; Sun, 14 Jun 2020 12:39:54 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 2D11820747 for ; Sun, 14 Jun 2020 12:39:54 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (2048-bit key) header.d=bytedance-com.20150623.gappssmtp.com header.i=@bytedance-com.20150623.gappssmtp.com header.b="JPjtjnfY" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 2D11820747 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=bytedance.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id 4B6B06B002A; Sun, 14 Jun 2020 08:39:53 -0400 (EDT) Delivered-To: linux-mm-outgoing@kvack.org Received: by kanga.kvack.org (Postfix, from userid 40) id 48D5B6B002B; Sun, 14 Jun 2020 08:39:53 -0400 (EDT) X-Original-To: int-list-linux-mm@kvack.org X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 3CA6B6B002C; Sun, 14 Jun 2020 08:39:53 -0400 (EDT) X-Original-To: linux-mm@kvack.org X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0245.hostedemail.com [216.40.44.245]) by kanga.kvack.org (Postfix) with ESMTP id 2220F6B002A for ; Sun, 14 Jun 2020 08:39:53 -0400 (EDT) Received: from smtpin21.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay03.hostedemail.com (Postfix) with ESMTP id D35098245571 for ; Sun, 14 Jun 2020 12:39:52 +0000 (UTC) X-FDA: 76927774224.21.mice88_281010026ded Received: from filter.hostedemail.com (10.5.16.251.rfc1918.com [10.5.16.251]) by smtpin21.hostedemail.com (Postfix) with ESMTP id AABAE180442C4 for ; Sun, 14 Jun 2020 12:39:52 +0000 (UTC) X-Spam-Summary: 2,0,0,73f7beb561c0abbe,d41d8cd98f00b204,songmuchun@bytedance.com,,RULES_HIT:41:355:379:541:800:960:966:968:973:988:989:1260:1311:1314:1345:1359:1437:1515:1534:1541:1711:1730:1747:1777:1792:2196:2199:2393:2559:2562:3138:3139:3140:3141:3142:3352:3865:3866:3867:3871:3872:3874:4321:4385:5007:6261:6653:7901:7903:10004:11026:11658:11914:12043:12048:12294:12296:12297:12438:12517:12519:12555:12683:12895:13069:13161:13229:13311:13357:13894:14095:14096:14181:14384:14394:14721:21080:21444:21451:21627:21987:21990:30054,0,RBL:209.85.215.196:@bytedance.com:.lbl8.mailshell.net-62.2.0.100 66.100.201.201,CacheIP:none,Bayesian:0.5,0.5,0.5,Netcheck:none,DomainCache:0,MSF:not bulk,SPF:fp,MSBL:0,DNSBL:neutral,Custom_rules:0:0:0,LFtime:23,LUA_SUMMARY:none X-HE-Tag: mice88_281010026ded X-Filterd-Recvd-Size: 4112 Received: from mail-pg1-f196.google.com (mail-pg1-f196.google.com [209.85.215.196]) by imf14.hostedemail.com (Postfix) with ESMTP for ; Sun, 14 Jun 2020 12:39:52 +0000 (UTC) Received: by mail-pg1-f196.google.com with SMTP id l63so4129239pge.12 for ; Sun, 14 Jun 2020 05:39:51 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bytedance-com.20150623.gappssmtp.com; s=20150623; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=+068bSrQRTzwliNa3JuLLexz/LOjrev0rMh10PzRkI8=; b=JPjtjnfY+gebb1zk2du4tey5HVKYeX+m/+ub8pbP6YeBTMpjROS969iZf3azxemzet Z0FjJx1ePbqhmmFbiwcA8Si1ec1mjJfeLHORUEEiuROweMIpQsldZgRTejmdf7uRWdUc BRkWHU/806uFqRxmmx1RVd3GVqQOR0GU/qJBvK6pqxdL9CdqnBffj2AsB3T+tRQcmv+7 f17bqV0jXeYfyhb7uLfFX/sVAXbJ+dDa+KnalDDqFwVgU1G+TrLdZ66XMJrtiDz4XmE0 PQADGnDM4ODrbtXAmRfPDATcAdcEMtqWJnRK5dqDqLIYWEDj1hgRy9zTLDzMkEPOEJQI ZipQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=+068bSrQRTzwliNa3JuLLexz/LOjrev0rMh10PzRkI8=; b=Vk4No/zK6Hp2h8RTTxYP9qlwgCseRU093RZgqfedSMD6YZDonziKNj7HJ8AEeLiHmd IJd06kQLXFIGx8AJn3S051R0+DZTx7anzD267IpQJHU1+UGVOseIM1tgVYmDoRNIRmLh W86nzZ0Q0bKenJHInOJz6mUdoEv5JBzMXFMNIY0wDL/WGVYuyy8FHL/B9CeTd2mH6J5e xqbMoSJnJxSozJL5fs6lehOz7tLHzuAETAfVy2gDyZdcA3EA0Z1HYPsEqzdjEmOwd3zZ xPrJFLRbwz9h2L706xujuDUGvmnBeadbJSvyDUdxNH9gu+cxecqs1yhAJYKLktOtwORH UxyA== X-Gm-Message-State: AOAM531hNdQMK8uOB4RR4oR5o+k6vImMetggoqOEcq9F9H/MlzAYm/BA ZdHzf1KG7Cgn6Ws2zNhfTt6rX9PC1CJL2A== X-Google-Smtp-Source: ABdhPJyNXpFiweAi3/sxwpQsIUi7tzjgedJvm+DRs6z/ncE6IJZUIZy9mc5J9v8um/KPxOLLeWhYQQ== X-Received: by 2002:a05:6a00:1510:: with SMTP id q16mr18443425pfu.164.1592138391321; Sun, 14 Jun 2020 05:39:51 -0700 (PDT) Received: from Smcdef-MBP.lan ([103.136.221.68]) by smtp.gmail.com with ESMTPSA id hi19sm9776606pjb.49.2020.06.14.05.39.48 (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Sun, 14 Jun 2020 05:39:50 -0700 (PDT) From: Muchun Song To: cl@linux.com, penberg@kernel.org, rientjes@google.com, iamjoonsoo.kim@lge.com, akpm@linux-foundation.org Cc: linux-mm@kvack.org, linux-kernel@vger.kernel.org, Muchun Song Subject: [PATCH 3/3] mm/slub: Fix release all resources used by a slab cache Date: Sun, 14 Jun 2020 20:39:23 +0800 Message-Id: <20200614123923.99189-4-songmuchun@bytedance.com> X-Mailer: git-send-email 2.21.0 (Apple Git-122) In-Reply-To: <20200614123923.99189-1-songmuchun@bytedance.com> References: <20200614123923.99189-1-songmuchun@bytedance.com> MIME-Version: 1.0 X-Rspamd-Queue-Id: AABAE180442C4 X-Spamd-Result: default: False [0.00 / 100.00] X-Rspamd-Server: rspam01 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: The function of __kmem_cache_shutdown() is that release all resources used by the slab cache, while currently it stop release resources when the preceding node is not empty. Signed-off-by: Muchun Song --- mm/slub.c | 7 ++++--- 1 file changed, 4 insertions(+), 3 deletions(-) diff --git a/mm/slub.c b/mm/slub.c index b73505df3de2..4e477ef0f2b9 100644 --- a/mm/slub.c +++ b/mm/slub.c @@ -3839,6 +3839,7 @@ bool __kmem_cache_empty(struct kmem_cache *s) */ int __kmem_cache_shutdown(struct kmem_cache *s) { + int ret = 0; int node; struct kmem_cache_node *n; @@ -3846,11 +3847,11 @@ int __kmem_cache_shutdown(struct kmem_cache *s) /* Attempt to free all objects */ for_each_kmem_cache_node(s, node, n) { free_partial(s, n); - if (node_nr_slabs(n)) - return 1; + if (!ret && node_nr_slabs(n)) + ret = 1; } sysfs_slab_remove(s); - return 0; + return ret; } /********************************************************************