From patchwork Fri Jul 3 06:56:36 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Chengguang Xu X-Patchwork-Id: 11641005 Return-Path: Received: from mail.kernel.org (pdx-korg-mail-1.web.codeaurora.org [172.30.200.123]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id 9F606913 for ; Fri, 3 Jul 2020 06:57:07 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 6C258206DF for ; Fri, 3 Jul 2020 06:57:07 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=mykernel.net header.i=cgxu519@mykernel.net header.b="J48daN+E" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 6C258206DF Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=mykernel.net Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id EB9298D0055; Fri, 3 Jul 2020 02:57:05 -0400 (EDT) Delivered-To: linux-mm-outgoing@kvack.org Received: by kanga.kvack.org (Postfix, from userid 40) id E69C48D0010; Fri, 3 Jul 2020 02:57:05 -0400 (EDT) X-Original-To: int-list-linux-mm@kvack.org X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id D7F198D0055; Fri, 3 Jul 2020 02:57:05 -0400 (EDT) X-Original-To: linux-mm@kvack.org X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0063.hostedemail.com [216.40.44.63]) by kanga.kvack.org (Postfix) with ESMTP id C073F8D0010 for ; Fri, 3 Jul 2020 02:57:05 -0400 (EDT) Received: from smtpin04.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay03.hostedemail.com (Postfix) with ESMTP id 3E73C8248076 for ; Fri, 3 Jul 2020 06:57:05 +0000 (UTC) X-FDA: 76995857610.04.grape19_2101c5026e8f Received: from filter.hostedemail.com (10.5.16.251.rfc1918.com [10.5.16.251]) by smtpin04.hostedemail.com (Postfix) with ESMTP id 19B20801431C for ; Fri, 3 Jul 2020 06:57:05 +0000 (UTC) X-Spam-Summary: 1,0,0,fcfe035a426392ed,d41d8cd98f00b204,cgxu519@mykernel.net,,RULES_HIT:41:355:379:541:800:960:965:966:973:988:989:1260:1277:1311:1313:1314:1345:1437:1513:1515:1516:1518:1521:1534:1538:1567:1593:1594:1711:1714:1730:1747:1777:1792:2196:2199:2282:2393:2559:2562:3138:3139:3140:3141:3142:3871:3876:4321:4385:4390:4395:5007:6261:6653:10004:10400:11026:11473:11658:11914:12043:12297:12438:12555:12895:13069:13311:13357:14181:14394:14721:21080:21444:21451:21627:21990:30029:30054,0,RBL:163.53.93.243:@mykernel.net:.lbl8.mailshell.net-62.14.2.100 64.201.201.201;04ygxpgx6idc6158cdkgd3rjeee7aocnkgmm4snwzqgt8hdjqkbzc8mudw6mb6e.3r74ibh8kapfzj3ckxodg1bfhmbt966q7g1cwpi1shs1c9o46q4i1wkufuyynbi.o-lbl8.mailshell.net-223.238.255.100,CacheIP:none,Bayesian:0.5,0.5,0.5,Netcheck:none,DomainCache:0,MSF:not bulk,SPF:fp,MSBL:0,DNSBL:neutral,Custom_rules:0:0:0,LFtime:269,LUA_SUMMARY:none X-HE-Tag: grape19_2101c5026e8f X-Filterd-Recvd-Size: 2878 Received: from sender2-op-o12.zoho.com.cn (sender2-op-o12.zoho.com.cn [163.53.93.243]) by imf40.hostedemail.com (Postfix) with ESMTP for ; Fri, 3 Jul 2020 06:57:02 +0000 (UTC) ARC-Seal: i=1; a=rsa-sha256; t=1593759407; cv=none; d=zoho.com.cn; s=zohoarc; b=aCyBzceTKdYC40jVVf7gyrG63xFSpGBTdvGXEEC8ZyromhGpM8uP+EbkBxn9Wg9vtkF4uaCZ2IZRAYqedBmxKujJ2QWWMrhUlN5LuaeucZV+MkxpKcTN19wsan/r5P7MmcvVKMTzo0TtEWcKy9TQKX9vCzvWRe7ynJZZAVmDajU= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zoho.com.cn; s=zohoarc; t=1593759407; h=Content-Type:Content-Transfer-Encoding:Cc:Date:From:MIME-Version:Message-ID:Subject:To; bh=cH4mLua6jm4ER+PPs34LSiZHx6TWRd/2/7veqoKKPzM=; b=kbq4uB7h3cIZzyZ5H4Is74ztdcB/jYOeB2+7YL8a5eP+71WkZ5526Mxw9PvvwsjnExu7iCw/1IsRW814WMbSZGQ+RP/ViDF7h1olP4FFRswzuJX3XpH0kaUP1kkww7EzTNiNzLMFj/hLhLHQQzepyAwylIkHdRr9Lr+vljwbEmQ= ARC-Authentication-Results: i=1; mx.zoho.com.cn; dkim=pass header.i=mykernel.net; spf=pass smtp.mailfrom=cgxu519@mykernel.net; dmarc=pass header.from= header.from= DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; t=1593759407; s=zohomail; d=mykernel.net; i=cgxu519@mykernel.net; h=From:To:Cc:Message-ID:Subject:Date:MIME-Version:Content-Transfer-Encoding:Content-Type; bh=cH4mLua6jm4ER+PPs34LSiZHx6TWRd/2/7veqoKKPzM=; b=J48daN+ERYTTEVxiwY5xVYBKTAgqNp2Xiv/nZNvDeOq3Y0PT4NtUU0zSTjzJuX03 y8c6k+kkbKx2vERg50ClHzTybuivzTOYPT/i4ACdZLwwpHMIj9TtUoaEgKNZY2UnTUF IL/l5O40e2gGjFk8qWz7zUShR8vyz6fK0MEtwXkI= Received: from localhost.localdomain (113.116.49.35 [113.116.49.35]) by mx.zoho.com.cn with SMTPS id 1593759405937852.0358644034014; Fri, 3 Jul 2020 14:56:45 +0800 (CST) From: Chengguang Xu To: hughd@google.com, akpm@linux-foundation.org Cc: linux-mm@kvack.org, Chengguang Xu Message-ID: <20200703065636.20897-1-cgxu519@mykernel.net> Subject: [PATCH] mm/shmem: fix freeing new_attr in shmem_initxattrs() Date: Fri, 3 Jul 2020 14:56:36 +0800 X-Mailer: git-send-email 2.20.1 MIME-Version: 1.0 X-ZohoCNMailClient: External X-Rspamd-Queue-Id: 19B20801431C X-Spamd-Result: default: False [0.00 / 100.00] X-Rspamd-Server: rspam03 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: new_attr is allocated with kvmalloc() so should be freed with kvfree(). Signed-off-by: Chengguang Xu --- mm/shmem.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/mm/shmem.c b/mm/shmem.c index a0dbe62f8042..b2abca3f7f33 100644 --- a/mm/shmem.c +++ b/mm/shmem.c @@ -3178,7 +3178,7 @@ static int shmem_initxattrs(struct inode *inode, new_xattr->name = kmalloc(XATTR_SECURITY_PREFIX_LEN + len, GFP_KERNEL); if (!new_xattr->name) { - kfree(new_xattr); + kvfree(new_xattr); return -ENOMEM; }