From patchwork Fri Jul 10 19:40:42 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Uladzislau Rezki X-Patchwork-Id: 11657307 Return-Path: Received: from mail.kernel.org (pdx-korg-mail-1.web.codeaurora.org [172.30.200.123]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id A2B1513BD for ; Fri, 10 Jul 2020 19:40:58 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 5B3D2207BB for ; Fri, 10 Jul 2020 19:40:58 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="duIu7oJP" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 5B3D2207BB Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=gmail.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id 5B5676B0002; Fri, 10 Jul 2020 15:40:57 -0400 (EDT) Delivered-To: linux-mm-outgoing@kvack.org Received: by kanga.kvack.org (Postfix, from userid 40) id 53E636B0003; Fri, 10 Jul 2020 15:40:57 -0400 (EDT) X-Original-To: int-list-linux-mm@kvack.org X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 408008D0001; Fri, 10 Jul 2020 15:40:57 -0400 (EDT) X-Original-To: linux-mm@kvack.org X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0226.hostedemail.com [216.40.44.226]) by kanga.kvack.org (Postfix) with ESMTP id 2723B6B0002 for ; Fri, 10 Jul 2020 15:40:57 -0400 (EDT) Received: from smtpin08.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay02.hostedemail.com (Postfix) with ESMTP id B8A2E2DFA for ; Fri, 10 Jul 2020 19:40:56 +0000 (UTC) X-FDA: 77023184112.08.spade93_1e10be026ed1 Received: from filter.hostedemail.com (10.5.16.251.rfc1918.com [10.5.16.251]) by smtpin08.hostedemail.com (Postfix) with ESMTP id C3F861819E630 for ; Fri, 10 Jul 2020 19:40:54 +0000 (UTC) X-Spam-Summary: 1,0,0,3a944d377925578b,d41d8cd98f00b204,urezki@gmail.com,,RULES_HIT:41:355:379:541:800:960:966:973:988:989:1260:1311:1314:1345:1437:1515:1534:1541:1711:1730:1747:1777:1792:2196:2199:2393:2559:2562:2692:2892:2902:3138:3139:3140:3141:3142:3352:3866:3867:3868:3872:4385:5007:6261:6653:7514:9413:10004:11026:11658:11914:12043:12296:12297:12438:12517:12519:12555:12895:13069:13311:13357:13894:14181:14384:14394:14687:14721:21080:21212:21324:21444:21451:21627:21660:21666:21939:30054:30075,0,RBL:209.85.167.67:@gmail.com:.lbl8.mailshell.net-62.18.0.100 66.100.201.100;04yf8btzazsiac5qan98nwuugfs77opf6d1q8xsnptuou9aunekk4rs8rto95hk.ddeh7nah78ohtdiz1amxaa65zcp51f8hzd8arby1d5ut3jridw7wqm6q3dg1gz3.1-lbl8.mailshell.net-223.238.255.100,CacheIP:none,Bayesian:0.5,0.5,0.5,Netcheck:none,DomainCache:0,MSF:not bulk,SPF:fp,MSBL:0,DNSBL:neutral,Custom_rules:0:0:0,LFtime:23,LUA_SUMMARY:none X-HE-Tag: spade93_1e10be026ed1 X-Filterd-Recvd-Size: 4226 Received: from mail-lf1-f67.google.com (mail-lf1-f67.google.com [209.85.167.67]) by imf17.hostedemail.com (Postfix) with ESMTP for ; Fri, 10 Jul 2020 19:40:54 +0000 (UTC) Received: by mail-lf1-f67.google.com with SMTP id o4so3833684lfi.7 for ; Fri, 10 Jul 2020 12:40:54 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=8yy5+0XVtV1tT8exC81PHbEZ7mEejnNXr3qie/N1Tjs=; b=duIu7oJP7BVSgiZmVAwFlSpOU+5Njc4dEn6QeAcpR5nLoFt2SGRBT8lcNHz96DhV1E x4lqEKZiFIyMJ60dmF8Zlq2MQ3dehAMtOk0ObVJnzO7ZzADYbGo2qXHLiovUtBSpWqYY vPNi9VJQfMdfa9MbEU9MxDJd3kepGejHtC7byV9Iy+9KuaYWSP+J8Ed/BEOvygQpaH/A 22f/NvDDzFfyNpbsJDT3YamO331E/AoTixsw9jB4pucBt9TWaPIdDmM0JFA0zKEBl6y3 bsOmn5838sm+6YBy1k7ITnbquB0U98q5bBfOc6vOrsRvoZ4bsrszAgM6ZZtQf/d8uB00 SIrQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=8yy5+0XVtV1tT8exC81PHbEZ7mEejnNXr3qie/N1Tjs=; b=AHP7UULKh6U4jPbcCPCBl90iO8rd7fiPl/fPer2DZvKM0MqH5Wf/oWTBr4RiJAuZoc ggt6nTHOcSp8BgU42N/x+VFU+NFPMxoMIt+XmZaR8z9QRaYj79yKg0ZuTJC68/5Sz/aJ u0kbYU+ylIpSoNEvZfXkLjhhvN9YACUnUEUQv5kJh61VR07NYr/FqNcV5lTPP5Ut5nc6 Wp915jP1wZkC5eCSF6FA5BP04PasZM4F9/pJyiJspLDGFT3sfXr3Lm9dxsSZfDxV/JTg RQAdv2bil34m+NfyL5ebeHVtUGi7yCJRuMyUx+l6vcmNhX0c2fzyCMhiLNfjqeugNYz8 X+Jg== X-Gm-Message-State: AOAM531QlmIBUiEe+bSn3Xes94A7XvLh9mwy36oXb3SGGtzkpOm2I8RX HnvABbKGx2bkjLfRVEnvNcg= X-Google-Smtp-Source: ABdhPJxDxVgebeLIKDb7zktFvwhLgoVyHh7/MlegYPp69tFBWf9gJfREH2azgmANCbG9OMsN7ekEog== X-Received: by 2002:ac2:5325:: with SMTP id f5mr44162180lfh.6.1594410052841; Fri, 10 Jul 2020 12:40:52 -0700 (PDT) Received: from pc638.lan (h5ef52e31.seluork.dyn.perspektivbredband.net. [94.245.46.49]) by smtp.gmail.com with ESMTPSA id x17sm2496279lfe.44.2020.07.10.12.40.51 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 10 Jul 2020 12:40:52 -0700 (PDT) From: "Uladzislau Rezki (Sony)" To: Andrew Morton Cc: linux-mm@kvack.org, LKML , Uladzislau Rezki , Hillf Danton , Michal Hocko , Matthew Wilcox , Oleksiy Avramchenko , Steven Rostedt Subject: [PATCH 1/1] mm/vmalloc.c: Add an error message if two areas overlap Date: Fri, 10 Jul 2020 21:40:42 +0200 Message-Id: <20200710194042.2510-1-urezki@gmail.com> X-Mailer: git-send-email 2.20.1 MIME-Version: 1.0 X-Rspamd-Queue-Id: C3F861819E630 X-Spamd-Result: default: False [0.00 / 100.00] X-Rspamd-Server: rspam02 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: Before triggering a BUG() it would be useful to understand how two areas overlap between each other. Print information about start/end addresses of both VAs and their addresses. For example if both are identical it could mean double free. Signed-off-by: Uladzislau Rezki (Sony) --- mm/vmalloc.c | 10 +++++++++- 1 file changed, 9 insertions(+), 1 deletion(-) diff --git a/mm/vmalloc.c b/mm/vmalloc.c index 5a2b55c8dd9a..1679b01febcd 100644 --- a/mm/vmalloc.c +++ b/mm/vmalloc.c @@ -549,8 +549,13 @@ find_va_links(struct vmap_area *va, else if (va->va_end > tmp_va->va_start && va->va_start >= tmp_va->va_end) link = &(*link)->rb_right; - else + else { + pr_err("Overlaps: 0x%px(0x%lx-0x%lx), 0x%px(0x%lx-0x%lx)\n", + va, va->va_start, va->va_end, tmp_va, + tmp_va->va_start, tmp_va->va_end); + BUG(); + } } while (*link); *parent = &tmp_va->rb_node; @@ -1993,6 +1998,9 @@ static void vmap_init_free_space(void) insert_vmap_area_augment(free, NULL, &free_vmap_area_root, &free_vmap_area_list); + insert_vmap_area_augment(free, NULL, + &free_vmap_area_root, + &free_vmap_area_list); } } }