diff mbox series

[-next] mm/gup.c: Fix the comment of return value for populate_vma_page_range()

Message ID 20200720034303.29920-1-tangyizhou@huawei.com (mailing list archive)
State New, archived
Headers show
Series [-next] mm/gup.c: Fix the comment of return value for populate_vma_page_range() | expand

Commit Message

Tang Yizhou July 20, 2020, 3:43 a.m. UTC
The return value of populate_vma_page_range() is consistent with
__get_user_pages(), and so is the function comment of return value.

Signed-off-by: Tang Yizhou <tangyizhou@huawei.com>
---
 mm/gup.c | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

Comments

Ira Weiny July 21, 2020, 11:46 p.m. UTC | #1
On Mon, Jul 20, 2020 at 11:43:03AM +0800, Tang Yizhou wrote:
> The return value of populate_vma_page_range() is consistent with
> __get_user_pages(), and so is the function comment of return value.
> 
> Signed-off-by: Tang Yizhou <tangyizhou@huawei.com>

Reviewed-by: Ira Weiny <ira.weiny@intel.com>

> ---
>  mm/gup.c | 3 ++-
>  1 file changed, 2 insertions(+), 1 deletion(-)
> 
> diff --git a/mm/gup.c b/mm/gup.c
> index 2cc5eba44362..a55f1ec712e9 100644
> --- a/mm/gup.c
> +++ b/mm/gup.c
> @@ -1386,7 +1386,8 @@ static __always_inline long __get_user_pages_locked(struct mm_struct *mm,
>   *
>   * This takes care of mlocking the pages too if VM_LOCKED is set.
>   *
> - * return 0 on success, negative error code on error.
> + * Return either number of pages pinned in the vma, or a negative error
> + * code on error.
>   *
>   * vma->vm_mm->mmap_lock must be held.
>   *
> -- 
> 2.17.1
>
diff mbox series

Patch

diff --git a/mm/gup.c b/mm/gup.c
index 2cc5eba44362..a55f1ec712e9 100644
--- a/mm/gup.c
+++ b/mm/gup.c
@@ -1386,7 +1386,8 @@  static __always_inline long __get_user_pages_locked(struct mm_struct *mm,
  *
  * This takes care of mlocking the pages too if VM_LOCKED is set.
  *
- * return 0 on success, negative error code on error.
+ * Return either number of pages pinned in the vma, or a negative error
+ * code on error.
  *
  * vma->vm_mm->mmap_lock must be held.
  *