From patchwork Tue Jul 28 13:52:09 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Johannes Weiner X-Patchwork-Id: 11689207 Return-Path: Received: from mail.kernel.org (pdx-korg-mail-1.web.codeaurora.org [172.30.200.123]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id 6C1C31392 for ; Tue, 28 Jul 2020 13:53:15 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 385592074F for ; Tue, 28 Jul 2020 13:53:15 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (2048-bit key) header.d=cmpxchg-org.20150623.gappssmtp.com header.i=@cmpxchg-org.20150623.gappssmtp.com header.b="n1QWWvhg" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 385592074F Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=cmpxchg.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id 1D3256B005A; Tue, 28 Jul 2020 09:53:14 -0400 (EDT) Delivered-To: linux-mm-outgoing@kvack.org Received: by kanga.kvack.org (Postfix, from userid 40) id 15DCD6B005C; Tue, 28 Jul 2020 09:53:14 -0400 (EDT) X-Original-To: int-list-linux-mm@kvack.org X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 0231C8D0015; Tue, 28 Jul 2020 09:53:13 -0400 (EDT) X-Original-To: linux-mm@kvack.org X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0170.hostedemail.com [216.40.44.170]) by kanga.kvack.org (Postfix) with ESMTP id 9F1FA6B005A for ; Tue, 28 Jul 2020 09:53:13 -0400 (EDT) Received: from smtpin14.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay01.hostedemail.com (Postfix) with ESMTP id D1D2A180AD801 for ; Tue, 28 Jul 2020 13:53:12 +0000 (UTC) X-FDA: 77087626224.14.soup38_211523f26f6a Received: from filter.hostedemail.com (10.5.16.251.rfc1918.com [10.5.16.251]) by smtpin14.hostedemail.com (Postfix) with ESMTP id A20C01822987A for ; Tue, 28 Jul 2020 13:53:12 +0000 (UTC) X-Spam-Summary: 1,0,0,a7fe434a19e4f93d,d41d8cd98f00b204,hannes@cmpxchg.org,,RULES_HIT:41:355:379:541:800:960:968:973:988:989:1260:1311:1314:1345:1437:1515:1534:1541:1711:1730:1747:1777:1792:2393:2553:2559:2562:3138:3139:3140:3141:3142:3352:3865:3866:3867:3870:3872:4250:5007:6119:6261:6653:7903:8603:10004:11026:11658:11914:12043:12297:12438:12517:12519:12555:12679:12895:13069:13255:13311:13357:13894:14096:14130:14181:14384:14394:14721:21080:21444:21451:21627:21990:30012:30054:30069:30090,0,RBL:209.85.222.195:@cmpxchg.org:.lbl8.mailshell.net-66.201.201.201 62.14.0.100;04yfejnwq9aue3rjw7zd17p4jzqexocnha8pfdsmg8ejde4krcymufkniqpsz7p.df4on6yorhbr1yy8uqnchwzxx9endsi81ubj43ipjiursepx68ok1dwzsgnxoxg.4-lbl8.mailshell.net-223.238.255.100,CacheIP:none,Bayesian:0.5,0.5,0.5,Netcheck:none,DomainCache:0,MSF:not bulk,SPF:fp,MSBL:0,DNSBL:neutral,Custom_rules:0:0:0,LFtime:28,LUA_SUMMARY:none X-HE-Tag: soup38_211523f26f6a X-Filterd-Recvd-Size: 3907 Received: from mail-qk1-f195.google.com (mail-qk1-f195.google.com [209.85.222.195]) by imf35.hostedemail.com (Postfix) with ESMTP for ; Tue, 28 Jul 2020 13:53:11 +0000 (UTC) Received: by mail-qk1-f195.google.com with SMTP id b79so18635759qkg.9 for ; Tue, 28 Jul 2020 06:53:11 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=cmpxchg-org.20150623.gappssmtp.com; s=20150623; h=from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=EtW0ADoRwQtOsaGG7oJlooe3S87y53RN1USDHS3OX1k=; b=n1QWWvhgXYfYFQhyOqcZpff1NCZlRpZRU+M57YX8VkjXTtd3GqfnDkYU0Ml146ZUTZ EMUF3jGXqq0ZC+jlxfvAVMjoHJNWyaygZPYp4hXRevNGlGHVvpyCD8PlVbquWCb5nH4w UzI+8KI2BOpWhsINM70UMwN4agULCxVCtHtZj8ZAUgZk2Mz6MbJ3wids2nV60eUD5OT2 G5sgsBxiIAMoMM42EOEJipYA/duIJUeWlfrsrEeW+/D40GXy1ycVavy2AIRGeLsLtIh6 AUs2Y7iVWX1FTqBsZUxSi2UE2j1cv4OU9emJT+b4CA49q6ooCVZ3b/20TcvF6D0xPnw0 Q+mw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=EtW0ADoRwQtOsaGG7oJlooe3S87y53RN1USDHS3OX1k=; b=HmRBqHuZkqMwk1amXtq7rUcbT5MCW4MTkZvCE3ZFuA1dXJOWD5/mFctZe6rFfwZfsq wXIbQsUtYs/GwkqTRlOykiaupW3lGMoRDSvmEsexBdxQbKzMZRq1y6NWKRV9DVInIeel uaUpjYI0P9sQNlEtbCui6k/27AcBeSBW+6MxzkxyFg8G1/epJiABUnDjmNRpceb2iEJc OFlJrBZw+wfR9dsm7rhGaLgBUPPSP7VN+gq4tQhVsXHf9A/Rhb5qrfbJEjcUOXWKB8Xs HciAQ1M4WzNjm3NwQNrfGuAqTMK7/JMKq+bwW7sIWA8TucOYcM1wqppphTvbhelnCU40 L5Kw== X-Gm-Message-State: AOAM530svFT9546bkk4pj7zPJykD6xAP6ojsyFL1hQdJR1SKKGs6S44X WoXzzn6m+hh/Ivm35BBAHohe3g== X-Google-Smtp-Source: ABdhPJxZsi0XICMqQarFdnuS1OZe7mHQHY0H8FNy5g+HSZY1D4xOeR6LwKFX9mCFezvWZybWBLoj9w== X-Received: by 2002:a05:620a:132d:: with SMTP id p13mr8925316qkj.161.1595944391174; Tue, 28 Jul 2020 06:53:11 -0700 (PDT) Received: from localhost ([2620:10d:c091:480::1:53c1]) by smtp.gmail.com with ESMTPSA id g24sm19970608qta.27.2020.07.28.06.53.10 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 28 Jul 2020 06:53:10 -0700 (PDT) From: Johannes Weiner To: Andrew Morton Cc: Michal Hocko , Roman Gushchin , linux-mm@kvack.org, cgroups@vger.kernel.org, linux-kernel@vger.kernel.org, kernel-team@fb.com Subject: [PATCH] mm: memcontrol: restore proper dirty throttling when memory.high changes Date: Tue, 28 Jul 2020 09:52:09 -0400 Message-Id: <20200728135210.379885-1-hannes@cmpxchg.org> X-Mailer: git-send-email 2.27.0 MIME-Version: 1.0 X-Rspamd-Queue-Id: A20C01822987A X-Spamd-Result: default: False [0.00 / 100.00] X-Rspamd-Server: rspam05 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: Commit 8c8c383c04f6 ("mm: memcontrol: try harder to set a new memory.high") inadvertently removed a callback to recalculate the writeback cache size in light of a newly configured memory.high limit. Without letting the writeback cache know about a potentially heavily reduced limit, it may permit too many dirty pages, which can cause unnecessary reclaim latencies or even avoidable OOM situations. This was spotted while reading the code, it hasn't knowingly caused any problems in practice so far. Fixes: 8c8c383c04f6 ("mm: memcontrol: try harder to set a new memory.high") Signed-off-by: Johannes Weiner Acked-by: Chris Down Reviewed-by: Shakeel Butt Acked-by: Michal Hocko --- mm/memcontrol.c | 1 + 1 file changed, 1 insertion(+) diff --git a/mm/memcontrol.c b/mm/memcontrol.c index 13f559af1ab6..805a44bf948c 100644 --- a/mm/memcontrol.c +++ b/mm/memcontrol.c @@ -6071,6 +6071,7 @@ static ssize_t memory_high_write(struct kernfs_open_file *of, break; } + memcg_wb_domain_size_changed(memcg); return nbytes; }