From patchwork Fri Jul 31 02:39:39 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: "Zhang, Qiang" X-Patchwork-Id: 11693889 Return-Path: Received: from mail.kernel.org (pdx-korg-mail-1.web.codeaurora.org [172.30.200.123]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id E0CCE13B6 for ; Fri, 31 Jul 2020 02:28:26 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id BBF20207F5 for ; Fri, 31 Jul 2020 02:28:26 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org BBF20207F5 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=windriver.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id BC0E58D000C; Thu, 30 Jul 2020 22:28:25 -0400 (EDT) Delivered-To: linux-mm-outgoing@kvack.org Received: by kanga.kvack.org (Postfix, from userid 40) id B718F8D000B; Thu, 30 Jul 2020 22:28:25 -0400 (EDT) X-Original-To: int-list-linux-mm@kvack.org X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id A88278D000C; Thu, 30 Jul 2020 22:28:25 -0400 (EDT) X-Original-To: linux-mm@kvack.org X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0237.hostedemail.com [216.40.44.237]) by kanga.kvack.org (Postfix) with ESMTP id 9308C8D000B for ; Thu, 30 Jul 2020 22:28:25 -0400 (EDT) Received: from smtpin08.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay02.hostedemail.com (Postfix) with ESMTP id 232E73627 for ; Fri, 31 Jul 2020 02:28:25 +0000 (UTC) X-FDA: 77096786970.08.iron25_031460b26f80 Received: from filter.hostedemail.com (10.5.16.251.rfc1918.com [10.5.16.251]) by smtpin08.hostedemail.com (Postfix) with ESMTP id EDDAE1819E769 for ; Fri, 31 Jul 2020 02:28:24 +0000 (UTC) X-Spam-Summary: 1,0,0,,d41d8cd98f00b204,qiang.zhang@windriver.com,,RULES_HIT:30054,0,RBL:147.11.146.13:@windriver.com:.lbl8.mailshell.net-62.18.0.100 64.10.201.10;04yrq43zroh1wf394n55c8ey4dsstypjt8fjukteu5ay6z9riurkxttfiaqnb3f.sq1d1xhrcw6x8nafp98xxhqwthbp7euzch1stf97dk4tuzqm1tekhd1k14bgw1b.g-lbl8.mailshell.net-223.238.255.100,CacheIP:none,Bayesian:0.5,0.5,0.5,Netcheck:none,DomainCache:0,MSF:not bulk,SPF:fp,MSBL:0,DNSBL:neutral,Custom_rules:0:0:0,LFtime:25,LUA_SUMMARY:none X-HE-Tag: iron25_031460b26f80 X-Filterd-Recvd-Size: 1907 Received: from mail1.windriver.com (mail1.windriver.com [147.11.146.13]) by imf16.hostedemail.com (Postfix) with ESMTP for ; Fri, 31 Jul 2020 02:28:23 +0000 (UTC) Received: from ALA-HCB.corp.ad.wrs.com (ala-hcb.corp.ad.wrs.com [147.11.189.41]) by mail1.windriver.com (8.15.2/8.15.2) with ESMTPS id 06V2SBVI005111 (version=TLSv1 cipher=DHE-RSA-AES256-SHA bits=256 verify=FAIL); Thu, 30 Jul 2020 19:28:12 -0700 (PDT) Received: from pek-lpg-core1-vm1.wrs.com (128.224.156.106) by ALA-HCB.corp.ad.wrs.com (147.11.189.41) with Microsoft SMTP Server id 14.3.487.0; Thu, 30 Jul 2020 19:27:52 -0700 From: To: , CC: , Subject: [PATCH] mm/dmapool.c: add WARN_ON() in dma_pool_destroy Date: Fri, 31 Jul 2020 10:39:39 +0800 Message-ID: <20200731023939.19206-1-qiang.zhang@windriver.com> X-Mailer: git-send-email 2.26.2 MIME-Version: 1.0 X-Rspamd-Queue-Id: EDDAE1819E769 X-Spamd-Result: default: False [0.00 / 100.00] X-Rspamd-Server: rspam01 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: From: Zhang Qiang The pool is being destroyed, all page which in the pool, should be free. if some page is still be use by somebody, we should not just output error logs, also should also add a warning message. Signed-off-by: Zhang Qiang --- mm/dmapool.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/mm/dmapool.c b/mm/dmapool.c index f9fb9bbd733e..8f4dc53dde5b 100644 --- a/mm/dmapool.c +++ b/mm/dmapool.c @@ -285,7 +285,7 @@ void dma_pool_destroy(struct dma_pool *pool) struct dma_page *page; page = list_entry(pool->page_list.next, struct dma_page, page_list); - if (is_page_busy(page)) { + if (WARN_ON(is_page_busy(page))) { if (pool->dev) dev_err(pool->dev, "dma_pool_destroy %s, %p busy\n",