From patchwork Fri Aug 7 06:19:09 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Andrew Morton X-Patchwork-Id: 11704753 Return-Path: Received: from mail.kernel.org (pdx-korg-mail-1.web.codeaurora.org [172.30.200.123]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id CFF2B14B7 for ; Fri, 7 Aug 2020 06:19:13 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id A12502177B for ; Fri, 7 Aug 2020 06:19:13 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=kernel.org header.i=@kernel.org header.b="k8WeoTUV" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org A12502177B Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=linux-foundation.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id 4217C8D0027; Fri, 7 Aug 2020 02:19:12 -0400 (EDT) Delivered-To: linux-mm-outgoing@kvack.org Received: by kanga.kvack.org (Postfix, from userid 40) id 3F82F8D0026; Fri, 7 Aug 2020 02:19:12 -0400 (EDT) X-Original-To: int-list-linux-mm@kvack.org X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 30F068D0027; Fri, 7 Aug 2020 02:19:12 -0400 (EDT) X-Original-To: linux-mm@kvack.org X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0189.hostedemail.com [216.40.44.189]) by kanga.kvack.org (Postfix) with ESMTP id 14CD08D0026 for ; Fri, 7 Aug 2020 02:19:12 -0400 (EDT) Received: from smtpin17.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay03.hostedemail.com (Postfix) with ESMTP id CECD582499A8 for ; Fri, 7 Aug 2020 06:19:11 +0000 (UTC) X-FDA: 77122770102.17.loss59_4c0f8b826fbe Received: from filter.hostedemail.com (10.5.16.251.rfc1918.com [10.5.16.251]) by smtpin17.hostedemail.com (Postfix) with ESMTP id 8429F180D0181 for ; Fri, 7 Aug 2020 06:19:11 +0000 (UTC) X-Spam-Summary: 1,0,0,66e6438602e2ad97,d41d8cd98f00b204,akpm@linux-foundation.org,,RULES_HIT:41:355:379:800:960:967:968:973:988:989:1260:1263:1345:1359:1381:1431:1437:1534:1541:1711:1730:1747:1777:1792:2198:2199:2393:2525:2559:2563:2682:2685:2693:2859:2902:2933:2937:2939:2942:2945:2947:2951:2954:3022:3138:3139:3140:3141:3142:3352:3867:3868:3870:3871:3872:3874:3934:3936:3938:3941:3944:3947:3950:3953:3956:3959:4321:4419:5007:6261:6653:6737:7576:8599:9025:9545:9592:10004:10913:11026:11473:11658:11914:12043:12048:12114:12297:12517:12519:12555:12679:12783:12986:13069:13161:13229:13311:13357:13846:14181:14384:14721:14849:21080:21451:21627:21740:21939:21987:30054:30070,0,RBL:198.145.29.99:@linux-foundation.org:.lbl8.mailshell.net-62.2.0.100 64.100.201.201;04y8h9igitpt7fhjg6ahfyrwmq9pwoprbjejckrq9tyoi4haq41ouq89s9mjtgk.3fprfryhznzj97isgjyt4ssec514bbxiasngroq66wnb5htoppg9effounqqrdh.h-lbl8.mailshell.net-223.238.255.100,CacheIP:none,Bayesian:0.5,0.5,0.5,Netcheck:none,DomainCache:0,MSF: not bulk X-HE-Tag: loss59_4c0f8b826fbe X-Filterd-Recvd-Size: 2668 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by imf16.hostedemail.com (Postfix) with ESMTP for ; Fri, 7 Aug 2020 06:19:11 +0000 (UTC) Received: from localhost.localdomain (c-73-231-172-41.hsd1.ca.comcast.net [73.231.172.41]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id E26932177B; Fri, 7 Aug 2020 06:19:09 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1596781150; bh=t5PucQZuKToNKwVENT0iXxoiOqnhQXXF6xvuCDnnKj4=; h=Date:From:To:Subject:In-Reply-To:From; b=k8WeoTUVc4zSsbLPRavwgmy7nAG3F0u2TnPjKmiphcQazY5jfvPQtArkezWLsR09U wQ1ITzXzSDOyNwp2XUYGukaGVs2nAA22Sk9JP78K4B6LiUYAplDA15cCGmT86gi4A+ 7fN6M3xsuHL5iPyskU7dsM0Kdn03SpG+lCcpn8EU= Date: Thu, 06 Aug 2020 23:19:09 -0700 From: Andrew Morton To: akpm@linux-foundation.org, bigeasy@linutronix.de, cl@linux.com, iamjoonsoo.kim@lge.com, linux-mm@kvack.org, mm-commits@vger.kernel.org, penberg@kernel.org, rientjes@google.com, tglx@linutronix.de, torvalds@linux-foundation.org, yuzhao@google.com Subject: [patch 038/163] mm/slub.c: drop lockdep_assert_held() from put_map() Message-ID: <20200807061909.ouNDTlYfw%akpm@linux-foundation.org> In-Reply-To: <20200806231643.a2711a608dd0f18bff2caf2b@linux-foundation.org> User-Agent: s-nail v14.8.16 X-Rspamd-Queue-Id: 8429F180D0181 X-Spamd-Result: default: False [0.00 / 100.00] X-Rspamd-Server: rspam01 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: From: Sebastian Andrzej Siewior Subject: mm/slub.c: drop lockdep_assert_held() from put_map() There is no point in using lockdep_assert_held() unlock that is about to be unlocked. It works only with lockdep and lockdep will complain if spin_unlock() is used on a lock that has not been locked. Remove superfluous lockdep_assert_held(). Link: http://lkml.kernel.org/r/20200618201234.795692-2-bigeasy@linutronix.de Signed-off-by: Sebastian Andrzej Siewior Cc: Yu Zhao Cc: Christopher Lameter Cc: Pekka Enberg Cc: David Rientjes Cc: Joonsoo Kim Cc: Thomas Gleixner Signed-off-by: Andrew Morton --- mm/slub.c | 2 -- 1 file changed, 2 deletions(-) --- a/mm/slub.c~slub-drop-lockdep_assert_held-from-put_map +++ a/mm/slub.c @@ -473,8 +473,6 @@ static unsigned long *get_map(struct kme static void put_map(unsigned long *map) __releases(&object_map_lock) { VM_BUG_ON(map != object_map); - lockdep_assert_held(&object_map_lock); - spin_unlock(&object_map_lock); }