From patchwork Tue Aug 25 11:13:03 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Mike Rapoport X-Patchwork-Id: 11735537 Return-Path: Received: from mail.kernel.org (pdx-korg-mail-1.web.codeaurora.org [172.30.200.123]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id B7B94913 for ; Tue, 25 Aug 2020 11:13:27 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 6DB772075B for ; Tue, 25 Aug 2020 11:13:27 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=ibm.com header.i=@ibm.com header.b="BW+nd92d" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 6DB772075B Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=linux.ibm.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id 930316B009C; Tue, 25 Aug 2020 07:13:26 -0400 (EDT) Delivered-To: linux-mm-outgoing@kvack.org Received: by kanga.kvack.org (Postfix, from userid 40) id 905116B009D; Tue, 25 Aug 2020 07:13:26 -0400 (EDT) X-Original-To: int-list-linux-mm@kvack.org X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 81D0D8E000D; Tue, 25 Aug 2020 07:13:26 -0400 (EDT) X-Original-To: linux-mm@kvack.org X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0039.hostedemail.com [216.40.44.39]) by kanga.kvack.org (Postfix) with ESMTP id 6C0BD6B009C for ; Tue, 25 Aug 2020 07:13:26 -0400 (EDT) Received: from smtpin24.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay03.hostedemail.com (Postfix) with ESMTP id 32DE98248047 for ; Tue, 25 Aug 2020 11:13:26 +0000 (UTC) X-FDA: 77188830012.24.start67_15169942705b Received: from filter.hostedemail.com (10.5.16.251.rfc1918.com [10.5.16.251]) by smtpin24.hostedemail.com (Postfix) with ESMTP id 08AD61A4A0 for ; Tue, 25 Aug 2020 11:13:26 +0000 (UTC) X-Spam-Summary: 1,0,0,71f4030c0837e8bd,d41d8cd98f00b204,rppt@linux.ibm.com,,RULES_HIT:41:355:379:800:960:965:966:968:973:988:989:1260:1261:1277:1312:1313:1314:1345:1359:1431:1437:1516:1518:1519:1535:1542:1593:1594:1595:1596:1711:1730:1747:1777:1792:2196:2199:2393:2553:2559:2562:2890:3138:3139:3140:3141:3142:3354:3622:3865:3866:3867:3868:3870:3871:3872:3873:3874:4042:4118:4250:4321:4385:4390:4395:5007:6119:6261:6653:6742:7576:8660:8957:9545:10004:10400:10471:10967:11026:11232:11473:11657:11658:11914:12043:12262:12296:12297:12438:12517:12519:12555:12679:12740:12895:12986:13148:13221:13229:13230:13255:13439:13895:14093:14096:14097:14181:14394:14721:21080:21212:21365:21450:21451:21627:21939:30001:30045:30054:30060:30070:30090:30091,0,RBL:148.163.158.5:@linux.ibm.com:.lbl8.mailshell.net-64.100.201.201 62.2.0.100;04y86o45wwshj8fbgynrpqtxsnuikypqirmjsnytpm5krfebh8jtf4nurcuufe8.cos6a6dmrodjody63fcpz1zasjbwq3xe43rksca4hj5ptx8w6kj6nzzbykshaoo.6-lbl8.mailshell.net-223.238.255.100,CacheI P:none,B X-HE-Tag: start67_15169942705b X-Filterd-Recvd-Size: 7350 Received: from mx0a-001b2d01.pphosted.com (mx0b-001b2d01.pphosted.com [148.163.158.5]) by imf25.hostedemail.com (Postfix) with ESMTP for ; Tue, 25 Aug 2020 11:13:25 +0000 (UTC) Received: from pps.filterd (m0098420.ppops.net [127.0.0.1]) by mx0b-001b2d01.pphosted.com (8.16.0.42/8.16.0.42) with SMTP id 07PB3t0f068199; Tue, 25 Aug 2020 07:13:12 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ibm.com; h=date : from : to : cc : subject : message-id : references : mime-version : content-type : in-reply-to; s=pp1; bh=NCSDhqHannG42tt3LoU0vm6cDgbpbWzA2ffRChqRUg4=; b=BW+nd92dnKCyZloBrICqlkJTdmuycQOr7iExT3merVZMCYJM0XCTmCtIzuhOuX6PRfzW 2DTftP8QqK8nX0FosShB4ISQe9QIVTVY55S5g2LnbBq0ZsKTwBoM4/hfVYhEJxEbDxY0 7dOAVt4I4eiVMxZWG1Zaw3qzx1KMifRUvoraJIK26cumeAySATSCHhdpAOthRiOZ+wDc s2ZnAiU1B27REZfW2qkiSpHtXsdQIS9LIq1NZrjh3VYrmtNmKnmkw1EXG5F1B3f+TAlY frI+t60DqFmEWiqcOlBLcdBTNmKVQaJkhaehoKCfDv/EoUVOGHtNJjfChyBwFaWQv9VA Zg== Received: from pps.reinject (localhost [127.0.0.1]) by mx0b-001b2d01.pphosted.com with ESMTP id 33515vrp39-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Tue, 25 Aug 2020 07:13:11 -0400 Received: from m0098420.ppops.net (m0098420.ppops.net [127.0.0.1]) by pps.reinject (8.16.0.36/8.16.0.36) with SMTP id 07PB4VL5070334; Tue, 25 Aug 2020 07:13:11 -0400 Received: from ppma03fra.de.ibm.com (6b.4a.5195.ip4.static.sl-reverse.com [149.81.74.107]) by mx0b-001b2d01.pphosted.com with ESMTP id 33515vrp2k-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Tue, 25 Aug 2020 07:13:11 -0400 Received: from pps.filterd (ppma03fra.de.ibm.com [127.0.0.1]) by ppma03fra.de.ibm.com (8.16.0.42/8.16.0.42) with SMTP id 07PBD9Qk000946; Tue, 25 Aug 2020 11:13:09 GMT Received: from b06cxnps3074.portsmouth.uk.ibm.com (d06relay09.portsmouth.uk.ibm.com [9.149.109.194]) by ppma03fra.de.ibm.com with ESMTP id 332utq21hu-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Tue, 25 Aug 2020 11:13:09 +0000 Received: from d06av22.portsmouth.uk.ibm.com (d06av22.portsmouth.uk.ibm.com [9.149.105.58]) by b06cxnps3074.portsmouth.uk.ibm.com (8.14.9/8.14.9/NCO v10.0) with ESMTP id 07PBD7Eh31326598 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Tue, 25 Aug 2020 11:13:07 GMT Received: from d06av22.portsmouth.uk.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id 0B6844C059; Tue, 25 Aug 2020 11:13:07 +0000 (GMT) Received: from d06av22.portsmouth.uk.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id 0EBB74C040; Tue, 25 Aug 2020 11:13:05 +0000 (GMT) Received: from linux.ibm.com (unknown [9.145.152.21]) by d06av22.portsmouth.uk.ibm.com (Postfix) with ESMTPS; Tue, 25 Aug 2020 11:13:04 +0000 (GMT) Date: Tue, 25 Aug 2020 14:13:03 +0300 From: Mike Rapoport To: Anders Roxell , Andrew Morton Cc: Naresh Kamboju , Matthew Wilcox , linux-mm , Linux-Next Mailing List , open list , lkft-triage@lists.linaro.org, LTP List , Arnd Bergmann , Russell King - ARM Linux , Stephen Rothwell , Catalin Marinas , Christoph Hellwig , Andy Lutomirski , Peter Xu , opendmb@gmail.com, Linus Walleij , afzal.mohd.ma@gmail.com, Will Deacon , Greg Kroah-Hartman Subject: [PATCH] arm: __pmd_free_tlb(): call page table desctructor (Was: BUG: Bad page state in process true pfn:a8fed on arm) Message-ID: <20200825111303.GB69694@linux.ibm.com> References: <20200824110645.GC17456@casper.infradead.org> <20200825083119.GA69694@linux.ibm.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: X-TM-AS-GCONF: 00 X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10434:6.0.235,18.0.687 definitions=2020-08-25_02:2020-08-25,2020-08-25 signatures=0 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 phishscore=0 suspectscore=5 spamscore=0 mlxscore=0 adultscore=0 mlxlogscore=999 impostorscore=0 clxscore=1011 priorityscore=1501 bulkscore=0 malwarescore=0 lowpriorityscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2006250000 definitions=main-2008250079 X-Rspamd-Queue-Id: 08AD61A4A0 X-Spamd-Result: default: False [0.00 / 100.00] X-Rspamd-Server: rspam04 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Tue, Aug 25, 2020 at 10:53:22AM +0200, Anders Roxell wrote: > On Tue, 25 Aug 2020 at 10:32, Mike Rapoport wrote: > > > > On Tue, Aug 25, 2020 at 01:03:53PM +0530, Naresh Kamboju wrote: > > > On Mon, 24 Aug 2020 at 16:36, Matthew Wilcox wrote: > > > > > > > > On Mon, Aug 24, 2020 at 03:14:55PM +0530, Naresh Kamboju wrote: > > > > > [ 67.545247] BUG: Bad page state in process true pfn:a8fed > > > > > [ 67.550767] page:9640c0ab refcount:0 mapcount:-1024 > > > > > > > > Somebody freed a page table without calling __ClearPageTable() on it. > > > > > > After running git bisect on this problem, > > > The first suspecting of this problem on arm architecture this patch. > > > 424efe723f7717430bec7c93b4d28bba73e31cf6 > > > ("mm: account PMD tables like PTE tables ") > > > > > > Reported-by: Naresh Kamboju > > > Reported-by: Anders Roxell > > > > Can you please check if this fix helps? > > That fixed the problem. Since this is still in -mm tree, I've omitted commit sha and Fixes. Andrew, is it possible to add this as a fixup to for the original commit? From db2efd7b89b1d943eb250e7e195c8cbaaa2e6ac9 Mon Sep 17 00:00:00 2001 From: Mike Rapoport Date: Tue, 25 Aug 2020 13:57:12 +0300 Subject: [PATCH] arm: __pmd_free_tlb(): call page table desctructor As long as PMD tables are accounted as PTE tables ("mm: account PMD tables like PTE tables") they can be freed only after pgtable_pmd_page_dtor() is called. Add the missing call in ARM's version of __pmd_free_tlb for CONFIG_ARM_LPAE=y case. Reported-by: Naresh Kamboju Reported-by: Anders Roxell Signed-off-by: Mike Rapoport --- arch/arm/include/asm/tlb.h | 1 + 1 file changed, 1 insertion(+) diff --git a/arch/arm/include/asm/tlb.h b/arch/arm/include/asm/tlb.h index 9415222b49ad..b8cbe03ad260 100644 --- a/arch/arm/include/asm/tlb.h +++ b/arch/arm/include/asm/tlb.h @@ -59,6 +59,7 @@ __pmd_free_tlb(struct mmu_gather *tlb, pmd_t *pmdp, unsigned long addr) #ifdef CONFIG_ARM_LPAE struct page *page = virt_to_page(pmdp); + pgtable_pmd_page_dtor(page); tlb_remove_table(tlb, page); #endif }