Message ID | 20200904233524.TtCdVpI8y%akpm@linux-foundation.org (mailing list archive) |
---|---|
State | New, archived |
Headers | show
Return-Path: <SRS0=0xW6=CN=kvack.org=owner-linux-mm@kernel.org> Received: from mail.kernel.org (pdx-korg-mail-1.web.codeaurora.org [172.30.200.123]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id 78BEA13B1 for <patchwork-linux-mm@patchwork.kernel.org>; Fri, 4 Sep 2020 23:35:28 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 195812098B for <patchwork-linux-mm@patchwork.kernel.org>; Fri, 4 Sep 2020 23:35:28 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=kernel.org header.i=@kernel.org header.b="IJfdnRJG" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 195812098B Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=linux-foundation.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id 56EA66B0055; Fri, 4 Sep 2020 19:35:27 -0400 (EDT) Delivered-To: linux-mm-outgoing@kvack.org Received: by kanga.kvack.org (Postfix, from userid 40) id 5473B6B005A; Fri, 4 Sep 2020 19:35:27 -0400 (EDT) X-Original-To: int-list-linux-mm@kvack.org X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 4834F6B005C; Fri, 4 Sep 2020 19:35:27 -0400 (EDT) X-Original-To: linux-mm@kvack.org X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0089.hostedemail.com [216.40.44.89]) by kanga.kvack.org (Postfix) with ESMTP id 3225A6B0055 for <linux-mm@kvack.org>; Fri, 4 Sep 2020 19:35:27 -0400 (EDT) Received: from smtpin26.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay02.hostedemail.com (Postfix) with ESMTP id C93A6362E for <linux-mm@kvack.org>; Fri, 4 Sep 2020 23:35:26 +0000 (UTC) X-FDA: 77226987852.26.bomb82_2b1217d270b6 Received: from filter.hostedemail.com (10.5.16.251.rfc1918.com [10.5.16.251]) by smtpin26.hostedemail.com (Postfix) with ESMTP id 906601804A300 for <linux-mm@kvack.org>; Fri, 4 Sep 2020 23:35:26 +0000 (UTC) X-Spam-Summary: 1,0,0,10666873f73d009c,d41d8cd98f00b204,akpm@linux-foundation.org,,RULES_HIT:41:355:379:800:960:965:966:967:968:973:982:988:989:1260:1345:1359:1381:1431:1437:1535:1544:1711:1730:1747:1777:1792:1981:2194:2196:2198:2199:2200:2201:2393:2525:2559:2563:2682:2685:2693:2859:2901:2902:2933:2937:2939:2942:2945:2947:2951:2954:3022:3138:3139:3140:3141:3142:3354:3865:3866:3867:3868:3870:3871:3872:3874:3934:3936:3938:3941:3944:3947:3950:3953:3956:3959:4041:4117:4250:4321:4385:4390:4395:5007:6261:6653:7576:7903:8603:8660:9025:9163:9545:10004:10128:11026:11473:11658:11914:12043:12048:12296:12297:12438:12517:12519:12555:12679:12740:12895:12986:13148:13221:13227:13229:13230:14093:14181:14721:21080:21450:21451:21627:21740:21939:21987:30029:30054:30056:30064,0,RBL:198.145.29.99:@linux-foundation.org:.lbl8.mailshell.net-62.2.0.100 64.100.201.201;04yfhqmt5z6npwawdpyio8nijqfb9ycu44u7mpgif6wufai9frxs5awhba4zxx7.f3dqi4jm67nka6ndchsttmu5ki9wp53e9nfrcwmtya6hx78puo46bf1x9c7umfh.a-lbl8.m ailshell X-HE-Tag: bomb82_2b1217d270b6 X-Filterd-Recvd-Size: 6106 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by imf35.hostedemail.com (Postfix) with ESMTP for <linux-mm@kvack.org>; Fri, 4 Sep 2020 23:35:25 +0000 (UTC) Received: from localhost.localdomain (c-71-198-47-131.hsd1.ca.comcast.net [71.198.47.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id C07372078E; Fri, 4 Sep 2020 23:35:24 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1599262525; bh=5J24vZgmX2Qucvi66AsKFDhnN3yV2/8YWbJqP+vWcDM=; h=Date:From:To:Subject:In-Reply-To:From; b=IJfdnRJGJh9wULiiE8I0K5NLEk4DZ1Vk4QOoDeWvDR4/zxWCten0jJM5NMizqBc9z XvswGCOl+l1JZN4o/AnPw1zOGDYqfU73th6Xt0iC8st38gN5NYw+q5OlE5qBl1ytUz zangQ9HMELFtLm+DvZEZOBE2s5eabgxTADKHSSlE= Date: Fri, 04 Sep 2020 16:35:24 -0700 From: Andrew Morton <akpm@linux-foundation.org> To: akpm@linux-foundation.org, guro@fb.com, hannes@cmpxchg.org, hughd@google.com, linux-mm@kvack.org, mhocko@suse.com, mm-commits@vger.kernel.org, shakeelb@google.com, torvalds@linux-foundation.org Subject: [patch 01/19] memcg: fix use-after-free in uncharge_batch Message-ID: <20200904233524.TtCdVpI8y%akpm@linux-foundation.org> In-Reply-To: <20200904163454.4db0e6ce0c4584d2653678a3@linux-foundation.org> User-Agent: s-nail v14.8.16 X-Rspamd-Queue-Id: 906601804A300 X-Spamd-Result: default: False [0.00 / 100.00] X-Rspamd-Server: rspam02 X-Bogosity: Ham, tests=bogofilter, spamicity=0.193452, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: <linux-mm.kvack.org> |
Series |
[01/19] memcg: fix use-after-free in uncharge_batch
|
expand
|
--- a/mm/memcontrol.c~memcg-fix-use-after-free-in-uncharge_batch +++ a/mm/memcontrol.c @@ -6774,6 +6774,9 @@ static void uncharge_batch(const struct __this_cpu_add(ug->memcg->vmstats_percpu->nr_page_events, ug->nr_pages); memcg_check_events(ug->memcg, ug->dummy_page); local_irq_restore(flags); + + /* drop reference from uncharge_page */ + css_put(&ug->memcg->css); } static void uncharge_page(struct page *page, struct uncharge_gather *ug) @@ -6797,6 +6800,9 @@ static void uncharge_page(struct page *p uncharge_gather_clear(ug); } ug->memcg = page->mem_cgroup; + + /* pairs with css_put in uncharge_batch */ + css_get(&ug->memcg->css); } nr_pages = compound_nr(page);