diff mbox series

[1/2] mm/mmap: not necessary to check mapping separately

Message ID 20200913133631.37781-1-richard.weiyang@linux.alibaba.com (mailing list archive)
State New, archived
Headers show
Series [1/2] mm/mmap: not necessary to check mapping separately | expand

Commit Message

Wei Yang Sept. 13, 2020, 1:36 p.m. UTC
*root* with type of struct rb_root_cached is an element of *mapping*
with type of struct address_space. This implies when we have a valid
*root* it must be a part of valid *mapping*.

So we can merge these two checks together to make the code more easy to
read and to save some cpu cycles.

Signed-off-by: Wei Yang <richard.weiyang@linux.alibaba.com>
 mm/mmap.c | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)
diff mbox series


diff --git a/mm/mmap.c b/mm/mmap.c
index 1922e6fce9e7..30b155098606 100644
--- a/mm/mmap.c
+++ b/mm/mmap.c
@@ -895,10 +895,9 @@  int __vma_adjust(struct vm_area_struct *vma, unsigned long start,
-	if (mapping)
-		i_mmap_unlock_write(mapping);
 	if (root) {
+		i_mmap_unlock_write(mapping);
 		if (adjust_next)