| Message ID | 20200914024452.19167-2-longman@redhat.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | mm/memcg: Miscellaneous cleanups and streamlining | expand |
On Sun 13-09-20 22:44:50, Waiman Long wrote: > Since commit 0a31bc97c80c ("mm: memcontrol: rewrite uncharge API") and > commit 00501b531c47 ("mm: memcontrol: rewrite charge API") in v3.17, the > enum charge_type was no longer used anywhere. However, the enum itself > was not removed at that time. Remove the obsolete enum charge_type now. > > Signed-off-by: Waiman Long <longman@redhat.com> > Acked-by: Johannes Weiner <hannes@cmpxchg.org> > Reviewed-by: Shakeel Butt <shakeelb@google.com> Acked-by: Michal Hocko <mhocko@suse.com> > --- > mm/memcontrol.c | 8 -------- > 1 file changed, 8 deletions(-) > > diff --git a/mm/memcontrol.c b/mm/memcontrol.c > index cfa6cbad21d5..8c74f1200261 100644 > --- a/mm/memcontrol.c > +++ b/mm/memcontrol.c > @@ -197,14 +197,6 @@ static struct move_charge_struct { > #define MEM_CGROUP_MAX_RECLAIM_LOOPS 100 > #define MEM_CGROUP_MAX_SOFT_LIMIT_RECLAIM_LOOPS 2 > > -enum charge_type { > - MEM_CGROUP_CHARGE_TYPE_CACHE = 0, > - MEM_CGROUP_CHARGE_TYPE_ANON, > - MEM_CGROUP_CHARGE_TYPE_SWAPOUT, /* for accounting swapcache */ > - MEM_CGROUP_CHARGE_TYPE_DROP, /* a page was unused swap cache */ > - NR_CHARGE_TYPE, > -}; > - > /* for encoding cft->private value on file */ > enum res_type { > _MEM, > -- > 2.18.1 >
diff --git a/mm/memcontrol.c b/mm/memcontrol.c index cfa6cbad21d5..8c74f1200261 100644 --- a/mm/memcontrol.c +++ b/mm/memcontrol.c @@ -197,14 +197,6 @@ static struct move_charge_struct { #define MEM_CGROUP_MAX_RECLAIM_LOOPS 100 #define MEM_CGROUP_MAX_SOFT_LIMIT_RECLAIM_LOOPS 2 -enum charge_type { - MEM_CGROUP_CHARGE_TYPE_CACHE = 0, - MEM_CGROUP_CHARGE_TYPE_ANON, - MEM_CGROUP_CHARGE_TYPE_SWAPOUT, /* for accounting swapcache */ - MEM_CGROUP_CHARGE_TYPE_DROP, /* a page was unused swap cache */ - NR_CHARGE_TYPE, -}; - /* for encoding cft->private value on file */ enum res_type { _MEM,
Since commit 0a31bc97c80c ("mm: memcontrol: rewrite uncharge API") and commit 00501b531c47 ("mm: memcontrol: rewrite charge API") in v3.17, the enum charge_type was no longer used anywhere. However, the enum itself was not removed at that time. Remove the obsolete enum charge_type now. Signed-off-by: Waiman Long <longman@redhat.com> Acked-by: Johannes Weiner <hannes@cmpxchg.org> Reviewed-by: Shakeel Butt <shakeelb@google.com> --- mm/memcontrol.c | 8 -------- 1 file changed, 8 deletions(-)