diff mbox series

mm/page_alloc.c: variable type of 'progress' should be 'unsigned long'

Message ID 20200915104620.20582-1-yanfei.xu@windriver.com (mailing list archive)
State New, archived
Headers show
Series mm/page_alloc.c: variable type of 'progress' should be 'unsigned long' | expand

Commit Message

Xu, Yanfei Sept. 15, 2020, 10:46 a.m. UTC 
From: Yanfei Xu <yanfei.xu@windriver.com>

try_to_free_pages returns the number of pages reclaimed, and the type of
returns is 'unsigned long'. So we should use a matched type for storing
it.

Signed-off-by: Yanfei Xu <yanfei.xu@windriver.com>
---
 mm/page_alloc.c | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)

Comments

Andrew Morton Sept. 16, 2020, 12:48 a.m. UTC | #1 
On Tue, 15 Sep 2020 18:46:20 +0800 <yanfei.xu@windriver.com> wrote:

> From: Yanfei Xu <yanfei.xu@windriver.com>
> 
> try_to_free_pages returns the number of pages reclaimed, and the type of
> returns is 'unsigned long'. So we should use a matched type for storing
> it.
> 

__perform_reclaim() returns an int, so this change is fairly pointless.

However __perform_reclaim()'s single caller expects it to return
unsigned long, so including that change in this patch would make more
sense.
Xu, Yanfei Sept. 16, 2020, 1:56 a.m. UTC | #2 
On 9/16/20 8:48 AM, Andrew Morton wrote:
> On Tue, 15 Sep 2020 18:46:20 +0800 <yanfei.xu@windriver.com> wrote:
> 
>> From: Yanfei Xu <yanfei.xu@windriver.com>
>>
>> try_to_free_pages returns the number of pages reclaimed, and the type of
>> returns is 'unsigned long'. So we should use a matched type for storing
>> it.
>>
> 
> __perform_reclaim() returns an int, so this change is fairly pointless.
> 
> However __perform_reclaim()'s single caller expects it to return
> unsigned long, so including that change in this patch would make more
> sense.
> 
Yeah, thanks for reminding. I will add that and send a v2. :)

Regards,
Yanfei
diff mbox series

Patch

diff --git a/mm/page_alloc.c b/mm/page_alloc.c
index fab5e97dc9ca..5f1016c70b94 100644
--- a/mm/page_alloc.c
+++ b/mm/page_alloc.c
@@ -4245,9 +4245,8 @@  static int
 __perform_reclaim(gfp_t gfp_mask, unsigned int order,
 					const struct alloc_context *ac)
 {
-	int progress;
 	unsigned int noreclaim_flag;
-	unsigned long pflags;
+	unsigned long pflags, progress;
 
 	cond_resched();