Message ID | 20200930222130.4175584-3-kaleshsingh@google.com (mailing list archive) |
---|---|
State | New, archived |
Headers | show
Return-Path: <SRS0=rM6x=DH=kvack.org=owner-linux-mm@kernel.org> Received: from mail.kernel.org (pdx-korg-mail-1.web.codeaurora.org [172.30.200.123]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id F1AB46CA for <patchwork-linux-mm@patchwork.kernel.org>; Wed, 30 Sep 2020 22:21:59 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id AB74D20719 for <patchwork-linux-mm@patchwork.kernel.org>; Wed, 30 Sep 2020 22:21:59 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (2048-bit key) header.d=google.com header.i=@google.com header.b="boDpHG4Y" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org AB74D20719 Authentication-Results: mail.kernel.org; dmarc=fail (p=reject dis=none) header.from=google.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id EE6D9900003; Wed, 30 Sep 2020 18:21:58 -0400 (EDT) Delivered-To: linux-mm-outgoing@kvack.org Received: by kanga.kvack.org (Postfix, from userid 40) id E6D326B006C; Wed, 30 Sep 2020 18:21:58 -0400 (EDT) X-Original-To: int-list-linux-mm@kvack.org X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id D5C2F900003; Wed, 30 Sep 2020 18:21:58 -0400 (EDT) X-Original-To: linux-mm@kvack.org X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0241.hostedemail.com [216.40.44.241]) by kanga.kvack.org (Postfix) with ESMTP id BECB06B0068 for <linux-mm@kvack.org>; Wed, 30 Sep 2020 18:21:58 -0400 (EDT) Received: from smtpin18.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay05.hostedemail.com (Postfix) with ESMTP id 80756181AE864 for <linux-mm@kvack.org>; Wed, 30 Sep 2020 22:21:58 +0000 (UTC) X-FDA: 77321151516.18.crate66_421838127196 Received: from filter.hostedemail.com (10.5.16.251.rfc1918.com [10.5.16.251]) by smtpin18.hostedemail.com (Postfix) with ESMTP id 58B711017D455 for <linux-mm@kvack.org>; Wed, 30 Sep 2020 22:21:58 +0000 (UTC) X-Spam-Summary: 1,0,0,,d41d8cd98f00b204,3bav1xwskcompfqjxmxnslmlttlqj.htrqnszc-rrpafhp.twl@flex--kaleshsingh.bounces.google.com,,RULES_HIT:30012:30054,0,RBL:209.85.219.202:@flex--kaleshsingh.bounces.google.com:.lbl8.mailshell.net-66.100.201.100 62.18.0.100;04yf9roea8n74uzrj1b1og9itwnk8ocuyuqmsgaiyd9yy45sy33sded9youmjd9.eirtwyg8ud5pjmo8tjsjtqgzcjsntidarpcdybwgyz49q4i7b4a57m1usdp6qgj.o-lbl8.mailshell.net-223.238.255.100,CacheIP:none,Bayesian:0.5,0.5,0.5,Netcheck:none,DomainCache:0,MSF:not bulk,SPF:fp,MSBL:0,DNSBL:mail-archive.com-dnsbl7.mailshell.net-127.2.0.20,Custom_rules:0:0:0,LFtime:24,LUA_SUMMARY:none X-HE-Tag: crate66_421838127196 X-Filterd-Recvd-Size: 6365 Received: from mail-yb1-f202.google.com (mail-yb1-f202.google.com [209.85.219.202]) by imf13.hostedemail.com (Postfix) with ESMTP for <linux-mm@kvack.org>; Wed, 30 Sep 2020 22:21:57 +0000 (UTC) Received: by mail-yb1-f202.google.com with SMTP id b3so3159231ybg.23 for <linux-mm@kvack.org>; Wed, 30 Sep 2020 15:21:57 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20161025; h=sender:date:in-reply-to:message-id:mime-version:references:subject :from:cc; bh=M0Jnd5wDs989jegufD80A647gOObA9k7fcoXOfGIBiI=; b=boDpHG4YKr/2sBYi+LXa7BYu2zahi8BWNiXF87MohJyyIman1YZgh2emp0eq+ALxVF N8Rorega2dCLqmupg5pggd4PEd0bioiDmLQNT/uayIfQYI/mK9sOXXXaXnkfAPLGDmJx /Co7dHpFXUZPb6JhgzEuOs4vsL7nB/ouZzo9v6V4300dN5vLptrbHO4vapViZXwBudAh Ek2t7vH58qT4ABFOsGeFw8dE9HSppt8Cv93fwPd7G3MmAMn3Em8oG/bsv6UWDPJ3jGbg m/Zl/8FLGMadTgwwz/0FCcE3Bg5lmumAkFDQr0+kGeF1/sPrtYOu+Lj4tH/9bYQCLPbI YrzA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:date:in-reply-to:message-id:mime-version :references:subject:from:cc; bh=M0Jnd5wDs989jegufD80A647gOObA9k7fcoXOfGIBiI=; b=WcSFnQVAFYgE5cM0Cc4O73NABFOKi7JRxfgzvOssD8DfklbMQaNjBT8lrwu+QqWrFI b0EpsO2kJeV+AuLlFhWOfik9kqt1+epVS8MP53f3wLsWB3lz7DMcBklWl1/XL+uSM8v3 D0CvCBlpmSFhfOzUmTo59VtbOnKO7gJr18ppVRx/o165/sbSWLmsLgvOm3kz/PcH2hF2 tj8S+5nmG/oekoYEZydDezRQy1Jx8AMh4kKFfE6SgbR3VDvZP6YnPTbkMV0mRx6PP0yP e4++huNvqBvq9eKg3SyPRimmw1g6yQZCe7o5FeoKMpBQqoXJWbSalxoZZPh/bbbSUvEG 3mGw== X-Gm-Message-State: AOAM5325QlTw4u0q2Lo4cPB8E32J9TU/jCTXKz4PzA3RKe0mBYs8uNnw /RZNMEmFxPOZH/xhPUZVBsPuGhYRj/IhTz6HCQ== X-Google-Smtp-Source: ABdhPJzpG054ym1h9s82GZx0gEkFQHO8lOnhV52qK7oqfRRBlQ4XabfPxVWgnQguS08M76s/iC40L0YtMGRjB+Vw+Q== X-Received: from kaleshsingh.c.googlers.com ([fda3:e722:ac3:10:14:4d90:c0a8:2145]) (user=kaleshsingh job=sendgmr) by 2002:a25:ae9f:: with SMTP id b31mr6084827ybj.437.1601504516920; Wed, 30 Sep 2020 15:21:56 -0700 (PDT) Date: Wed, 30 Sep 2020 22:21:19 +0000 In-Reply-To: <20200930222130.4175584-1-kaleshsingh@google.com> Message-Id: <20200930222130.4175584-3-kaleshsingh@google.com> Mime-Version: 1.0 References: <20200930222130.4175584-1-kaleshsingh@google.com> X-Mailer: git-send-email 2.28.0.709.gb0816b6eb0-goog Subject: [PATCH 2/5] arm64: mremap speedup - Enable HAVE_MOVE_PMD From: Kalesh Singh <kaleshsingh@google.com> Cc: surenb@google.com, minchan@google.com, joelaf@google.com, lokeshgidra@google.com, kaleshsingh@google.com, kernel-team@android.com, Catalin Marinas <catalin.marinas@arm.com>, Will Deacon <will@kernel.org>, Thomas Gleixner <tglx@linutronix.de>, Ingo Molnar <mingo@redhat.com>, Borislav Petkov <bp@alien8.de>, x86@kernel.org, "H. Peter Anvin" <hpa@zytor.com>, Andrew Morton <akpm@linux-foundation.org>, Shuah Khan <shuah@kernel.org>, Kees Cook <keescook@chromium.org>, "Aneesh Kumar K.V" <aneesh.kumar@linux.ibm.com>, Peter Zijlstra <peterz@infradead.org>, Sami Tolvanen <samitolvanen@google.com>, Arnd Bergmann <arnd@arndb.de>, Masahiro Yamada <masahiroy@kernel.org>, Krzysztof Kozlowski <krzk@kernel.org>, Frederic Weisbecker <frederic@kernel.org>, Hassan Naveed <hnaveed@wavecomp.com>, Christian Brauner <christian.brauner@ubuntu.com>, Mark Rutland <mark.rutland@arm.com>, Mike Rapoport <rppt@kernel.org>, Gavin Shan <gshan@redhat.com>, Mark Brown <broonie@kernel.org>, Jia He <justin.he@arm.com>, Zhenyu Ye <yezhenyu2@huawei.com>, John Hubbard <jhubbard@nvidia.com>, Dave Hansen <dave.hansen@intel.com>, Sandipan Das <sandipan@linux.ibm.com>, Ralph Campbell <rcampbell@nvidia.com>, "Kirill A. Shutemov" <kirill.shutemov@linux.intel.com>, Ram Pai <linuxram@us.ibm.com>, Mina Almasry <almasrymina@google.com>, Colin Ian King <colin.king@canonical.com>, Masami Hiramatsu <mhiramat@kernel.org>, SeongJae Park <sjpark@amazon.de>, Brian Geffon <bgeffon@google.com>, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-mm@kvack.org, linux-kselftest@vger.kernel.org Content-Type: text/plain; charset="UTF-8" X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: <linux-mm.kvack.org> |
Series | Speed up mremap on large regions | expand |
diff --git a/arch/arm64/Kconfig b/arch/arm64/Kconfig index 6d232837cbee..844d089668e3 100644 --- a/arch/arm64/Kconfig +++ b/arch/arm64/Kconfig @@ -121,6 +121,7 @@ config ARM64 select GENERIC_VDSO_TIME_NS select HANDLE_DOMAIN_IRQ select HARDIRQS_SW_RESEND + select HAVE_MOVE_PMD select HAVE_PCI select HAVE_ACPI_APEI if (ACPI && EFI) select HAVE_ALIGNED_STRUCT_PAGE if SLUB
HAVE_MOVE_PMD enables remapping pages at the PMD level if both the source and destination addresses are PMD-aligned. HAVE_MOVE_PMD is already enabled on x86. The original patch [1] that introduced this config did not enable it on arm64 at the time because of performance issues with flushing the TLB on every PMD move. These issues have since been addressed in more recent releases with improvements to the arm64 TLB invalidation and core mmu_gather code as Will Deacon mentioned in [2]. From the data below, it can be inferred that there is approximately 8x improvement in performance when HAVE_MOVE_PMD is enabled on arm64. --------- Test Results ---------- The following results were obtained on an arm64 device running a 5.4 kernel, by remapping a PMD-aligned, 1GB sized region to a PMD-aligned destination. The results from 10 iterations of the test are given below. All times are in nanoseconds. Control HAVE_MOVE_PMD 9220833 1247761 9002552 1219896 9254115 1094792 8725885 1227760 9308646 1043698 9001667 1101771 8793385 1159896 8774636 1143594 9553125 1025833 9374010 1078125 9100885.4 1134312.6 <-- Mean Time in nanoseconds Total mremap time for a 1GB sized PMD-aligned region drops from ~9.1 milliseconds to ~1.1 milliseconds. (~8x speedup). [1] https://lore.kernel.org/r/20181108181201.88826-3-joelaf@google.com [2] https://www.mail-archive.com/linuxppc-dev@lists.ozlabs.org/msg140837.html Signed-off-by: Kalesh Singh <kaleshsingh@google.com> --- arch/arm64/Kconfig | 1 + 1 file changed, 1 insertion(+)