[042/181] drivers/base: make device_find_child_by_name() compatible with sysfs inputs

Commit Message

Andrew Morton Oct. 13, 2020, 11:50 p.m. UTC

From: Dan Williams <[e-mail]>
Subject: drivers/base: make device_find_child_by_name() compatible with sysfs inputs

Use sysfs_streq() in device_find_child_by_name() to allow it to use a
sysfs input string that might contain a trailing newline.

The other "device by name" interfaces,
{bus,driver,class}_find_device_by_name(), already account for sysfs
strings.

Link: https://lkml.kernel.org/r/[e-mail]
Link: https://lkml.kernel.org/r/[e-mail]
Signed-off-by: Dan Williams <[e-mail]>
Reviewed-by: Greg Kroah-Hartman <[e-mail]>
Cc: Andy Lutomirski <[e-mail]>
Cc: Ard Biesheuvel <[e-mail]>
Cc: Ard Biesheuvel <[e-mail]>
Cc: Benjamin Herrenschmidt <[e-mail]>
Cc: Ben Skeggs <[e-mail]>
Cc: Bjorn Helgaas <[e-mail]>
Cc: Borislav Petkov <[e-mail]>
Cc: Boris Ostrovsky <[e-mail]>
Cc: Brice Goglin <[e-mail]>
Cc: Catalin Marinas <[e-mail]>
Cc: Daniel Vetter <[e-mail]>
Cc: Dave Hansen <[e-mail]>
Cc: Dave Jiang <[e-mail]>
Cc: David Airlie <[e-mail]>
Cc: David Hildenbrand <[e-mail]>
Cc: "H. Peter Anvin" <[e-mail]>
Cc: Hulk Robot <[e-mail]>
Cc: Ingo Molnar <[e-mail]>
Cc: Ira Weiny <[e-mail]>
Cc: Jason Gunthorpe <[e-mail]>
Cc: Jason Yan <[e-mail]>
Cc: Jeff Moyer <[e-mail]>
Cc: "Jérôme Glisse" <[e-mail]>
Cc: Jia He <[e-mail]>
Cc: Joao Martins <[e-mail]>
Cc: Jonathan Cameron <[e-mail]>
Cc: Juergen Gross <[e-mail]>
Cc: kernel test robot <[e-mail]>
Cc: Michael Ellerman <[e-mail]>
Cc: Mike Rapoport <[e-mail]>
Cc: Paul Mackerras <[e-mail]>
Cc: Pavel Tatashin <[e-mail]>
Cc: Peter Zijlstra <[e-mail]>
Cc: "Rafael J. Wysocki" <[e-mail]>
Cc: Randy Dunlap <[e-mail]>
Cc: Stefano Stabellini <[e-mail]>
Cc: Thomas Gleixner <[e-mail]>
Cc: Tom Lendacky <[e-mail]>
Cc: Vishal Verma <[e-mail]>
Cc: Vivek Goyal <[e-mail]>
Cc: Wei Yang <[e-mail]>
Cc: Will Deacon <[e-mail]>
Signed-off-by: Andrew Morton <[e-mail]>
---

 drivers/base/core.c |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Patch

--- a/drivers/base/core.c~drivers-base-make-device_find_child_by_name-compatible-with-sysfs-inputs
+++ a/drivers/base/core.c
@@ -3324,7 +3324,7 @@  struct device *device_find_child_by_name
 
 	klist_iter_init(&parent->p->klist_children, &i);
 	while ((child = next_device(&i)))
-		if (!strcmp(dev_name(child), name) && get_device(child))
+		if (sysfs_streq(dev_name(child), name) && get_device(child))
 			break;
 	klist_iter_exit(&i);
 	return child;