From patchwork Fri Oct 16 16:04:34 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Matthew Wilcox X-Patchwork-Id: 11842035 Return-Path: Received: from mail.kernel.org (pdx-korg-mail-1.web.codeaurora.org [172.30.200.123]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id 5353517C9 for ; Fri, 16 Oct 2020 16:05:14 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id BE51D207BC for ; Fri, 16 Oct 2020 16:04:58 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (2048-bit key) header.d=infradead.org header.i=@infradead.org header.b="CdVGkVMa" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org BE51D207BC Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=infradead.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id CD14094000E; Fri, 16 Oct 2020 12:04:52 -0400 (EDT) Delivered-To: linux-mm-outgoing@kvack.org Received: by kanga.kvack.org (Postfix, from userid 40) id B8CEB94000F; Fri, 16 Oct 2020 12:04:52 -0400 (EDT) X-Original-To: int-list-linux-mm@kvack.org X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 96660940007; Fri, 16 Oct 2020 12:04:52 -0400 (EDT) X-Original-To: linux-mm@kvack.org X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0150.hostedemail.com [216.40.44.150]) by kanga.kvack.org (Postfix) with ESMTP id D1DC594000B for ; Fri, 16 Oct 2020 12:04:51 -0400 (EDT) Received: from smtpin05.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay04.hostedemail.com (Postfix) with ESMTP id 157CB1EE6 for ; Fri, 16 Oct 2020 16:04:50 +0000 (UTC) X-FDA: 77378261940.05.glove73_1c121e12721e Received: from filter.hostedemail.com (10.5.16.251.rfc1918.com [10.5.16.251]) by smtpin05.hostedemail.com (Postfix) with ESMTP id EE3A4180002DD for ; Fri, 16 Oct 2020 16:04:49 +0000 (UTC) X-Spam-Summary: 1,0,0,cdb99934f4eda40a,d41d8cd98f00b204,willy@infradead.org,,RULES_HIT:41:355:379:541:800:960:973:988:989:1260:1311:1314:1345:1359:1437:1515:1534:1540:1711:1714:1730:1747:1777:1792:2393:2559:2562:3138:3139:3140:3141:3142:3350:3865:3867:4321:5007:6120:6261:6653:7901:8957:10004:11026:11473:11658:11914:12296:12297:12438:12555:12679:12895:12986:13069:13161:13229:13311:13357:13894:14096:14181:14384:14394:14721:21080:21451:21627:21990:30054,0,RBL:90.155.50.34:@infradead.org:.lbl8.mailshell.net-64.201.201.201 62.8.15.100;04yrm9ehsy33hep6z5p9zpqmddkcnoceaz44ache7z6ehmaa35w6essoxe5qbeu.3axgqu4fp6stojqih1remj9799g3rt6bp6u8kcmfmsk1ohu8qsemp65unsnr4da.n-lbl8.mailshell.net-223.238.255.100,CacheIP:none,Bayesian:0.5,0.5,0.5,Netcheck:none,DomainCache:0,MSF:not bulk,SPF:fn,MSBL:0,DNSBL:neutral,Custom_rules:0:0:0,LFtime:362,LUA_SUMMARY:none X-HE-Tag: glove73_1c121e12721e X-Filterd-Recvd-Size: 2447 Received: from casper.infradead.org (casper.infradead.org [90.155.50.34]) by imf45.hostedemail.com (Postfix) with ESMTP for ; Fri, 16 Oct 2020 16:04:48 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=casper.20170209; h=Content-Transfer-Encoding:MIME-Version: References:In-Reply-To:Message-Id:Date:Subject:Cc:To:From:Sender:Reply-To: Content-Type:Content-ID:Content-Description; bh=U62SUaGW7wvOzK2xtP2u7DsjwRF7PHeB8dtYgkbpx0Q=; b=CdVGkVMaoXabyV+hrVSqK0odLg tgot/W/wg6U/L9Bx0gdVcEX7lrcOHYN3Frq5MaulMpsGEaXsKPKLzveb65eQmIPo5V39m0CIeX7fj s1KIYMFkLJ7/yAlbPDcQ/TSRJEbMfs6sIuIwL4r8BemNcj6mk1DWLKkiMyn0ph6M6uDQsz7HCFPxC BnckCaWY79K4nud1xekf6IU6CP2/DpYTUR9B+cKhsQ5Y7pAMlK7E9OMEOV/fEDlgk9F0EE7dOhEA2 CApuNcKRL6y9+MNUF+7xe5EU8gQ7VCHJREN5Fp4Bphfd5A0rmXo31I8cPFG7NAjbSoHO8k0A3p6b8 eOvHL48Q==; Received: from willy by casper.infradead.org with local (Exim 4.92.3 #3 (Red Hat Linux)) id 1kTSDn-0004t1-8n; Fri, 16 Oct 2020 16:04:47 +0000 From: "Matthew Wilcox (Oracle)" To: linux-fsdevel@vger.kernel.org Cc: "Matthew Wilcox (Oracle)" , linux-mm@kvack.org, Nicolas Pitre Subject: [PATCH v3 09/18] cramfs: Tell the VFS that readpage was synchronous Date: Fri, 16 Oct 2020 17:04:34 +0100 Message-Id: <20201016160443.18685-10-willy@infradead.org> X-Mailer: git-send-email 2.21.3 In-Reply-To: <20201016160443.18685-1-willy@infradead.org> References: <20201016160443.18685-1-willy@infradead.org> MIME-Version: 1.0 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: The cramfs readpage implementation was already synchronous, so use AOP_UPDATED_PAGE to avoid cycling the page lock. Signed-off-by: Matthew Wilcox (Oracle) --- fs/cramfs/inode.c | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git a/fs/cramfs/inode.c b/fs/cramfs/inode.c index 912308600d39..7a642146c074 100644 --- a/fs/cramfs/inode.c +++ b/fs/cramfs/inode.c @@ -916,15 +916,14 @@ static int cramfs_readpage(struct file *file, struct page *page) flush_dcache_page(page); kunmap(page); SetPageUptodate(page); - unlock_page(page); - return 0; + return AOP_UPDATED_PAGE; err: kunmap(page); ClearPageUptodate(page); SetPageError(page); unlock_page(page); - return 0; + return -EIO; } static const struct address_space_operations cramfs_aops = {