From patchwork Sat Nov 14 06:52:10 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Andrew Morton X-Patchwork-Id: 11905449 Return-Path: Received: from mail.kernel.org (pdx-korg-mail-1.web.codeaurora.org [172.30.200.123]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id C87081391 for ; Sat, 14 Nov 2020 06:52:14 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 8084C22283 for ; Sat, 14 Nov 2020 06:52:14 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=kernel.org header.i=@kernel.org header.b="1fZAVFGV" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 8084C22283 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=linux-foundation.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id 448E86B0087; Sat, 14 Nov 2020 01:52:13 -0500 (EST) Delivered-To: linux-mm-outgoing@kvack.org Received: by kanga.kvack.org (Postfix, from userid 40) id 3F8E96B0088; Sat, 14 Nov 2020 01:52:13 -0500 (EST) X-Original-To: int-list-linux-mm@kvack.org X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 311646B0089; Sat, 14 Nov 2020 01:52:13 -0500 (EST) X-Original-To: linux-mm@kvack.org X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0027.hostedemail.com [216.40.44.27]) by kanga.kvack.org (Postfix) with ESMTP id F02686B0087 for ; Sat, 14 Nov 2020 01:52:12 -0500 (EST) Received: from smtpin22.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay02.hostedemail.com (Postfix) with ESMTP id 924733620 for ; Sat, 14 Nov 2020 06:52:12 +0000 (UTC) X-FDA: 77482104504.22.arm65_020b97e27315 Received: from filter.hostedemail.com (10.5.16.251.rfc1918.com [10.5.16.251]) by smtpin22.hostedemail.com (Postfix) with ESMTP id 78C4E18038E68 for ; Sat, 14 Nov 2020 06:52:12 +0000 (UTC) X-Spam-Summary: 1,0,0,30d40bd9f340a380,d41d8cd98f00b204,akpm@linux-foundation.org,,RULES_HIT:41:355:379:800:960:967:973:988:989:1260:1345:1359:1381:1431:1437:1534:1541:1711:1730:1747:1777:1792:2393:2525:2559:2563:2682:2685:2859:2902:2933:2937:2939:2942:2945:2947:2951:2954:3022:3138:3139:3140:3141:3142:3165:3352:3871:3876:3934:3936:3938:3941:3944:3947:3950:3953:3956:3959:4321:5007:6261:6653:7576:9025:9038:9545:9592:10004:11026:11473:11658:11914:12043:12048:12114:12296:12297:12438:12517:12519:12555:12679:12986:13069:13311:13357:13846:14096:14181:14384:14721:21080:21451:21627:21660:21939:30029:30054,0,RBL:198.145.29.99:@linux-foundation.org:.lbl8.mailshell.net-62.2.0.100 64.100.201.201;04yf8x3erbr3kjoaty3ptqnzxgcdtopag1dqju9xrn1c3e5wx44npo5whny46j5.hf883c4jznpuwixuo543mzkafersbte1d5bsqowyo3rkhfm5j8a78rnke4mduxi.h-lbl8.mailshell.net-223.238.255.100,CacheIP:none,Bayesian:0.5,0.5,0.5,Netcheck:none,DomainCache:0,MSF:not bulk,SPF:fp,MSBL:0,DNSBL:neutral,Custom_rules:0:0:0,LFtime:70,L UA_SUMMA X-HE-Tag: arm65_020b97e27315 X-Filterd-Recvd-Size: 2802 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by imf37.hostedemail.com (Postfix) with ESMTP for ; Sat, 14 Nov 2020 06:52:11 +0000 (UTC) Received: from localhost.localdomain (c-73-231-172-41.hsd1.ca.comcast.net [73.231.172.41]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id DAB7022277; Sat, 14 Nov 2020 06:52:10 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1605336731; bh=zEYtFxIkXGAzsFbtnuzralpgu2sPRq+8r/h4WDSpnIg=; h=Date:From:To:Subject:In-Reply-To:From; b=1fZAVFGVp/zlv9WSmMH6YC/9Wfk67Yu+3fQOt3lhLNP8xqkVnGLplY9s7b8h/rjiV bQUF7miXQbDiGa+wvRdtZMguGFxQ6im4yaZOZ+7t5phxYeMSe8N5xg7da7SsgRy25Y zjfQTwcF8gf+FeNgIncOQCR3P2mjdfpOTyjhQ6GE= Date: Fri, 13 Nov 2020 22:52:10 -0800 From: Andrew Morton To: akpm@linux-foundation.org, linux-mm@kvack.org, mm-commits@vger.kernel.org, pmladek@suse.com, santosh@fossix.org, tglx@linutronix.de, torvalds@linux-foundation.org Subject: [patch 10/14] kernel/watchdog: fix watchdog_allowed_mask not used warning Message-ID: <20201114065210.Pih4Q7Ptk%akpm@linux-foundation.org> In-Reply-To: <20201113225115.b24faebc85f710d5aff55aa7@linux-foundation.org> User-Agent: s-nail v14.8.16 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: From: Santosh Sivaraj Subject: kernel/watchdog: fix watchdog_allowed_mask not used warning Define watchdog_allowed_mask only when SOFTLOCKUP_DETECTOR is enabled. Link: https://lkml.kernel.org/r/20201106015025.1281561-1-santosh@fossix.org Fixes: 7feeb9cd4f5b ("watchdog/sysctl: Clean up sysctl variable name space") Signed-off-by: Santosh Sivaraj Reviewed-by: Petr Mladek Cc: Thomas Gleixner Signed-off-by: Andrew Morton --- kernel/watchdog.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) --- a/kernel/watchdog.c~kernel-watchdog-fix-watchdog_allowed_mask-not-used-warning +++ a/kernel/watchdog.c @@ -44,8 +44,6 @@ int __read_mostly soft_watchdog_user_ena int __read_mostly watchdog_thresh = 10; static int __read_mostly nmi_watchdog_available; -static struct cpumask watchdog_allowed_mask __read_mostly; - struct cpumask watchdog_cpumask __read_mostly; unsigned long *watchdog_cpumask_bits = cpumask_bits(&watchdog_cpumask); @@ -162,6 +160,8 @@ static void lockup_detector_update_enabl int __read_mostly sysctl_softlockup_all_cpu_backtrace; #endif +static struct cpumask watchdog_allowed_mask __read_mostly; + /* Global variables, exported for sysctl */ unsigned int __read_mostly softlockup_panic = CONFIG_BOOTPARAM_SOFTLOCKUP_PANIC_VALUE;