From patchwork Sun Nov 15 17:40:26 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Hui Su X-Patchwork-Id: 11906551 Return-Path: Received: from mail.kernel.org (pdx-korg-mail-1.web.codeaurora.org [172.30.200.123]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id A62DF14C0 for ; Sun, 15 Nov 2020 17:40:43 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 389D5223BF for ; Sun, 15 Nov 2020 17:40:43 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=163.com header.i=@163.com header.b="hMf4/uI0" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 389D5223BF Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=163.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id 3A77D6B0036; Sun, 15 Nov 2020 12:40:42 -0500 (EST) Delivered-To: linux-mm-outgoing@kvack.org Received: by kanga.kvack.org (Postfix, from userid 40) id 32F2A6B005D; Sun, 15 Nov 2020 12:40:42 -0500 (EST) X-Original-To: int-list-linux-mm@kvack.org X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 243066B0068; Sun, 15 Nov 2020 12:40:42 -0500 (EST) X-Original-To: linux-mm@kvack.org X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0029.hostedemail.com [216.40.44.29]) by kanga.kvack.org (Postfix) with ESMTP id EC1FE6B0036 for ; Sun, 15 Nov 2020 12:40:41 -0500 (EST) Received: from smtpin10.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay02.hostedemail.com (Postfix) with ESMTP id 95F3C3622 for ; Sun, 15 Nov 2020 17:40:41 +0000 (UTC) X-FDA: 77487367482.10.self06_0917b5b27322 Received: from filter.hostedemail.com (10.5.16.251.rfc1918.com [10.5.16.251]) by smtpin10.hostedemail.com (Postfix) with ESMTP id 72B9716A0AE for ; Sun, 15 Nov 2020 17:40:41 +0000 (UTC) X-Spam-Summary: 1,0,0,2d53f14a970bdfd7,d41d8cd98f00b204,sh_def@163.com,,RULES_HIT:41:355:379:582:800:960:968:973:988:989:1152:1260:1277:1312:1313:1314:1345:1437:1516:1518:1519:1534:1541:1593:1594:1595:1596:1711:1730:1747:1777:1792:2198:2199:2393:2559:2562:3138:3139:3140:3141:3142:3352:3865:3868:3870:4321:4605:5007:6261:6653:10004:10400:11026:11334:11658:11914:12043:12048:12294:12296:12297:12555:12895:12986:13069:13311:13357:13439:13895:14096:14097:14181:14394:14721:21080:21627:21990:30054:30075,0,RBL:220.181.12.12:@163.com:.lbl8.mailshell.net-66.100.201.100 62.50.2.100;04yrna1c6a351m9d7eoy1ptcy94qzopaen7u1trnnj7n37rer18hhp5gq3sgoga.qppng7qmf9nfsxn9jcops59xgnynsb7zimyoyub81e8gknth9o7os8aewh75zwx.s-lbl8.mailshell.net-223.238.255.100,CacheIP:none,Bayesian:0.5,0.5,0.5,Netcheck:none,DomainCache:0,MSF:not bulk,SPF:fp,MSBL:0,DNSBL:neutral,Custom_rules:0:0:0,LFtime:69,LUA_SUMMARY:none X-HE-Tag: self06_0917b5b27322 X-Filterd-Recvd-Size: 2821 Received: from m12-12.163.com (m12-12.163.com [220.181.12.12]) by imf24.hostedemail.com (Postfix) with ESMTP for ; Sun, 15 Nov 2020 17:40:40 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=163.com; s=s110527; h=Date:From:Subject:Message-ID:MIME-Version; bh=M9YE+ nEi7ToBJssgtcVSR4GHXesbHG/ju79zY8NhtOk=; b=hMf4/uI0UjRZ8+Rhx6JUm eDB2g4JJ/S6OH2RrVB2/25JbUTniHgs+mBoW1CRqQTpiHHSy+WdP18kao+RdogeZ 3+IMrCjUkeVmBdhr/IaggPj7SN0mFeO72D8ueNdWcbX6HZjR4/a/1C2tHQssMnCK ziXnJberGk6P+kqUk6vxOI= Received: from localhost (unknown [101.86.213.176]) by smtp8 (Coremail) with SMTP id DMCowAC3SdgLaLFfPOWJBw--.63244S2; Mon, 16 Nov 2020 01:40:27 +0800 (CST) Date: Mon, 16 Nov 2020 01:40:26 +0800 From: Hui Su To: hughd@google.com, akpm@linux-foundation.org, linux-mm@kvack.org, linux-kernel@vger.kernel.org Cc: sh_def@163.com Subject: [PATCH] mm/shmem: use kmem_cache_zalloc in shmem_alloc_inode() Message-ID: <20201115174026.GA365412@rlk> MIME-Version: 1.0 Content-Disposition: inline X-CM-TRANSID: DMCowAC3SdgLaLFfPOWJBw--.63244S2 X-Coremail-Antispam: 1Uf129KBjvJXoW7uw47GrWrJFWDury7ur1xXwb_yoW8Jw1rpF W7Gw18Ja15XFyIgrW8tr4kuryrKayxKrW2ya42qwsIv3Z0q340gF4UtFy5ZFyrCFWxZF4S vr10kr18uF45ArJanT9S1TB71UUUUU7qnTZGkaVYY2UrUUUUjbIjqfuFe4nvWSU5nxnvy2 9KBjDUYxBIdaVFxhVjvjDU0xZFpf9x07UONVkUUUUU= X-Originating-IP: [101.86.213.176] X-CM-SenderInfo: xvkbvvri6rljoofrz/1tbiJgvdX1v2fAJsmgAAsK X-Bogosity: Ham, tests=bogofilter, spamicity=0.005858, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: in shmem_get_inode(): new_inode(); new_inode_pseudo(); alloc_inode(); ops->alloc_inode(); -> shmem_alloc_inode() kmem_cache_alloc(); memset(info, 0, (char *)inode - (char *)info); So use kmem_cache_zalloc() in shmem_alloc_inode(), and remove the memset in shmem_get_inode(). Signed-off-by: Hui Su --- mm/shmem.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/mm/shmem.c b/mm/shmem.c index 537c137698f8..b84adda45461 100644 --- a/mm/shmem.c +++ b/mm/shmem.c @@ -2308,7 +2308,6 @@ static struct inode *shmem_get_inode(struct super_block *sb, const struct inode inode->i_atime = inode->i_mtime = inode->i_ctime = current_time(inode); inode->i_generation = prandom_u32(); info = SHMEM_I(inode); - memset(info, 0, (char *)inode - (char *)info); spin_lock_init(&info->lock); atomic_set(&info->stop_eviction, 0); info->seals = F_SEAL_SEAL; @@ -3828,7 +3827,7 @@ static struct kmem_cache *shmem_inode_cachep; static struct inode *shmem_alloc_inode(struct super_block *sb) { struct shmem_inode_info *info; - info = kmem_cache_alloc(shmem_inode_cachep, GFP_KERNEL); + info = kmem_cache_zalloc(shmem_inode_cachep, GFP_KERNEL); if (!info) return NULL; return &info->vfs_inode;