From patchwork Mon Nov 16 22:00:32 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Uladzislau Rezki X-Patchwork-Id: 11910919 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-12.3 required=3.0 tests=BAYES_00, DKIM_ADSP_CUSTOM_MED,DKIM_INVALID,DKIM_SIGNED,FREEMAIL_FORGED_FROMDOMAIN, FREEMAIL_FROM,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 7145AC63697 for ; Mon, 16 Nov 2020 22:00:52 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id CDB41241A3 for ; Mon, 16 Nov 2020 22:00:51 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="QraJNQ59" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org CDB41241A3 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=gmail.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id 5977C6B005C; Mon, 16 Nov 2020 17:00:51 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 4F6CC6B005D; Mon, 16 Nov 2020 17:00:51 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 3C01E6B006C; Mon, 16 Nov 2020 17:00:51 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0018.hostedemail.com [216.40.44.18]) by kanga.kvack.org (Postfix) with ESMTP id 0FBC26B005C for ; Mon, 16 Nov 2020 17:00:51 -0500 (EST) Received: from smtpin15.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay02.hostedemail.com (Postfix) with ESMTP id B13DA3629 for ; Mon, 16 Nov 2020 22:00:50 +0000 (UTC) X-FDA: 77491651860.15.guide99_09061ef2732c Received: from filter.hostedemail.com (10.5.16.251.rfc1918.com [10.5.16.251]) by smtpin15.hostedemail.com (Postfix) with ESMTP id 9696D1814B0C9 for ; Mon, 16 Nov 2020 22:00:46 +0000 (UTC) X-HE-Tag: guide99_09061ef2732c X-Filterd-Recvd-Size: 3822 Received: from mail-lf1-f65.google.com (mail-lf1-f65.google.com [209.85.167.65]) by imf27.hostedemail.com (Postfix) with ESMTP for ; Mon, 16 Nov 2020 22:00:46 +0000 (UTC) Received: by mail-lf1-f65.google.com with SMTP id u18so27248168lfd.9 for ; Mon, 16 Nov 2020 14:00:46 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=pbM+uzL6L3H+4aTUHFaDKbTwMCquf9JhugqpRvQq5Kc=; b=QraJNQ59ICnWgRHulII7yGGgG45c0rZRXw1NZS79Q8Aaj2xvz6mASVe49CmRSMtvmL 8EIkYCdrUa1Cg64uehUamCxrQO69NjK3QEEkmFd1ZBOJgPLmjCqAhapzR6zXAZa9J2Ew l7CA2Y6sdodQAjeGkAraf+U9Zj1LMKn7nKF0meNdjKmHCgxMYrG3LX/iKP2R9gx9baxm 2FX9XsjxMN0/aOimHSj3dN1kybOmQns5Aw+T6Bjtx6cRqWmPCx4EvTHBpqlYu7U98ttC W9W1pUKwstts0spEGsObaO6HdT9w4WuKOFKpLwBH4DFrI490zforVdkwMrlpjHs3BVVk UL5g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=pbM+uzL6L3H+4aTUHFaDKbTwMCquf9JhugqpRvQq5Kc=; b=aA/H/7OvzpmY+4vXBl7Qmbqd/mOW0RKXtHff6RZQ7chOGT5lPkHxLtQUxQrp705O+B WR+t2rZQRvEPM1iym+9lPPx4tyfDSAhRO22+iINP1BbFaD37izd7HaYtHwGcOD2HUAGK ognN+OMxrfgLZsYHEsB/AvFTVllx12YeLcWdcUHun3sY/0LmdpTzB15HcpBMZgHWP74/ tPBzQP/A0gWmvOHVp5yfpmdLPvkQfFX+oFGUNvqNWYyi993uI9NXAog7ORkog5uPBN5B f8J8qPVqQXEslifFDnZdBNJq4N4Pl3Duv2inVobjeWZStHWaK9dGqMvsJou9EtJteUkg haug== X-Gm-Message-State: AOAM531bFws8lEaZLjPf/WG4uvGcdHVrDsCqdgj+JhoFioLRjeYcbU9g wmRLE3LQ/AR1mvjTSz5nPB4= X-Google-Smtp-Source: ABdhPJx6S9mr+zts/Kn/uWIj3McFpRPnLqpyaeqn6EN5RvapZhu5lx1zaheNt2A2SkPAyCmv+YvG3w== X-Received: by 2002:a19:3f56:: with SMTP id m83mr473900lfa.381.1605564044598; Mon, 16 Nov 2020 14:00:44 -0800 (PST) Received: from pc638.lan (h5ef52e3d.seluork.dyn.perspektivbredband.net. [94.245.46.61]) by smtp.gmail.com with ESMTPSA id v130sm2870160lfa.283.2020.11.16.14.00.43 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 16 Nov 2020 14:00:44 -0800 (PST) From: "Uladzislau Rezki (Sony)" To: Andrew Morton Cc: linux-mm@kvack.org, LKML , Uladzislau Rezki , Hillf Danton , Michal Hocko , Matthew Wilcox , Oleksiy Avramchenko , Steven Rostedt Subject: [PATCH 1/2] mm/vmalloc: use free_vm_area() if an allocation fails Date: Mon, 16 Nov 2020 23:00:32 +0100 Message-Id: <20201116220033.1837-1-urezki@gmail.com> X-Mailer: git-send-email 2.20.1 MIME-Version: 1.0 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: There is a dedicated and separate function that finds and removes a continuous kernel virtual area. As a final step it also releases the "area", a descriptor of corresponding vm_struct. Use free_vmap_area() in the __vmalloc_node_range() instead of open coded steps which are exactly the same, to perform a cleanup. Signed-off-by: Uladzislau Rezki (Sony) --- mm/vmalloc.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/mm/vmalloc.c b/mm/vmalloc.c index d7075ad340aa..b08b06a8cc2a 100644 --- a/mm/vmalloc.c +++ b/mm/vmalloc.c @@ -2479,8 +2479,7 @@ static void *__vmalloc_area_node(struct vm_struct *area, gfp_t gfp_mask, } if (!pages) { - remove_vm_area(area->addr); - kfree(area); + free_vm_area(area); return NULL; }