From patchwork Tue Dec 15 03:03:24 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Andrew Morton X-Patchwork-Id: 11973609 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-15.7 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id E70C2C4361B for ; Tue, 15 Dec 2020 03:03:27 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 8164C223E0 for ; Tue, 15 Dec 2020 03:03:27 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 8164C223E0 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=linux-foundation.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id 12EAD6B0071; Mon, 14 Dec 2020 22:03:27 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 0E5B86B0072; Mon, 14 Dec 2020 22:03:27 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id F384E6B0073; Mon, 14 Dec 2020 22:03:26 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0254.hostedemail.com [216.40.44.254]) by kanga.kvack.org (Postfix) with ESMTP id DD9D86B0071 for ; Mon, 14 Dec 2020 22:03:26 -0500 (EST) Received: from smtpin28.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay04.hostedemail.com (Postfix) with ESMTP id B6BB11F06 for ; Tue, 15 Dec 2020 03:03:26 +0000 (UTC) X-FDA: 77594020812.28.hill37_1417b9327420 Received: from filter.hostedemail.com (10.5.16.251.rfc1918.com [10.5.16.251]) by smtpin28.hostedemail.com (Postfix) with ESMTP id 9C8FB6C3B for ; Tue, 15 Dec 2020 03:03:26 +0000 (UTC) X-HE-Tag: hill37_1417b9327420 X-Filterd-Recvd-Size: 2127 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by imf23.hostedemail.com (Postfix) with ESMTP for ; Tue, 15 Dec 2020 03:03:26 +0000 (UTC) Date: Mon, 14 Dec 2020 19:03:24 -0800 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linux-foundation.org; s=korg; t=1608001405; bh=NNKMgSsdowveW++tOUkrCtO2ywoW+rnZadFOgwlhzqU=; h=From:To:Subject:In-Reply-To:From; b=jMOgVjeq6UnRcyLBRoALjaTuP95HXSM0Si4b9fmn0Tugx0a56stdeqTnTkWK3zGsV l/wwG8/dHs/jNEDF1ipR/h3BapfcM/42+4+zMU5YLHmZLxhwImq8BmuldnAu+boqA+ QdJUX3H/4E2eUWuUuxGm8masc1iPzZDYMdXNbAEc= From: Andrew Morton To: akpm@linux-foundation.org, bigeasy@linutronix.de, davem@davemloft.net, linux-mm@kvack.org, mm-commits@vger.kernel.org, torvalds@linux-foundation.org Subject: [patch 004/200] ide/falcon: remove in_interrupt() usage Message-ID: <20201215030324.MDB_qxAgD%akpm@linux-foundation.org> In-Reply-To: <20201214190237.a17b70ae14f129e2dca3d204@linux-foundation.org> User-Agent: s-nail v14.8.16 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: From: Sebastian Andrzej Siewior Subject: ide/falcon: remove in_interrupt() usage falconide_get_lock() is called by ide_lock_host() and its caller (ide_issue_rq()) has already a might_sleep() check. stdma_lock() has wait_event() which also has a might_sleep() check. Remove the in_interrupt() check. Link: https://lkml.kernel.org/r/20201113161021.2217361-2-bigeasy@linutronix.de Signed-off-by: Sebastian Andrzej Siewior Cc: "David S. Miller" Signed-off-by: Andrew Morton --- drivers/ide/falconide.c | 2 -- 1 file changed, 2 deletions(-) --- a/drivers/ide/falconide.c~ide-falcon-remove-in_interrupt-usage +++ a/drivers/ide/falconide.c @@ -51,8 +51,6 @@ static void falconide_release_lock(void) static void falconide_get_lock(irq_handler_t handler, void *data) { if (falconide_intr_lock == 0) { - if (in_interrupt() > 0) - panic("Falcon IDE hasn't ST-DMA lock in interrupt"); stdma_lock(handler, data); falconide_intr_lock = 1; }