From patchwork Tue Dec 15 03:07:01 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Andrew Morton X-Patchwork-Id: 11973735 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-15.7 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 0ABECC4361B for ; Tue, 15 Dec 2020 03:07:07 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id B3FDE224BD for ; Tue, 15 Dec 2020 03:07:04 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org B3FDE224BD Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=linux-foundation.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id 521A48D0008; Mon, 14 Dec 2020 22:07:04 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 4D15F6B00AA; Mon, 14 Dec 2020 22:07:04 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 3C2EF8D0008; Mon, 14 Dec 2020 22:07:04 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0216.hostedemail.com [216.40.44.216]) by kanga.kvack.org (Postfix) with ESMTP id 1FB0C6B00A9 for ; Mon, 14 Dec 2020 22:07:04 -0500 (EST) Received: from smtpin08.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay05.hostedemail.com (Postfix) with ESMTP id DFF51181AEF2A for ; Tue, 15 Dec 2020 03:07:03 +0000 (UTC) X-FDA: 77594029926.08.girls45_0702b7f27420 Received: from filter.hostedemail.com (10.5.16.251.rfc1918.com [10.5.16.251]) by smtpin08.hostedemail.com (Postfix) with ESMTP id C76531819E624 for ; Tue, 15 Dec 2020 03:07:03 +0000 (UTC) X-HE-Tag: girls45_0702b7f27420 X-Filterd-Recvd-Size: 2623 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by imf50.hostedemail.com (Postfix) with ESMTP for ; Tue, 15 Dec 2020 03:07:03 +0000 (UTC) Date: Mon, 14 Dec 2020 19:07:01 -0800 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linux-foundation.org; s=korg; t=1608001622; bh=wxVQ2UH9eixlyaUjvqZXoBu5EOjef72HoyPwMKPUTqI=; h=From:To:Subject:In-Reply-To:From; b=N0pj2kyuGa50fU3DOv5oyxL5mjn6lv2jBgXe+uPCDbf6wWfhybuqxqvrPm+bkI9I/ kTeVs47jT6J1uHSFxI5PAZ/t9wRHey8PeDfpXN+EUF5YBvDM/SgUuxvCJRptlb0Ijd /oVK/Z2TWElI2F+DBM8Gud/ZjYQDwCdkvkpKGwIc= From: Andrew Morton To: akpm@linux-foundation.org, guro@fb.com, hannes@cmpxchg.org, linux-mm@kvack.org, lukas.bulwahn@gmail.com, mhocko@suse.com, mm-commits@vger.kernel.org, natechancellor@gmail.com, torvalds@linux-foundation.org Subject: [patch 067/200] mm: memcg: remove obsolete memcg_has_children() Message-ID: <20201215030701.qGriOT4tw%akpm@linux-foundation.org> In-Reply-To: <20201214190237.a17b70ae14f129e2dca3d204@linux-foundation.org> User-Agent: s-nail v14.8.16 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: From: Lukas Bulwahn Subject: mm: memcg: remove obsolete memcg_has_children() Commit 2ef1bf118c40 ("mm: memcg: deprecate the non-hierarchical mode") removed the only use of memcg_has_children() in mem_cgroup_hierarchy_write() as part of the feature deprecation. Hence, since then, make CC=clang W=1 warns: mm/memcontrol.c:3421:20: warning: unused function 'memcg_has_children' [-Wunused-function] Simply remove this obsolete unused function. Link: https://lkml.kernel.org/r/20201116055043.20886-1-lukas.bulwahn@gmail.com Signed-off-by: Lukas Bulwahn Acked-by: Roman Gushchin Reviewed-by: Nathan Chancellor Acked-by: Michal Hocko Cc: Johannes Weiner Signed-off-by: Andrew Morton --- mm/memcontrol.c | 13 ------------- 1 file changed, 13 deletions(-) --- a/mm/memcontrol.c~mm-memcg-remove-obsolete-memcg_has_children +++ a/mm/memcontrol.c @@ -3454,19 +3454,6 @@ unsigned long mem_cgroup_soft_limit_recl } /* - * Test whether @memcg has children, dead or alive. - */ -static inline bool memcg_has_children(struct mem_cgroup *memcg) -{ - bool ret; - - rcu_read_lock(); - ret = css_next_child(NULL, &memcg->css); - rcu_read_unlock(); - return ret; -} - -/* * Reclaims as many pages from the given memcg as possible. * * Caller is responsible for holding css reference for memcg.