From patchwork Tue Dec 15 03:07:10 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Andrew Morton X-Patchwork-Id: 11973741 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-15.7 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 017FDC4361B for ; Tue, 15 Dec 2020 03:07:14 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id A34C1223C8 for ; Tue, 15 Dec 2020 03:07:13 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org A34C1223C8 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=linux-foundation.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id 40FC18D000B; Mon, 14 Dec 2020 22:07:13 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 3C23E6B00AD; Mon, 14 Dec 2020 22:07:13 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 2B0148D000B; Mon, 14 Dec 2020 22:07:13 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0083.hostedemail.com [216.40.44.83]) by kanga.kvack.org (Postfix) with ESMTP id 0F8ED6B00AC for ; Mon, 14 Dec 2020 22:07:13 -0500 (EST) Received: from smtpin07.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay01.hostedemail.com (Postfix) with ESMTP id D77CF180AD830 for ; Tue, 15 Dec 2020 03:07:12 +0000 (UTC) X-FDA: 77594030304.07.plant52_2e06de427420 Received: from filter.hostedemail.com (10.5.16.251.rfc1918.com [10.5.16.251]) by smtpin07.hostedemail.com (Postfix) with ESMTP id C128D1803F9BD for ; Tue, 15 Dec 2020 03:07:12 +0000 (UTC) X-HE-Tag: plant52_2e06de427420 X-Filterd-Recvd-Size: 2057 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by imf17.hostedemail.com (Postfix) with ESMTP for ; Tue, 15 Dec 2020 03:07:12 +0000 (UTC) Date: Mon, 14 Dec 2020 19:07:10 -0800 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linux-foundation.org; s=korg; t=1608001631; bh=AzQoitgxucaSr0i+7rj2ck6mdTgUJM+muCbk06JTJr0=; h=From:To:Subject:In-Reply-To:From; b=bvuYnEIWa8XNa53aeZxis2ctPmOy6C9taDJgEBbmjrKVHFjz8qExntWyo2/ZrNqlJ Gm5U6D558Gn4mO1Zs2SbPRssdtES+M26+1ifrz3/8NReAWBd6gfHemJd1BJYaWYmhP heljGH923VTfjIE1LPVVF/b2kv0mx74MvSTN0DXc= From: Andrew Morton To: akpm@linux-foundation.org, alex.shi@linux.alibaba.com, hannes@cmpxchg.org, linux-mm@kvack.org, mhocko@kernel.org, mm-commits@vger.kernel.org, torvalds@linux-foundation.org, vdavydov.dev@gmail.com Subject: [patch 070/200] mm/memcg: remove incorrect comment Message-ID: <20201215030710.aPdVZvaxM%akpm@linux-foundation.org> In-Reply-To: <20201214190237.a17b70ae14f129e2dca3d204@linux-foundation.org> User-Agent: s-nail v14.8.16 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: From: Alex Shi Subject: mm/memcg: remove incorrect comment Swapcache readahead pages are charged before being used, so it is unlikely that they will be migrated before charging. Remove the incorrect comment. Link: https://lkml.kernel.org/r/1605864930-49405-1-git-send-email-alex.shi@linux.alibaba.com Signed-off-by: Alex Shi Cc: Johannes Weiner Cc: Michal Hocko Cc: Vladimir Davydov Signed-off-by: Andrew Morton --- mm/memcontrol.c | 1 - 1 file changed, 1 deletion(-) --- a/mm/memcontrol.c~mm-memcg-remove-incorrect-comments +++ a/mm/memcontrol.c @@ -6903,7 +6903,6 @@ void mem_cgroup_migrate(struct page *old if (newpage->mem_cgroup) return; - /* Swapcache readahead pages can get replaced before being charged */ memcg = oldpage->mem_cgroup; if (!memcg) return;