[180/200] userfaultfd: add user-mode only option to unprivileged_userfaultfd sysctl knob

Commit Message

Andrew Morton Dec. 15, 2020, 3:13 a.m. UTC

From: Lokesh Gidra <[e-mail]>
Subject: userfaultfd: add user-mode only option to unprivileged_userfaultfd sysctl knob

With this change, when the knob is set to 0, it allows unprivileged users
to call userfaultfd, like when it is set to 1, but with the restriction
that page faults from only user-mode can be handled.  In this mode, an
unprivileged user (without SYS_CAP_PTRACE capability) must pass
UFFD_USER_MODE_ONLY to userfaultd or the API will fail with EPERM.

This enables administrators to reduce the likelihood that an attacker with
access to userfaultfd can delay faulting kernel code to widen timing
windows for other exploits.

The default value of this knob is changed to 0.  This is required for
correct functioning of pipe mutex.  However, this will fail postcopy live
migration, which will be unnoticeable to the VM guests.  To avoid this,
set 'vm.userfault = 1' in /sys/sysctl.conf.

The main reason this change is desirable as in the short term is that the
Android userland will behave as with the sysctl set to zero.  So without
this commit, any Linux binary using userfaultfd to manage its memory would
behave differently if run within the Android userland.  For more details,
refer to Andrea's reply [1].

[1] https://lore.kernel.org/lkml/[e-mail]/

Link: https://lkml.kernel.org/r/[e-mail]
Signed-off-by: Lokesh Gidra <[e-mail]>
Reviewed-by: Andrea Arcangeli <[e-mail]>
Cc: Kees Cook <[e-mail]>
Cc: Jonathan Corbet <[e-mail]>
Cc: Peter Xu <[e-mail]>
Cc: Sebastian Andrzej Siewior <[e-mail]>
Cc: Alexander Viro <[e-mail]>
Cc: Stephen Smalley <[e-mail]>
Cc: Eric Biggers <[e-mail]>
Cc: Daniel Colascione <[e-mail]>
Cc: "Joel Fernandes (Google)" <[e-mail]>
Cc: Kalesh Singh <[e-mail]>
Cc: Suren Baghdasaryan <[e-mail]>
Cc: Jeff Vander Stoep <[e-mail]>
Cc: <[e-mail]>
Cc: Mike Rapoport <[e-mail]>
Cc: Shaohua Li <[e-mail]>
Cc: Jerome Glisse <[e-mail]>
Cc: Mauro Carvalho Chehab <[e-mail]>
Cc: Johannes Weiner <[e-mail]>
Cc: Mel Gorman <[e-mail]>
Cc: Nitin Gupta <[e-mail]>
Cc: Vlastimil Babka <[e-mail]>
Cc: Iurii Zaikin <[e-mail]>
Cc: Luis Chamberlain <[e-mail]>
Cc: Daniel Colascione <[e-mail]>
Signed-off-by: Andrew Morton <[e-mail]>
---

 Documentation/admin-guide/sysctl/vm.rst |   15 ++++++++++-----
 fs/userfaultfd.c                        |   10 ++++++++--
 2 files changed, 18 insertions(+), 7 deletions(-)

Patch

--- a/Documentation/admin-guide/sysctl/vm.rst~add-user-mode-only-option-to-unprivileged_userfaultfd-sysctl-knob
+++ a/Documentation/admin-guide/sysctl/vm.rst
@@ -873,12 +873,17 @@  file-backed pages is less than the high
 unprivileged_userfaultfd
 ========================
 
-This flag controls whether unprivileged users can use the userfaultfd
-system calls.  Set this to 1 to allow unprivileged users to use the
-userfaultfd system calls, or set this to 0 to restrict userfaultfd to only
-privileged users (with SYS_CAP_PTRACE capability).
+This flag controls the mode in which unprivileged users can use the
+userfaultfd system calls. Set this to 0 to restrict unprivileged users
+to handle page faults in user mode only. In this case, users without
+SYS_CAP_PTRACE must pass UFFD_USER_MODE_ONLY in order for userfaultfd to
+succeed. Prohibiting use of userfaultfd for handling faults from kernel
+mode may make certain vulnerabilities more difficult to exploit.
 
-The default value is 1.
+Set this to 1 to allow unprivileged users to use the userfaultfd system
+calls without any restrictions.
+
+The default value is 0.
 
 
 user_reserve_kbytes
--- a/fs/userfaultfd.c~add-user-mode-only-option-to-unprivileged_userfaultfd-sysctl-knob
+++ a/fs/userfaultfd.c
@@ -28,7 +28,7 @@ 
 #include <linux/security.h>
 #include <linux/hugetlb.h>
 
-int sysctl_unprivileged_userfaultfd __read_mostly = 1;
+int sysctl_unprivileged_userfaultfd __read_mostly;
 
 static struct kmem_cache *userfaultfd_ctx_cachep __read_mostly;
 
@@ -1966,8 +1966,14 @@  SYSCALL_DEFINE1(userfaultfd, int, flags)
 	struct userfaultfd_ctx *ctx;
 	int fd;
 
-	if (!sysctl_unprivileged_userfaultfd && !capable(CAP_SYS_PTRACE))
+	if (!sysctl_unprivileged_userfaultfd &&
+	    (flags & UFFD_USER_MODE_ONLY) == 0 &&
+	    !capable(CAP_SYS_PTRACE)) {
+		printk_once(KERN_WARNING "uffd: Set unprivileged_userfaultfd "
+			"sysctl knob to 1 if kernel faults must be handled "
+			"without obtaining CAP_SYS_PTRACE capability\n");
 		return -EPERM;
+	}
 
 	BUG_ON(!current->mm);