[11/19] mm/vmscan: remove lruvec reget in move_pages_to_lru

Commit Message

Andrew Morton Dec. 15, 2020, 10:20 p.m. UTC

From: Alex Shi <[e-mail]>
Subject: mm/vmscan: remove lruvec reget in move_pages_to_lru

Isolated page shouldn't be recharged by memcg since the memcg migration
isn't possible at the time.  All pages were isolated from the same lruvec
(and isolation inhibits memcg migration).  So remove unnecessary
regetting.

Thanks to Alexander Duyck for pointing this out.

Link: https://lkml.kernel.org/r/[e-mail]
Signed-off-by: Alex Shi <[e-mail]>
Acked-by: Hugh Dickins <[e-mail]>
Acked-by: Johannes Weiner <[e-mail]>
Cc: Konstantin Khlebnikov <[e-mail]>
Cc: Michal Hocko <[e-mail]>
Cc: Alexander Duyck <[e-mail]>
Cc: Andrea Arcangeli <[e-mail]>
Cc: Andrey Ryabinin <[e-mail]>
Cc: "Chen, Rong A" <[e-mail]>
Cc: Daniel Jordan <[e-mail]>
Cc: "Huang, Ying" <[e-mail]>
Cc: Jann Horn <[e-mail]>
Cc: Joonsoo Kim <[e-mail]>
Cc: Kirill A. Shutemov <[e-mail]>
Cc: Kirill A. Shutemov <[e-mail]>
Cc: Matthew Wilcox (Oracle) <[e-mail]>
Cc: Mel Gorman <[e-mail]>
Cc: Michal Hocko <[e-mail]>
Cc: Mika Penttilä <[e-mail]>
Cc: Minchan Kim <[e-mail]>
Cc: Shakeel Butt <[e-mail]>
Cc: Tejun Heo <[e-mail]>
Cc: Thomas Gleixner <[e-mail]>
Cc: Vladimir Davydov <[e-mail]>
Cc: Vlastimil Babka <[e-mail]>
Cc: Wei Yang <[e-mail]>
Cc: Yang Shi <[e-mail]>
Signed-off-by: Andrew Morton <[e-mail]>
---

 mm/vmscan.c |    7 ++++++-
 1 file changed, 6 insertions(+), 1 deletion(-)

Patch

--- a/mm/vmscan.c~mm-vmscan-remove-lruvec-reget-in-move_pages_to_lru
+++ a/mm/vmscan.c
@@ -1886,7 +1886,12 @@  static unsigned noinline_for_stack move_
 			continue;
 		}
 
-		lruvec = mem_cgroup_page_lruvec(page, pgdat);
+		/*
+		 * All pages were isolated from the same lruvec (and isolation
+		 * inhibits memcg migration).
+		 */
+		VM_BUG_ON_PAGE(mem_cgroup_page_lruvec(page, page_pgdat(page))
+							!= lruvec, page);
 		lru = page_lru(page);
 		nr_pages = thp_nr_pages(page);