From patchwork Wed Dec 16 05:52:13 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Hui Su X-Patchwork-Id: 11976669 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-12.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id D3BD3C4361B for ; Wed, 16 Dec 2020 05:54:20 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 446AA23340 for ; Wed, 16 Dec 2020 05:54:20 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 446AA23340 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=163.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id 6B04A6B006E; Wed, 16 Dec 2020 00:54:19 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 63A0A6B0070; Wed, 16 Dec 2020 00:54:19 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 4FF976B0071; Wed, 16 Dec 2020 00:54:19 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0014.hostedemail.com [216.40.44.14]) by kanga.kvack.org (Postfix) with ESMTP id 35CB16B006E for ; Wed, 16 Dec 2020 00:54:19 -0500 (EST) Received: from smtpin01.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay05.hostedemail.com (Postfix) with ESMTP id D95A5181AEF1E for ; Wed, 16 Dec 2020 05:54:18 +0000 (UTC) X-FDA: 77598080196.01.feet00_05006c627429 Received: from filter.hostedemail.com (10.5.16.251.rfc1918.com [10.5.16.251]) by smtpin01.hostedemail.com (Postfix) with ESMTP id B18A51004C798 for ; Wed, 16 Dec 2020 05:54:18 +0000 (UTC) X-HE-Tag: feet00_05006c627429 X-Filterd-Recvd-Size: 2983 Received: from m12-11.163.com (m12-11.163.com [220.181.12.11]) by imf47.hostedemail.com (Postfix) with ESMTP for ; Wed, 16 Dec 2020 05:54:08 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=163.com; s=s110527; h=Date:From:Subject:Message-ID:MIME-Version; bh=BBKRI TNFFT+q7yGvwOTx4/tWHfQzcYeyta5d1Cb3V68=; b=fB/bHrF7W+wEz0U0iVXbW ATCoPSFOK67Iehdh5ukdjw4pGkuhbuE8YfAlOWVvLKt+5hznZ0U6IHJGPO1vabp0 WbnGtiCpykUl6cS9IIOgcP7ZD6Qo9+8RUjfi9347z63Wx8y5d/vcgT0OeTN6CIWH xKzmE/1w/+8oGAFZC+kNDM= Received: from localhost (unknown [101.86.213.93]) by smtp7 (Coremail) with SMTP id C8CowACnLq+NoNlfePyaDw--.2553S2; Wed, 16 Dec 2020 13:52:13 +0800 (CST) Date: Wed, 16 Dec 2020 13:52:13 +0800 From: Hui Su To: hannes@cmpxchg.org, mhocko@kernel.org, vdavydov.dev@gmail.com, akpm@linux-foundation.org, cgroups@vger.kernel.org, linux-mm@kvack.org, linux-kernel@vger.kernel.org Cc: sh_def@163.com Subject: [PATCH] mm/memcontrol: remove the unnecessary rcu_read_[un]lock Message-ID: <20201216055213.GA63520@rlk> MIME-Version: 1.0 Content-Disposition: inline X-CM-TRANSID: C8CowACnLq+NoNlfePyaDw--.2553S2 X-Coremail-Antispam: 1Uf129KBjvJXoW7Kw1xXr4kJw1kKr4UAr1UJrb_yoW8GFW3pF sxKa47A398Xw1Ygr1Uua1Dur1xA3Wag3y7Zr1UJw48ZF13X3sag34UKF1fZr45ZFyIvrs8 ZrW5twnrAw42q3JanT9S1TB71UUUUU7qnTZGkaVYY2UrUUUUjbIjqfuFe4nvWSU5nxnvy2 9KBjDUYxBIdaVFxhVjvjDU0xZFpf9x07UjPfdUUUUU= X-Originating-IP: [101.86.213.93] X-CM-SenderInfo: xvkbvvri6rljoofrz/1tbiIA38X10TCh3tsAAAsK X-Bogosity: Ham, tests=bogofilter, spamicity=0.002356, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: the rcu_read_lock and rcu_read_unlock is unnecessary in: lock_page_lruvec() lock_page_lruvec_irq() lock_page_lruvec_irqsave() Signed-off-by: Hui Su --- mm/memcontrol.c | 6 ------ 1 file changed, 6 deletions(-) diff --git a/mm/memcontrol.c b/mm/memcontrol.c index e3c7ca7dc174..a19f820e8a3f 100644 --- a/mm/memcontrol.c +++ b/mm/memcontrol.c @@ -1396,10 +1396,8 @@ struct lruvec *lock_page_lruvec(struct page *page) struct lruvec *lruvec; struct pglist_data *pgdat = page_pgdat(page); - rcu_read_lock(); lruvec = mem_cgroup_page_lruvec(page, pgdat); spin_lock(&lruvec->lru_lock); - rcu_read_unlock(); lruvec_memcg_debug(lruvec, page); @@ -1411,10 +1409,8 @@ struct lruvec *lock_page_lruvec_irq(struct page *page) struct lruvec *lruvec; struct pglist_data *pgdat = page_pgdat(page); - rcu_read_lock(); lruvec = mem_cgroup_page_lruvec(page, pgdat); spin_lock_irq(&lruvec->lru_lock); - rcu_read_unlock(); lruvec_memcg_debug(lruvec, page); @@ -1426,10 +1422,8 @@ struct lruvec *lock_page_lruvec_irqsave(struct page *page, unsigned long *flags) struct lruvec *lruvec; struct pglist_data *pgdat = page_pgdat(page); - rcu_read_lock(); lruvec = mem_cgroup_page_lruvec(page, pgdat); spin_lock_irqsave(&lruvec->lru_lock, *flags); - rcu_read_unlock(); lruvec_memcg_debug(lruvec, page);