[v2,32/70] arch/powerpc: Optimize cell spu task sync.

Message ID	20210112161240.2024684-33-Liam.Howlett@Oracle.com (mailing list archive)
State	New, archived
Headers	show Return-Path: <SRS0=wefk=GP=kvack.org=owner-linux-mm@kernel.org> DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 132522222B From: "Liam R. Howlett" <Liam.Howlett@Oracle.com> To: maple-tree@lists.infradead.org, linux-mm@kvack.org, linux-kernel@vger.kernel.org Cc: Andrew Morton <akpm@google.com>, Song Liu <songliubraving@fb.com>, Davidlohr Bueso <dave@stgolabs.net>, "Paul E . McKenney" <paulmck@kernel.org>, Matthew Wilcox <willy@infradead.org>, Jerome Glisse <jglisse@redhat.com>, David Rientjes <rientjes@google.com>, Axel Rasmussen <axelrasmussen@google.com>, Suren Baghdasaryan <surenb@google.com>, Vlastimil Babka <vbabka@suse.cz>, Rik van Riel <riel@surriel.com>, Peter Zijlstra <peterz@infradead.org> Subject: [PATCH v2 32/70] arch/powerpc: Optimize cell spu task sync. Date: Tue, 12 Jan 2021 11:12:02 -0500 Message-Id: <20210112161240.2024684-33-Liam.Howlett@Oracle.com> In-Reply-To: <20210112161240.2024684-1-Liam.Howlett@Oracle.com> References: <20210112161240.2024684-1-Liam.Howlett@Oracle.com> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Sender: owner-linux-mm@kvack.org Precedence: bulk
Series	RFC mm: Introducing the Maple Tree \| expand [v2,00/70] RFC mm: Introducing the Maple Tree [v2,01/70] radix tree test suite: Enhancements for Maple Tree [v2,02/70] radix tree test suite: Add support for fallthrough attribute [v2,03/70] radix tree test suite: Add support for kmem_cache_free_bulk [v2,04/70] radix tree test suite: Add keme_cache_alloc_bulk() support [v2,05/70] Maple Tree: Add new data structure [v2,06/70] mm: Start tracking VMAs with maple tree [v2,07/70] mm/mmap: Introduce unlock_range() for code cleanup [v2,08/70] mm/mmap: Change find_vma() to use the maple tree [v2,09/70] mm/mmap: Change find_vma_prev() to use maple tree [v2,10/70] mm/mmap: Change unmapped_area and unmapped_area_topdown to use maple tree [v2,11/70] kernel/fork: Convert dup_mmap to use maple tree [v2,12/70] mm: Remove rb tree. [v2,13/70] mm/gup: Add mm_populate_vma() for use when the vma is known [v2,14/70] mm/mmap: Change do_brk_flags() to expand existing VMA and add do_brk_munmap() [v2,15/70] mm/mmap: Change vm_brk_flags() to use mm_populate_vma() [v2,16/70] mm: Move find_vma_intersection to mmap.c and change implementation to maple tree. [v2,17/70] mm/mmap: Change mmap_region to use maple tree state [v2,18/70] mm/mmap: Drop munmap_vma_range() [v2,19/70] mm: Remove vmacache [v2,20/70] mm/mmap: Change __do_munmap() to avoid unnecessary lookups. [v2,21/70] mm/mmap: Move mmap_region() below do_munmap() [v2,22/70] mm/mmap: Add do_mas_munmap() and wraper for __do_munmap() [v2,23/70] mmap: Use find_vma_intersection in do_mmap() for overlap [v2,24/70] mmap: Remove __do_munmap() in favour of do_mas_munmap() [v2,25/70] mm/mmap: Change do_brk_munmap() to use do_mas_align_munmap() [v2,26/70] mmap: make remove_vma_list() inline [v2,27/70] mm: Introduce vma_next() and vma_prev() [v2,28/70] arch/arm64: Remove mmap linked list from vdso. [v2,29/70] arch/parsic: Remove mmap linked list from kernel/cache [v2,30/70] arch/powerpc: Remove mmap linked list from mm/book2s32/tlb [v2,31/70] arch/powerpc: Remove mmap linked list from mm/book2s32/subpage_prot [v2,32/70] arch/powerpc: Optimize cell spu task sync. [v2,33/70] arch/s390: Use maple tree iterators instead of linked list. [v2,34/70] arch/um: Use maple tree iterators instead of linked list [v2,35/70] arch/x86: Use maple tree iterators for vdso/vma [v2,36/70] arch/xtensa: Use maple tree iterators for unmapped area [v2,37/70] drivers/misc/cxl: Use maple tree iterators for cxl_prefault_vma() [v2,38/70] drivers/oprofile: Lookup address in tree instead of linked list. [v2,39/70] drivers/tee/optee: Use maple tree iterators for __check_mem_type() [v2,40/70] fs/binfmt_elf: Use maple tree iterators for fill_files_note() [v2,41/70] fs/coredump: Use maple tree iterators in place of linked list [v2,42/70] fs/exec: Use vma_next() instead of linked list [v2,43/70] fs/proc/base: Use maple tree iterators in place of linked list [v2,44/70] fs/proc/task_mmu: Stop using linked list and highest_vm_end [v2,45/70] fs/userfaultfd: Stop using vma linked list. [v2,46/70] ipc/shm: Stop using the vma linked list [v2,47/70] kernel/acct: Use maple tree iterators instead of linked list [v2,48/70] kernel/events/core: Use maple tree iterators instead of linked list [v2,49/70] kernel/events/uprobes: Use maple tree iterators instead of linked list [v2,50/70] kernel/sched/fair: Use maple tree iterators instead of linked list [v2,51/70] kernel/sys: Use maple tree iterators instead of linked list [v2,52/70] mm/gup: Use maple tree navigation instead of linked list [v2,53/70] mm/huge_memory: Use vma_next() instead of vma linked list [v2,54/70] mm/khugepaged: Use maple tree iterators instead of vma linked list [v2,55/70] mm/ksm: Use maple tree iterators instead of vma linked list [v2,56/70] mm/madvise: Use vma_next instead of vma linked list [v2,57/70] mm/memcontrol: Stop using mm->highest_vm_end [v2,58/70] mm/mempolicy: Use maple tree iterators instead of vma linked list [v2,59/70] mm/mlock: Use maple tree iterators instead of vma linked list [v2,60/70] mm/mprotect: Use maple tree navigation instead of vma linked list [v2,61/70] mm/mremap: Use vma_next() instead of vma linked list [v2,62/70] mm/msync: Use vma_next() instead of vma linked list [v2,63/70] mm/nommu: Use maple tree iterators instead of vma linked list [v2,64/70] mm/oom_kill: Use maple tree iterators instead of vma linked list [v2,65/70] mm/pagewalk: Use vma_next() instead of vma linked list [v2,66/70] mm/swapfile: Use maple tree iterator instead of vma linked list [v2,67/70] mm/nommu: Stop inserting into the vma linked list [v2,68/70] mm/util: Remove __vma_link_list() and __vma_unlink_list() [v2,69/70] mm: Remove vma linked list. [v2,70/70] mm/mmap: Convert __insert_vm_struct to use mas, convert vma_link to use vma_mas_link()

Message ID

20210112161240.2024684-33-Liam.Howlett@Oracle.com (mailing list archive)

State

New, archived

Headers

DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 132522222B
From: "Liam R. Howlett" <Liam.Howlett@Oracle.com>
To: maple-tree@lists.infradead.org, linux-mm@kvack.org,
        linux-kernel@vger.kernel.org
Cc: Andrew Morton <akpm@google.com>, Song Liu <songliubraving@fb.com>,
        Davidlohr Bueso <dave@stgolabs.net>,
        "Paul E . McKenney" <paulmck@kernel.org>,
        Matthew Wilcox <willy@infradead.org>,
        Jerome Glisse <jglisse@redhat.com>,
        David Rientjes <rientjes@google.com>,
        Axel Rasmussen <axelrasmussen@google.com>,
        Suren Baghdasaryan <surenb@google.com>,
        Vlastimil Babka <vbabka@suse.cz>, Rik van Riel <riel@surriel.com>,
        Peter Zijlstra <peterz@infradead.org>
Subject: [PATCH v2 32/70] arch/powerpc: Optimize cell spu task sync.
Date: Tue, 12 Jan 2021 11:12:02 -0500
Message-Id: <20210112161240.2024684-33-Liam.Howlett@Oracle.com>
In-Reply-To: <20210112161240.2024684-1-Liam.Howlett@Oracle.com>
References: <20210112161240.2024684-1-Liam.Howlett@Oracle.com>
MIME-Version: 1.0
Content-Transfer-Encoding: quoted-printable
Sender: owner-linux-mm@kvack.org
Precedence: bulk

Series

RFC mm: Introducing the Maple Tree | expand

Commit Message

Liam R. Howlett Jan. 12, 2021, 4:12 p.m. UTC

Use the vma api to look up the spu reference instead of walking the linked list.

Signed-off-by: Liam R. Howlett <Liam.Howlett@Oracle.com>
---
 arch/powerpc/oprofile/cell/spu_task_sync.c | 22 ++++++++++------------
 1 file changed, 10 insertions(+), 12 deletions(-)

diff --git a/arch/powerpc/oprofile/cell/spu_task_sync.c b/arch/powerpc/oprofile/cell/spu_task_sync.c
index 489f993100d56..47b4d4e9b628d 100644
--- a/arch/powerpc/oprofile/cell/spu_task_sync.c
+++ b/arch/powerpc/oprofile/cell/spu_task_sync.c
@@ -333,19 +333,17 @@  get_exec_dcookie_and_offset(struct spu *spu, unsigned int *offsetp,
 	}
 
 	mmap_read_lock(mm);
-	for (vma = mm->mmap; vma; vma = vma->vm_next) {
-		if (vma->vm_start > spu_ref || vma->vm_end <= spu_ref)
-			continue;
-		my_offset = spu_ref - vma->vm_start;
-		if (!vma->vm_file)
-			goto fail_no_image_cookie;
-
-		pr_debug("Found spu ELF at %X(object-id:%lx) for file %pD\n",
-			 my_offset, spu_ref, vma->vm_file);
-		*offsetp = my_offset;
-		break;
-	}
+	vma = find_vma_intersection(mm, spu_ref, spu_ref + 1);
+	if (!vma)
+		goto fail_no_image_cookie;
+
+	my_offset = spu_ref - vma->vm_start;
+	if (!vma->vm_file)
+		goto fail_no_image_cookie;
 
+	pr_debug("Found spu ELF at %X(object-id:%lx) for file %pD\n",
+		 my_offset, spu_ref, vma->vm_file);
+	*offsetp = my_offset;
 	*spu_bin_dcookie = fast_get_dcookie(&vma->vm_file->f_path);
 	pr_debug("got dcookie for %pD\n", vma->vm_file);

[v2,32/70] arch/powerpc: Optimize cell spu task sync.

Commit Message

Patch