| Message ID | 20210115061349.67386-2-laoar.shao@gmail.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | mm: improve the output of print_page_info() | expand |
On 15.01.21 07:13, Yafang Shao wrote: > As pGp has been already introduced in printk, we'd better use it to make > the output human readable. > > Before this change, the output is, > [ 6155.716018] INFO: Slab 0x000000004027dd4f objects=33 used=3 fp=0x000000008cd1579c flags=0x17ffffc0010200 > > While after this change, the output is, > [ 8846.517809] INFO: Slab 0x00000000f42a2c60 objects=33 used=3 fp=0x0000000060d32ca8 flags=0x17ffffc0010200(slab|head) > > Signed-off-by: Yafang Shao <laoar.shao@gmail.com> > --- > mm/slub.c | 5 +++-- > 1 file changed, 3 insertions(+), 2 deletions(-) > > diff --git a/mm/slub.c b/mm/slub.c > index dc5b42e..901a45a 100644 > --- a/mm/slub.c > +++ b/mm/slub.c > @@ -641,8 +641,9 @@ void print_tracking(struct kmem_cache *s, void *object) > > static void print_page_info(struct page *page) > { > - pr_err("INFO: Slab 0x%p objects=%u used=%u fp=0x%p flags=0x%04lx\n", > - page, page->objects, page->inuse, page->freelist, page->flags); > + pr_err("INFO: Slab 0x%p objects=%u used=%u fp=0x%p flags=%#lx(%pGp)\n", > + page, page->objects, page->inuse, page->freelist, > + page->flags, &page->flags); > > } > > Sounds helpful to me. "pr_err" combined with "INFO" looks a little weird - "Oh my, something serious just happened!!!! - but, hey, just for your information ... " :) Reviewed-by: David Hildenbrand <david@redhat.com>
On Fri, Jan 15, 2021 at 4:47 PM David Hildenbrand <david@redhat.com> wrote: > > On 15.01.21 07:13, Yafang Shao wrote: > > As pGp has been already introduced in printk, we'd better use it to make > > the output human readable. > > > > Before this change, the output is, > > [ 6155.716018] INFO: Slab 0x000000004027dd4f objects=33 used=3 fp=0x000000008cd1579c flags=0x17ffffc0010200 > > > > While after this change, the output is, > > [ 8846.517809] INFO: Slab 0x00000000f42a2c60 objects=33 used=3 fp=0x0000000060d32ca8 flags=0x17ffffc0010200(slab|head) > > > > Signed-off-by: Yafang Shao <laoar.shao@gmail.com> > > --- > > mm/slub.c | 5 +++-- > > 1 file changed, 3 insertions(+), 2 deletions(-) > > > > diff --git a/mm/slub.c b/mm/slub.c > > index dc5b42e..901a45a 100644 > > --- a/mm/slub.c > > +++ b/mm/slub.c > > @@ -641,8 +641,9 @@ void print_tracking(struct kmem_cache *s, void *object) > > > > static void print_page_info(struct page *page) > > { > > - pr_err("INFO: Slab 0x%p objects=%u used=%u fp=0x%p flags=0x%04lx\n", > > - page, page->objects, page->inuse, page->freelist, page->flags); > > + pr_err("INFO: Slab 0x%p objects=%u used=%u fp=0x%p flags=%#lx(%pGp)\n", > > + page, page->objects, page->inuse, page->freelist, > > + page->flags, &page->flags); > > > > } > > > > > > Sounds helpful to me. > > "pr_err" combined with "INFO" looks a little weird - "Oh my, something > serious just happened!!!! - but, hey, just for your information ... " :) > Ah, it seems we should improve it. There are many pr_err("INFO) in mm/slub.c... I will change them all in a separate patch. > Reviewed-by: David Hildenbrand <david@redhat.com> Thanks for the review.
diff --git a/mm/slub.c b/mm/slub.c index dc5b42e..901a45a 100644 --- a/mm/slub.c +++ b/mm/slub.c @@ -641,8 +641,9 @@ void print_tracking(struct kmem_cache *s, void *object) static void print_page_info(struct page *page) { - pr_err("INFO: Slab 0x%p objects=%u used=%u fp=0x%p flags=0x%04lx\n", - page, page->objects, page->inuse, page->freelist, page->flags); + pr_err("INFO: Slab 0x%p objects=%u used=%u fp=0x%p flags=%#lx(%pGp)\n", + page, page->objects, page->inuse, page->freelist, + page->flags, &page->flags); }
As pGp has been already introduced in printk, we'd better use it to make the output human readable. Before this change, the output is, [ 6155.716018] INFO: Slab 0x000000004027dd4f objects=33 used=3 fp=0x000000008cd1579c flags=0x17ffffc0010200 While after this change, the output is, [ 8846.517809] INFO: Slab 0x00000000f42a2c60 objects=33 used=3 fp=0x0000000060d32ca8 flags=0x17ffffc0010200(slab|head) Signed-off-by: Yafang Shao <laoar.shao@gmail.com> --- mm/slub.c | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-)