diff mbox series

[2/2] mm: mremap: unlink anon_vmas when mremap with MREMAP_DONTUNMAP success

Message ID 20210119075126.3513154-2-lixinhai.lxh@gmail.com (mailing list archive)
State New
Headers show
Series [1/2] mm: rmap: explicitly reset vma->anon_vma in unlink_anon_vmas() | expand

Commit Message

Li Xinhai Jan. 19, 2021, 7:51 a.m. UTC
mremap with MREMAP_DONTUNMAP will move all page table entries to new vma,
which means all pages allocated for the old vma are not relevant to it
anymore, and the relevant anon_vma links needs to be unlinked, in nature
the old vma is much like been freshly created and have no pages been
fault in.

But we should not do unlink, if the new vma has effectively merged with
the old one.

Cc: Brian Geffon <bgeffon@google.com>
Cc: Lokesh Gidra <lokeshgidra@google.com>
Cc: Minchan Kim <minchan@kernel.org>
Cc: Kirill A. Shutemov <kirill.shutemov@linux.intel.com>
Cc: Vlastimil Babka <vbabka@suse.cz>
Cc: Andrea Arcangeli <aarcange@redhat.com>
Signed-off-by: Li Xinhai <lixinhai.lxh@gmail.com>
---
 mm/mremap.c | 7 +++++++
 1 file changed, 7 insertions(+)
diff mbox series

Patch

diff --git a/mm/mremap.c b/mm/mremap.c
index f554320281cc..7745b672e1a6 100644
--- a/mm/mremap.c
+++ b/mm/mremap.c
@@ -595,6 +595,13 @@  static unsigned long move_vma(struct vm_area_struct *vma,
 		/* We always clear VM_LOCKED[ONFAULT] on the old vma */
 		vma->vm_flags &= VM_LOCKED_CLEAR_MASK;
 
+		/*
+		 * anon_vma links of the old vma is no longer needed after its page
+		 * table has been moved.
+		 */
+		if (new_vma != vma)
+			unlink_anon_vmas(vma);
+
 		/* Because we won't unmap we don't need to touch locked_vm */
 		return new_addr;
 	}