From patchwork Mon Feb 1 11:56:09 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Yafang Shao X-Patchwork-Id: 12058849 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-13.5 required=3.0 tests=BAYES_00, DKIM_ADSP_CUSTOM_MED,DKIM_INVALID,DKIM_SIGNED,FREEMAIL_FORGED_FROMDOMAIN, FREEMAIL_FROM,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED, USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 1869FC433DB for ; Mon, 1 Feb 2021 11:57:07 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 955C564EA3 for ; Mon, 1 Feb 2021 11:57:06 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 955C564EA3 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=gmail.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id 145A96B0071; Mon, 1 Feb 2021 06:57:06 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 0CF296B0072; Mon, 1 Feb 2021 06:57:06 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id E8BC56B0073; Mon, 1 Feb 2021 06:57:05 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0122.hostedemail.com [216.40.44.122]) by kanga.kvack.org (Postfix) with ESMTP id D41D56B0071 for ; Mon, 1 Feb 2021 06:57:05 -0500 (EST) Received: from smtpin03.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay05.hostedemail.com (Postfix) with ESMTP id 9A4EC181AEF15 for ; Mon, 1 Feb 2021 11:57:05 +0000 (UTC) X-FDA: 77769548010.03.screw93_2403498275c2 Received: from filter.hostedemail.com (10.5.16.251.rfc1918.com [10.5.16.251]) by smtpin03.hostedemail.com (Postfix) with ESMTP id 7D2FF28A4E8 for ; Mon, 1 Feb 2021 11:57:05 +0000 (UTC) X-HE-Tag: screw93_2403498275c2 X-Filterd-Recvd-Size: 5831 Received: from mail-pj1-f46.google.com (mail-pj1-f46.google.com [209.85.216.46]) by imf20.hostedemail.com (Postfix) with ESMTP for ; Mon, 1 Feb 2021 11:57:04 +0000 (UTC) Received: by mail-pj1-f46.google.com with SMTP id s24so10146665pjp.5 for ; Mon, 01 Feb 2021 03:57:04 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=j9ylQWblYtnPRQvoph8wZjHjgqRFeyFluXHMnXSNEII=; b=Cgs5/WEVA1zE3HynJRWc9yOQHPVngA7hG6MVTwWqBpVLN3EQ0daP5cr/pFQ00U3F3H Ct+zTvg5uiFpQVsmCaOL7HWzU4SzvJBmsUd0g5YPGDt4SFnrH4sBjMjjISuEI8QdNWaJ OfWdwyosuqi4lISVDOCV6ogPjs911BjuQo1V5TCv7L9MgKucbHup40LG0uqnzzC7NrJb 2fhQ+LV5yfZyKY40YqWeGOM7PNvIULEB/Rpw+V28oiVRSEdpi7lGlwjxWT9Jgj6P1lMM 7J6vnMuALYbot0o34PhXbaz+dixJWyBYtm/m58rfcduSDgk8M62z5lS8KcaQxPVdLq5w 9fOg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=j9ylQWblYtnPRQvoph8wZjHjgqRFeyFluXHMnXSNEII=; b=G+twKvuDGNZ8XRZ5Ri4ejaCobaQgzhXXR3tKQ5expasV2EkPrfzgV/kxjRoAdKtIrM 5cwvn40c3dInIo7aXCzTefWs8j5Ryu4Y59Xm0bSd3M0ItBWMm+STyfg6UcbG4dSoXFu7 8zdnP+VLCtLnw3mzc57uWYXyiw0DNR2t+GmE8GuQL3HTCq8EK64oOoqBhShAreDw3TUa qwH2AQVUn0dXHpj0+is2MMUEfwB7kEFLr+PxR7SPjTiPov1w8rG2dcX3jeMeEgC3GVEP Za3fWjl3Ec9IYMeamZY7bvVpYmelbjzVopqGokH6S/VlpdJfA2ycNhr1LUhgfon0m5hU mFIQ== X-Gm-Message-State: AOAM530Nx/qhJKubvxLFIJRHaE2lZNTbijHdbvfJ/MX9CFnHP/ZVEK5v xsZfIDIW4L47lEp+DZfkk3Y= X-Google-Smtp-Source: ABdhPJyxqcsyP9BhzwpDIdlbYS1Ys5AUwk58ua/k09wfRuXbCCa0mq/TManxrwn+c2O4Eh8h/MtaCw== X-Received: by 2002:a17:90a:cb15:: with SMTP id z21mr7227873pjt.164.1612180623979; Mon, 01 Feb 2021 03:57:03 -0800 (PST) Received: from localhost.localdomain ([50.236.19.102]) by smtp.gmail.com with ESMTPSA id dw23sm7195152pjb.3.2021.02.01.03.56.57 (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Mon, 01 Feb 2021 03:57:03 -0800 (PST) From: Yafang Shao To: andriy.shevchenko@linux.intel.com, david@redhat.com, vbabka@suse.cz, linmiaohe@huawei.com, cl@linux.com, penberg@kernel.org, rientjes@google.com, iamjoonsoo.kim@lge.com, akpm@linux-foundation.org, pmladek@suse.com, rostedt@goodmis.org, sergey.senozhatsky@gmail.com, linux@rasmusvillemoes.dk Cc: linux-mm@kvack.org, linux-kernel@vger.kernel.org, Yafang Shao Subject: [PATCH v2 2/3] mm, slub: don't combine pr_err with INFO Date: Mon, 1 Feb 2021 19:56:09 +0800 Message-Id: <20210201115610.87808-3-laoar.shao@gmail.com> X-Mailer: git-send-email 2.24.3 (Apple Git-128) In-Reply-To: <20210201115610.87808-1-laoar.shao@gmail.com> References: <20210201115610.87808-1-laoar.shao@gmail.com> MIME-Version: 1.0 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: It is strange to combine "pr_err" with "INFO", so let's remove the prefix completely. This patch is motivated by David's comment[1]. - before the patch [ 8846.517809] INFO: Slab 0x00000000f42a2c60 objects=33 used=3 fp=0x0000000060d32ca8 flags=0x17ffffc0010200(slab|head) - after the patch [ 6343.396602] Slab 0x000000004382e02b objects=33 used=3 fp=0x000000009ae06ffc flags=0x17ffffc0010200(slab|head) [1]. https://lore.kernel.org/linux-mm/b9c0f2b6-e9b0-0c36-ebdd-2bc684c5a762@redhat.com/#t Suggested-by: Vlastimil Babka Cc: David Hildenbrand Signed-off-by: Yafang Shao --- mm/slub.c | 10 +++++----- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/mm/slub.c b/mm/slub.c index 87ff086e68a4..2514c37ab4e4 100644 --- a/mm/slub.c +++ b/mm/slub.c @@ -612,7 +612,7 @@ static void print_track(const char *s, struct track *t, unsigned long pr_time) if (!t->addr) return; - pr_err("INFO: %s in %pS age=%lu cpu=%u pid=%d\n", + pr_err("%s in %pS age=%lu cpu=%u pid=%d\n", s, (void *)t->addr, pr_time - t->when, t->cpu, t->pid); #ifdef CONFIG_STACKTRACE { @@ -638,7 +638,7 @@ void print_tracking(struct kmem_cache *s, void *object) static void print_page_info(struct page *page) { - pr_err("INFO: Slab 0x%p objects=%u used=%u fp=0x%p flags=%#lx(%pGp)\n", + pr_err("Slab 0x%p objects=%u used=%u fp=0x%p flags=%#lx(%pGp)\n", page, page->objects, page->inuse, page->freelist, page->flags, &page->flags); @@ -695,7 +695,7 @@ static void print_trailer(struct kmem_cache *s, struct page *page, u8 *p) print_page_info(page); - pr_err("INFO: Object 0x%p @offset=%tu fp=0x%p\n\n", + pr_err("Object 0x%p @offset=%tu fp=0x%p\n\n", p, p - addr, get_freepointer(s, p)); if (s->flags & SLAB_RED_ZONE) @@ -788,7 +788,7 @@ static int check_bytes_and_report(struct kmem_cache *s, struct page *page, end--; slab_bug(s, "%s overwritten", what); - pr_err("INFO: 0x%p-0x%p @offset=%tu. First byte 0x%x instead of 0x%x\n", + pr_err("0x%p-0x%p @offset=%tu. First byte 0x%x instead of 0x%x\n", fault, end - 1, fault - addr, fault[0], value); print_trailer(s, page, object); @@ -3854,7 +3854,7 @@ static void list_slab_objects(struct kmem_cache *s, struct page *page, for_each_object(p, s, addr, page->objects) { if (!test_bit(__obj_to_index(s, addr, p), map)) { - pr_err("INFO: Object 0x%p @offset=%tu\n", p, p - addr); + pr_err("Object 0x%p @offset=%tu\n", p, p - addr); print_tracking(s, p); } }