From patchwork Wed Feb 3 17:20:34 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Yang Shi X-Patchwork-Id: 12064885 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-13.5 required=3.0 tests=BAYES_00, DKIM_ADSP_CUSTOM_MED,DKIM_INVALID,DKIM_SIGNED,FREEMAIL_FORGED_FROMDOMAIN, FREEMAIL_FROM,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 57CE7C433DB for ; Wed, 3 Feb 2021 17:21:12 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id B5B0564F92 for ; Wed, 3 Feb 2021 17:21:11 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org B5B0564F92 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=gmail.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id 3395F6B0070; Wed, 3 Feb 2021 12:21:11 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 29AE86B0071; Wed, 3 Feb 2021 12:21:11 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 18A966B0072; Wed, 3 Feb 2021 12:21:11 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0053.hostedemail.com [216.40.44.53]) by kanga.kvack.org (Postfix) with ESMTP id F42106B0070 for ; Wed, 3 Feb 2021 12:21:10 -0500 (EST) Received: from smtpin21.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay01.hostedemail.com (Postfix) with ESMTP id B8451180AD822 for ; Wed, 3 Feb 2021 17:21:10 +0000 (UTC) X-FDA: 77777622300.21.2382ABC Received: from mail-pf1-f173.google.com (mail-pf1-f173.google.com [209.85.210.173]) by imf03.hostedemail.com (Postfix) with ESMTP id 2C4C5C000C4E for ; Wed, 3 Feb 2021 17:21:08 +0000 (UTC) Received: by mail-pf1-f173.google.com with SMTP id o20so272425pfu.0 for ; Wed, 03 Feb 2021 09:21:09 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=0bFxTF/fV4lUiN+s4AG3CM0LDtyH0oMQ5dQsmLRqP1s=; b=cF9bUgmWRIFWkWywVBfWjyk3eYjGnd+C3QQJJQ429Ohbfhz4RMjMXDJYmRQWzPLRxo DP1bvqrQ4E5QQiUdFn8vgOVZJiPdbEEfH5Ejak4tBOPi091dHewFQX2tEE67nKjoKb+i p4pdIj/RQfrCbIQTIfUB9JmtANB/k4OjATh1Tb5KIqiNUIQ6xdiBILHCEnp8gXDMRMNr dF7RiPXNoomwPlUVR0eq8bWVh8LjJhD8aI6w4HARvGZKP5dJCrGdxEV9W8iUaVwCA38T FxUCb1UywDlLDwvrsD11hFtOXXVr7pTEfXpvgSWqiUtjTZYaA6gvuu2iB5s0EtaGV/ve voaA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=0bFxTF/fV4lUiN+s4AG3CM0LDtyH0oMQ5dQsmLRqP1s=; b=UDaplwhVDXqXnt7DuM0jfJFc6SHbcXz7HLp9Bx4I/YtBUCy0wpotqleD1I2LumzGJl mAf3n8w+8zJKQUsz9eEUTqXKMyVbwrx6af+Xf/1psrWV7h12ZpWWGCy5IGAYuDmqEjFh KIowJvMMmv6lJoYfV5zVJfwkDjvEclU6OSr18LdgS+uWUq15JaywMOABR0HYRMf1Q+nA Qv/OwaJBIY5T/Qhs6PBgvJ64IpKSqgfNW53kuaT3Xzj2EBGhgtcRmRxHSgs+9RhGvlMf fpqAH7DdhuuDeF8qgTr5veLAUNHcljwA9LWLwrgSDpP/wrMiPZQbBrtDcPc/nh+B9PU2 ustQ== X-Gm-Message-State: AOAM5337yd+ycZ1fAj3ASYYf9qWiEKTfc/yge0d/do2ocq9HAtyMybYp 1EJT8pML/EkAMQP27OeQXh8= X-Google-Smtp-Source: ABdhPJyFn1IB5V7R9cYm0jM5l0K5a2g7aBSrAi+GhAnFcb0PnNL5kNoBuaHVMv7Ok8iEy1DWiX5QzA== X-Received: by 2002:a63:1f45:: with SMTP id q5mr4657962pgm.414.1612372868943; Wed, 03 Feb 2021 09:21:08 -0800 (PST) Received: from localhost.localdomain (c-73-93-239-127.hsd1.ca.comcast.net. [73.93.239.127]) by smtp.gmail.com with ESMTPSA id x21sm2368636pfn.100.2021.02.03.09.21.06 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 03 Feb 2021 09:21:07 -0800 (PST) From: Yang Shi To: guro@fb.com, ktkhai@virtuozzo.com, vbabka@suse.cz, shakeelb@google.com, david@fromorbit.com, hannes@cmpxchg.org, mhocko@suse.com, akpm@linux-foundation.org Cc: shy828301@gmail.com, linux-mm@kvack.org, linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [v6 PATCH 03/11] mm: vmscan: use shrinker_rwsem to protect shrinker_maps allocation Date: Wed, 3 Feb 2021 09:20:34 -0800 Message-Id: <20210203172042.800474-4-shy828301@gmail.com> X-Mailer: git-send-email 2.26.2 In-Reply-To: <20210203172042.800474-1-shy828301@gmail.com> References: <20210203172042.800474-1-shy828301@gmail.com> MIME-Version: 1.0 X-Rspamd-Server: rspam01 X-Rspamd-Queue-Id: 2C4C5C000C4E X-Stat-Signature: 4x84nm9zt1zx19zxu41f5xcmg7xuu4e4 Received-SPF: none (gmail.com>: No applicable sender policy available) receiver=imf03; identity=mailfrom; envelope-from=""; helo=mail-pf1-f173.google.com; client-ip=209.85.210.173 X-HE-DKIM-Result: pass/pass X-HE-Tag: 1612372868-10989 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: Since memcg_shrinker_map_size just can be changed under holding shrinker_rwsem exclusively, the read side can be protected by holding read lock, so it sounds superfluous to have a dedicated mutex. Kirill Tkhai suggested use write lock since: * We want the assignment to shrinker_maps is visible for shrink_slab_memcg(). * The rcu_dereference_protected() dereferrencing in shrink_slab_memcg(), but in case of we use READ lock in alloc_shrinker_maps(), the dereferrencing is not actually protected. * READ lock makes alloc_shrinker_info() racy against memory allocation fail. alloc_shrinker_info()->free_shrinker_info() may free memory right after shrink_slab_memcg() dereferenced it. You may say shrink_slab_memcg()->mem_cgroup_online() protects us from it? Yes, sure, but this is not the thing we want to remember in the future, since this spreads modularity. And a test with heavy paging workload didn't show write lock makes things worse. Acked-by: Vlastimil Babka Signed-off-by: Yang Shi Acked-by: Kirill Tkhai --- mm/vmscan.c | 16 ++++++---------- 1 file changed, 6 insertions(+), 10 deletions(-) diff --git a/mm/vmscan.c b/mm/vmscan.c index 96b08c79f18d..e4ddaaaeffe2 100644 --- a/mm/vmscan.c +++ b/mm/vmscan.c @@ -187,7 +187,6 @@ static DECLARE_RWSEM(shrinker_rwsem); #ifdef CONFIG_MEMCG static int memcg_shrinker_map_size; -static DEFINE_MUTEX(memcg_shrinker_map_mutex); static void free_shrinker_map_rcu(struct rcu_head *head) { @@ -200,8 +199,6 @@ static int expand_one_shrinker_map(struct mem_cgroup *memcg, struct memcg_shrinker_map *new, *old; int nid; - lockdep_assert_held(&memcg_shrinker_map_mutex); - for_each_node(nid) { old = rcu_dereference_protected( mem_cgroup_nodeinfo(memcg, nid)->shrinker_map, true); @@ -249,7 +246,7 @@ int alloc_shrinker_maps(struct mem_cgroup *memcg) if (mem_cgroup_is_root(memcg)) return 0; - mutex_lock(&memcg_shrinker_map_mutex); + down_write(&shrinker_rwsem); size = memcg_shrinker_map_size; for_each_node(nid) { map = kvzalloc_node(sizeof(*map) + size, GFP_KERNEL, nid); @@ -260,7 +257,7 @@ int alloc_shrinker_maps(struct mem_cgroup *memcg) } rcu_assign_pointer(memcg->nodeinfo[nid]->shrinker_map, map); } - mutex_unlock(&memcg_shrinker_map_mutex); + up_write(&shrinker_rwsem); return ret; } @@ -275,9 +272,8 @@ static int expand_shrinker_maps(int new_id) if (size <= old_size) return 0; - mutex_lock(&memcg_shrinker_map_mutex); if (!root_mem_cgroup) - goto unlock; + goto out; memcg = mem_cgroup_iter(NULL, NULL, NULL); do { @@ -286,13 +282,13 @@ static int expand_shrinker_maps(int new_id) ret = expand_one_shrinker_map(memcg, size, old_size); if (ret) { mem_cgroup_iter_break(NULL, memcg); - goto unlock; + goto out; } } while ((memcg = mem_cgroup_iter(NULL, memcg, NULL)) != NULL); -unlock: +out: if (!ret) memcg_shrinker_map_size = size; - mutex_unlock(&memcg_shrinker_map_mutex); + return ret; }