| Message ID | 20210208101439.55474-2-laoar.shao@gmail.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | mm, vsprintf: introduce new format to dump full information of page flags | expand |
On Mon, Feb 08, 2021 at 06:14:37PM +0800, Yafang Shao wrote: > As pGp has been already introduced in printk, we'd better use it to make > the output human readable. > > Before this change, the output is, > [ 6155.716018] INFO: Slab 0x000000004027dd4f objects=33 used=3 fp=0x000000008cd1579c flags=0x17ffffc0010200 > > While after this change, the output is, > [ 8846.517809] INFO: Slab 0x00000000f42a2c60 objects=33 used=3 fp=0x0000000060d32ca8 flags=0x17ffffc0010200(slab|head) > > Reviewed-by: David Hildenbrand <david@redhat.com> > Reviewed-by: Vlastimil Babka <vbabka@suse.cz> > Acked-by: David Rientjes <rientjes@google.com> > Acked-by: Christoph Lameter <cl@linux.com> > Signed-off-by: Yafang Shao <laoar.shao@gmail.com> Reviewed-by: Matthew Wilcox (Oracle) <willy@infradead.org>
On 2021/2/8 18:14, Yafang Shao wrote: > As pGp has been already introduced in printk, we'd better use it to make > the output human readable. > > Before this change, the output is, > [ 6155.716018] INFO: Slab 0x000000004027dd4f objects=33 used=3 fp=0x000000008cd1579c flags=0x17ffffc0010200 > > While after this change, the output is, > [ 8846.517809] INFO: Slab 0x00000000f42a2c60 objects=33 used=3 fp=0x0000000060d32ca8 flags=0x17ffffc0010200(slab|head) > > Reviewed-by: David Hildenbrand <david@redhat.com> > Reviewed-by: Vlastimil Babka <vbabka@suse.cz> > Acked-by: David Rientjes <rientjes@google.com> > Acked-by: Christoph Lameter <cl@linux.com> > Signed-off-by: Yafang Shao <laoar.shao@gmail.com> LGTM. Thanks. Reviewed-by: Miaohe Lin <linmiaohe@huawei.com> > --- > mm/slub.c | 5 +++-- > 1 file changed, 3 insertions(+), 2 deletions(-) > > diff --git a/mm/slub.c b/mm/slub.c > index 34dcc09e2ec9..87ff086e68a4 100644 > --- a/mm/slub.c > +++ b/mm/slub.c > @@ -638,8 +638,9 @@ void print_tracking(struct kmem_cache *s, void *object) > > static void print_page_info(struct page *page) > { > - pr_err("INFO: Slab 0x%p objects=%u used=%u fp=0x%p flags=0x%04lx\n", > - page, page->objects, page->inuse, page->freelist, page->flags); > + pr_err("INFO: Slab 0x%p objects=%u used=%u fp=0x%p flags=%#lx(%pGp)\n", > + page, page->objects, page->inuse, page->freelist, > + page->flags, &page->flags); > > } > >
diff --git a/mm/slub.c b/mm/slub.c index 34dcc09e2ec9..87ff086e68a4 100644 --- a/mm/slub.c +++ b/mm/slub.c @@ -638,8 +638,9 @@ void print_tracking(struct kmem_cache *s, void *object) static void print_page_info(struct page *page) { - pr_err("INFO: Slab 0x%p objects=%u used=%u fp=0x%p flags=0x%04lx\n", - page, page->objects, page->inuse, page->freelist, page->flags); + pr_err("INFO: Slab 0x%p objects=%u used=%u fp=0x%p flags=%#lx(%pGp)\n", + page, page->objects, page->inuse, page->freelist, + page->flags, &page->flags); }