From patchwork Tue Feb 9 10:56:12 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Yafang Shao X-Patchwork-Id: 12077759 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-13.5 required=3.0 tests=BAYES_00, DKIM_ADSP_CUSTOM_MED,DKIM_INVALID,DKIM_SIGNED,FREEMAIL_FORGED_FROMDOMAIN, FREEMAIL_FROM,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED, USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 48937C433DB for ; Tue, 9 Feb 2021 10:56:51 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id ABA0264EBA for ; Tue, 9 Feb 2021 10:56:50 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org ABA0264EBA Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=gmail.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id 27DBD6B006E; Tue, 9 Feb 2021 05:56:50 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 22E7D6B0070; Tue, 9 Feb 2021 05:56:50 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 144666B0071; Tue, 9 Feb 2021 05:56:50 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0195.hostedemail.com [216.40.44.195]) by kanga.kvack.org (Postfix) with ESMTP id F19586B006E for ; Tue, 9 Feb 2021 05:56:49 -0500 (EST) Received: from smtpin06.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay03.hostedemail.com (Postfix) with ESMTP id BA0DD8248047 for ; Tue, 9 Feb 2021 10:56:49 +0000 (UTC) X-FDA: 77798426538.06.game53_200e6ce27606 Received: from filter.hostedemail.com (10.5.16.251.rfc1918.com [10.5.16.251]) by smtpin06.hostedemail.com (Postfix) with ESMTP id 9958A100470D4 for ; Tue, 9 Feb 2021 10:56:49 +0000 (UTC) X-HE-Tag: game53_200e6ce27606 X-Filterd-Recvd-Size: 5979 Received: from mail-oi1-f178.google.com (mail-oi1-f178.google.com [209.85.167.178]) by imf40.hostedemail.com (Postfix) with ESMTP for ; Tue, 9 Feb 2021 10:56:48 +0000 (UTC) Received: by mail-oi1-f178.google.com with SMTP id l3so9013690oii.2 for ; Tue, 09 Feb 2021 02:56:48 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=o7q2vgd6GPGmGunsWTVUHI10pMlkl28NmpYlDYf/aRo=; b=fwCut5Niql0JG94VzPHt09KL8mT5vyceC3jqm+dWNCWohVILFNLFGFLCXMrvB9PAZh uM7mkHXr318esVxiFuZqu+0B+jwSWJEHyn5H2AR42VpwHrpgnNCsjMLlnOFOusgt+TXn gs3zT04Z6BlhZj6obXNi2hq7TfpBDIwbuFANtTuUiGMqYspoJYkmmT9439klI+MKU4/9 t5zwexVRGA54bgBYGxk4tIMibzvl+8F/fgH3hbLRkT6RIB86zqoXxLF2cAUq0W1W63Ug oo/uAhnHM9Knr2A2ojDHe6+RCTOxlj7iev8xQyWgYPBlUl72u9b0KPep0jkbDKQWNJ6V QLGw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=o7q2vgd6GPGmGunsWTVUHI10pMlkl28NmpYlDYf/aRo=; b=TCy4QZKYm27tZ+BZZXJ/iAh6ZWp8Fw3HpEw8DBACbgcMb8PQNZ3RABC7QK7kkUIhXO pOj9wD5YFJ9sqvGFJ2iy7WC5TnhXqE28kulU2w0ITzWSTjUvzevILSbHIXPFwC6y1x6I RK4fuGpsA9Lo5sh+8vpzJ6UpR0baQA8TF8Xwh5uhq1QdPef/nLCT346VIkeJNSJCAKEZ 9BewkxPfnAJe87wckcP1vXTs6cCWlaNKPbysUN2wt3zHj3p1jFxJxO0FwVgNnfF8UhUh 3QEQs9S+Jd3BmQCGvmIrBvyO0yYtQ3pIm8AsmcXhRxoaMJbeFzFuiuG7jYONGVg7UFVr nRNw== X-Gm-Message-State: AOAM532p/f/6N01DbDTLhR7l+C/DjZvXtqd0aO+44D1UAp2u0ngEKAuk t+dPw6SLPzevHWCrzzJF8ZA= X-Google-Smtp-Source: ABdhPJyLW5f385Naxy45QhOOjhIEed19clGHeM7+L/mh+Irh7umoNKaBJP8mOGifb1aZByaSIGYkrw== X-Received: by 2002:a05:6808:21a:: with SMTP id l26mr1987055oie.42.1612868208449; Tue, 09 Feb 2021 02:56:48 -0800 (PST) Received: from localhost.localdomain ([50.236.19.102]) by smtp.gmail.com with ESMTPSA id g3sm4171377ooi.28.2021.02.09.02.56.42 (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Tue, 09 Feb 2021 02:56:47 -0800 (PST) From: Yafang Shao To: willy@infradead.org, andriy.shevchenko@linux.intel.com, david@redhat.com, linmiaohe@huawei.com, vbabka@suse.cz, cl@linux.com, penberg@kernel.org, rientjes@google.com, iamjoonsoo.kim@lge.com, akpm@linux-foundation.org, pmladek@suse.com, rostedt@goodmis.org, sergey.senozhatsky@gmail.com, joe@perches.com Cc: linux-mm@kvack.org, linux-kernel@vger.kernel.org, Yafang Shao Subject: [PATCH v4 2/3] mm, slub: don't combine pr_err with INFO Date: Tue, 9 Feb 2021 18:56:12 +0800 Message-Id: <20210209105613.42747-3-laoar.shao@gmail.com> X-Mailer: git-send-email 2.24.3 (Apple Git-128) In-Reply-To: <20210209105613.42747-1-laoar.shao@gmail.com> References: <20210209105613.42747-1-laoar.shao@gmail.com> MIME-Version: 1.0 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: It is strange to combine "pr_err" with "INFO", so let's remove the prefix completely. This patch is motivated by David's comment[1]. - before the patch [ 8846.517809] INFO: Slab 0x00000000f42a2c60 objects=33 used=3 fp=0x0000000060d32ca8 flags=0x17ffffc0010200(slab|head) - after the patch [ 6343.396602] Slab 0x000000004382e02b objects=33 used=3 fp=0x000000009ae06ffc flags=0x17ffffc0010200(slab|head) [1]. https://lore.kernel.org/linux-mm/b9c0f2b6-e9b0-0c36-ebdd-2bc684c5a762@redhat.com/#t Suggested-by: Vlastimil Babka Signed-off-by: Yafang Shao Acked-by: Vlastimil Babka Reviewed-by: Miaohe Lin Cc: David Hildenbrand Cc: Matthew Wilcox Reviewed-by: David Hildenbrand --- mm/slub.c | 10 +++++----- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/mm/slub.c b/mm/slub.c index 87ff086e68a4..2514c37ab4e4 100644 --- a/mm/slub.c +++ b/mm/slub.c @@ -612,7 +612,7 @@ static void print_track(const char *s, struct track *t, unsigned long pr_time) if (!t->addr) return; - pr_err("INFO: %s in %pS age=%lu cpu=%u pid=%d\n", + pr_err("%s in %pS age=%lu cpu=%u pid=%d\n", s, (void *)t->addr, pr_time - t->when, t->cpu, t->pid); #ifdef CONFIG_STACKTRACE { @@ -638,7 +638,7 @@ void print_tracking(struct kmem_cache *s, void *object) static void print_page_info(struct page *page) { - pr_err("INFO: Slab 0x%p objects=%u used=%u fp=0x%p flags=%#lx(%pGp)\n", + pr_err("Slab 0x%p objects=%u used=%u fp=0x%p flags=%#lx(%pGp)\n", page, page->objects, page->inuse, page->freelist, page->flags, &page->flags); @@ -695,7 +695,7 @@ static void print_trailer(struct kmem_cache *s, struct page *page, u8 *p) print_page_info(page); - pr_err("INFO: Object 0x%p @offset=%tu fp=0x%p\n\n", + pr_err("Object 0x%p @offset=%tu fp=0x%p\n\n", p, p - addr, get_freepointer(s, p)); if (s->flags & SLAB_RED_ZONE) @@ -788,7 +788,7 @@ static int check_bytes_and_report(struct kmem_cache *s, struct page *page, end--; slab_bug(s, "%s overwritten", what); - pr_err("INFO: 0x%p-0x%p @offset=%tu. First byte 0x%x instead of 0x%x\n", + pr_err("0x%p-0x%p @offset=%tu. First byte 0x%x instead of 0x%x\n", fault, end - 1, fault - addr, fault[0], value); print_trailer(s, page, object); @@ -3854,7 +3854,7 @@ static void list_slab_objects(struct kmem_cache *s, struct page *page, for_each_object(p, s, addr, page->objects) { if (!test_bit(__obj_to_index(s, addr, p), map)) { - pr_err("INFO: Object 0x%p @offset=%tu\n", p, p - addr); + pr_err("Object 0x%p @offset=%tu\n", p, p - addr); print_tracking(s, p); } }