| Message ID | 20210224040439.351882-1-mike.kravetz@oracle.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | hugetlb: document the new location of page subpool pointer | expand |
On Tue, Feb 23, 2021 at 08:04:39PM -0800, Mike Kravetz wrote: > Expand comments, no functional change. > > Signed-off-by: Mike Kravetz <mike.kravetz@oracle.com> Reviewed-by: Oscar Salvador <osalvador@suse.de> Thanks > --- > include/linux/hugetlb.h | 3 +++ > 1 file changed, 3 insertions(+) > > diff --git a/include/linux/hugetlb.h b/include/linux/hugetlb.h > index cccd1aab69dd..c0467a7a1fe0 100644 > --- a/include/linux/hugetlb.h > +++ b/include/linux/hugetlb.h > @@ -476,6 +476,9 @@ unsigned long hugetlb_get_unmapped_area(struct file *file, unsigned long addr, > * huegtlb page specific state flags. These flags are located in page.private > * of the hugetlb head page. Functions created via the below macros should be > * used to manipulate these flags. > + * Note: The hugetlb page subpool pointer previously located at page.private > + * was moved to page[1].private to make room for flags in the head page. See > + * hugetlb_page_subpool(). > * > * HPG_restore_reserve - Set when a hugetlb page consumes a reservation at > * allocation time. Cleared when page is fully instantiated. Free > -- > 2.29.2 > >
On Wed, Feb 24, 2021 at 12:04 PM Mike Kravetz <mike.kravetz@oracle.com> wrote: > > Expand comments, no functional change. > > Signed-off-by: Mike Kravetz <mike.kravetz@oracle.com> Reviewed-by: Muchun Song <songmuchun@bytedance.com> Thanks > --- > include/linux/hugetlb.h | 3 +++ > 1 file changed, 3 insertions(+) > > diff --git a/include/linux/hugetlb.h b/include/linux/hugetlb.h > index cccd1aab69dd..c0467a7a1fe0 100644 > --- a/include/linux/hugetlb.h > +++ b/include/linux/hugetlb.h > @@ -476,6 +476,9 @@ unsigned long hugetlb_get_unmapped_area(struct file *file, unsigned long addr, > * huegtlb page specific state flags. These flags are located in page.private > * of the hugetlb head page. Functions created via the below macros should be > * used to manipulate these flags. > + * Note: The hugetlb page subpool pointer previously located at page.private > + * was moved to page[1].private to make room for flags in the head page. See > + * hugetlb_page_subpool(). > * > * HPG_restore_reserve - Set when a hugetlb page consumes a reservation at > * allocation time. Cleared when page is fully instantiated. Free > -- > 2.29.2 >
On 24.02.21 05:04, Mike Kravetz wrote: > Expand comments, no functional change. > > Signed-off-by: Mike Kravetz <mike.kravetz@oracle.com> > --- > include/linux/hugetlb.h | 3 +++ > 1 file changed, 3 insertions(+) > > diff --git a/include/linux/hugetlb.h b/include/linux/hugetlb.h > index cccd1aab69dd..c0467a7a1fe0 100644 > --- a/include/linux/hugetlb.h > +++ b/include/linux/hugetlb.h > @@ -476,6 +476,9 @@ unsigned long hugetlb_get_unmapped_area(struct file *file, unsigned long addr, > * huegtlb page specific state flags. These flags are located in page.private > * of the hugetlb head page. Functions created via the below macros should be > * used to manipulate these flags. > + * Note: The hugetlb page subpool pointer previously located at page.private > + * was moved to page[1].private to make room for flags in the head page. See > + * hugetlb_page_subpool(). > * > * HPG_restore_reserve - Set when a hugetlb page consumes a reservation at > * allocation time. Cleared when page is fully instantiated. Free > Reviewed-by: David Hildenbrand <david@redhat.com>
diff --git a/include/linux/hugetlb.h b/include/linux/hugetlb.h index cccd1aab69dd..c0467a7a1fe0 100644 --- a/include/linux/hugetlb.h +++ b/include/linux/hugetlb.h @@ -476,6 +476,9 @@ unsigned long hugetlb_get_unmapped_area(struct file *file, unsigned long addr, * huegtlb page specific state flags. These flags are located in page.private * of the hugetlb head page. Functions created via the below macros should be * used to manipulate these flags. + * Note: The hugetlb page subpool pointer previously located at page.private + * was moved to page[1].private to make room for flags in the head page. See + * hugetlb_page_subpool(). * * HPG_restore_reserve - Set when a hugetlb page consumes a reservation at * allocation time. Cleared when page is fully instantiated. Free
Expand comments, no functional change. Signed-off-by: Mike Kravetz <mike.kravetz@oracle.com> --- include/linux/hugetlb.h | 3 +++ 1 file changed, 3 insertions(+)