From patchwork Wed Feb 24 20:02:55 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Andrew Morton X-Patchwork-Id: 12102513 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-15.7 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id F02FDC433DB for ; Wed, 24 Feb 2021 20:02:58 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 9644964E60 for ; Wed, 24 Feb 2021 20:02:58 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 9644964E60 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=linux-foundation.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id 259418D000D; Wed, 24 Feb 2021 15:02:58 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 1FF078D0007; Wed, 24 Feb 2021 15:02:58 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 13B108D000D; Wed, 24 Feb 2021 15:02:58 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0155.hostedemail.com [216.40.44.155]) by kanga.kvack.org (Postfix) with ESMTP id E833D8D0007 for ; Wed, 24 Feb 2021 15:02:57 -0500 (EST) Received: from smtpin18.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay02.hostedemail.com (Postfix) with ESMTP id A78D0F045 for ; Wed, 24 Feb 2021 20:02:57 +0000 (UTC) X-FDA: 77854234794.18.6B70FC3 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by imf14.hostedemail.com (Postfix) with ESMTP id 0897CC0007DA for ; Wed, 24 Feb 2021 20:02:49 +0000 (UTC) Received: by mail.kernel.org (Postfix) with ESMTPSA id 16D7564E09; Wed, 24 Feb 2021 20:02:56 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linux-foundation.org; s=korg; t=1614196976; bh=T85Xr9DPB97rqTmjlllDlIAKZVTOHYa0asJFqBT5srk=; h=Date:From:To:Subject:In-Reply-To:From; b=q/AFx7eU6VRssTE7HU2EtPoLJq8H9Pf4MSSLyVqwUsPAIDkYyaKK9RNvGuyJuy+Li 80A4Pf7CGtbKaMh1A9NHBfTA0M7p+dCHLJZn/hlrvkHkvBrlLSwCpqjtAl3EaRtGII Vn7/POCjuooG51grwbwzN8jNOEjNsLevplIkDnjs= Date: Wed, 24 Feb 2021 12:02:55 -0800 From: Andrew Morton To: abaci-bugfix@linux.alibaba.com, abaci@linux.alibaba.com, akpm@linux-foundation.org, david@redhat.com, linux-mm@kvack.org, mm-commits@vger.kernel.org, torvalds@linux-foundation.org Subject: [patch 050/173] mm/swap_slots.c: remove redundant NULL check Message-ID: <20210224200255.cTufYVXJh%akpm@linux-foundation.org> In-Reply-To: <20210224115824.1e289a6895087f10c41dd8d6@linux-foundation.org> User-Agent: s-nail v14.8.16 X-Stat-Signature: z9crfh6gk4jttubjewga8xupkgkfxsmc X-Rspamd-Server: rspam02 X-Rspamd-Queue-Id: 0897CC0007DA Received-SPF: none (linux-foundation.org>: No applicable sender policy available) receiver=imf14; identity=mailfrom; envelope-from=""; helo=mail.kernel.org; client-ip=198.145.29.99 X-HE-DKIM-Result: pass/pass X-HE-Tag: 1614196969-596077 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: From: Yang Li Subject: mm/swap_slots.c: remove redundant NULL check Fix below warnings reported by coccicheck: ./mm/swap_slots.c:197:3-9: WARNING: NULL check before some freeing functions is not needed. Link: https://lkml.kernel.org/r/1611214229-11225-1-git-send-email-abaci-bugfix@linux.alibaba.com Signed-off-by: Yang Li Reported-by: Abaci Robot Reviewed-by: Andrew Morton Reviewed-by: David Hildenbrand Signed-off-by: Andrew Morton --- mm/swap_slots.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) --- a/mm/swap_slots.c~mm-swap_slotsc-remove-redundant-null-check +++ a/mm/swap_slots.c @@ -193,8 +193,7 @@ static void drain_slots_cache_cpu(unsign cache->slots_ret = NULL; } spin_unlock_irq(&cache->free_lock); - if (slots) - kvfree(slots); + kvfree(slots); } }