[083/173] mm: mremap: unlink anon_vmas when mremap with MREMAP_DONTUNMAP success

Commit Message

Andrew Morton Feb. 24, 2021, 8:04 p.m. UTC

From: Li Xinhai <[e-mail]>
Subject: mm: mremap: unlink anon_vmas when mremap with MREMAP_DONTUNMAP success

mremap with MREMAP_DONTUNMAP can move all page table entries to new vma,
which means all pages allocated for the old vma are not relevant to it
anymore, and the relevant anon_vma links needs to be unlinked, in nature
the old vma is much like been freshly created and have no pages been fault
in.

But we should not do unlink, if the new vma has effectively merged with
the old one.

[[e-mail]: v2]
  Link: https://lkml.kernel.org/r/[e-mail]
Link: https://lkml.kernel.org/r/[e-mail]
Signed-off-by: Li Xinhai <[e-mail]>
Cc: Brian Geffon <[e-mail]>
Cc: Lokesh Gidra <[e-mail]>
Cc: Minchan Kim <[e-mail]>
Cc: Kirill A. Shutemov <[e-mail]>
Cc: Vlastimil Babka <[e-mail]>
Cc: Andrea Arcangeli <[e-mail]>
Signed-off-by: Andrew Morton <[e-mail]>
---

 mm/mremap.c |    8 ++++++++
 1 file changed, 8 insertions(+)

Patch

--- a/mm/mremap.c~mm-mremap-unlink-anon_vmas-when-mremap-with-mremap_dontunmap-success
+++ a/mm/mremap.c
@@ -593,6 +593,14 @@  static unsigned long move_vma(struct vm_
 		/* We always clear VM_LOCKED[ONFAULT] on the old vma */
 		vma->vm_flags &= VM_LOCKED_CLEAR_MASK;
 
+		/*
+		 * anon_vma links of the old vma is no longer needed after its page
+		 * table has been moved.
+		 */
+		if (new_vma != vma && vma->vm_start == old_addr &&
+			vma->vm_end == (old_addr + old_len))
+			unlink_anon_vmas(vma);
+
 		/* Because we won't unmap we don't need to touch locked_vm */
 		return new_addr;
 	}