[27/29] mm/memcg: set memcg when splitting page

Commit Message

Andrew Morton March 13, 2021, 5:08 a.m. UTC

From: Zhou Guanghui <[e-mail]>
Subject: mm/memcg: set memcg when splitting page

As described in the split_page() comment, for the non-compound high order
page, the sub-pages must be freed individually.  If the memcg of the first
page is valid, the tail pages cannot be uncharged when be freed.

For example, when alloc_pages_exact is used to allocate 1MB continuous
physical memory, 2MB is charged(kmemcg is enabled and __GFP_ACCOUNT is
set).  When make_alloc_exact free the unused 1MB and free_pages_exact free
the applied 1MB, actually, only 4KB(one page) is uncharged.

Therefore, the memcg of the tail page needs to be set when splitting a
page.

Michel:

There are at least two explicit users of __GFP_ACCOUNT with
alloc_exact_pages added recently.  See 7efe8ef274024 ("KVM: arm64:
Allocate stage-2 pgd pages with GFP_KERNEL_ACCOUNT") and c419621873713
("KVM: s390: Add memcg accounting to KVM allocations"), so this is not
just a theoretical issue.

Link: https://lkml.kernel.org/r/[e-mail]
Signed-off-by: Zhou Guanghui <[e-mail]>
Acked-by: Johannes Weiner <[e-mail]>
Reviewed-by: Zi Yan <[e-mail]>
Reviewed-by: Shakeel Butt <[e-mail]>
Acked-by: Michal Hocko <[e-mail]>
Cc: Hanjun Guo <[e-mail]>
Cc: Hugh Dickins <[e-mail]>
Cc: Kefeng Wang <[e-mail]>
Cc: "Kirill A. Shutemov" <[e-mail]>
Cc: Nicholas Piggin <[e-mail]>
Cc: Rui Xiang <[e-mail]>
Cc: Tianhong Ding <[e-mail]>
Cc: Weilong Chen <[e-mail]>
Cc: <[e-mail]>
Signed-off-by: Andrew Morton <[e-mail]>
---

 mm/page_alloc.c |    1 +
 1 file changed, 1 insertion(+)

Patch

--- a/mm/page_alloc.c~mm-memcg-set-memcg-when-split-page
+++ a/mm/page_alloc.c
@@ -3314,6 +3314,7 @@  void split_page(struct page *page, unsig
 	for (i = 1; i < (1 << order); i++)
 		set_page_refcounted(page + i);
 	split_page_owner(page, 1 << order);
+	split_page_memcg(page, 1 << order);
 }
 EXPORT_SYMBOL_GPL(split_page);