| Message ID | 20210320054104.1300774-4-willy@infradead.org (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | Memory Folios | expand |
On Sat, Mar 20, 2021 at 05:40:40AM +0000, Matthew Wilcox (Oracle) wrote: > Open-coding this function meant it missed out on the recent bugfix > for waiters being woken by a delayed wake event from a previous > instantiation of the page. > > Signed-off-by: Matthew Wilcox (Oracle) <willy@infradead.org> Looks good, Reviewed-by: Christoph Hellwig <hch@lst.de>
Matthew Wilcox (Oracle) <willy@infradead.org> wrote: > Open-coding this function meant it missed out on the recent bugfix > for waiters being woken by a delayed wake event from a previous > instantiation of the page. > > Signed-off-by: Matthew Wilcox (Oracle) <willy@infradead.org> Acked-and-tested-by: David Howells <dhowells@redhat.com> Should this be pushed upstream now as well if it's missing out on a bugfix?
On Mon, Mar 22, 2021 at 09:27:26AM +0000, David Howells wrote: > Matthew Wilcox (Oracle) <willy@infradead.org> wrote: > > > Open-coding this function meant it missed out on the recent bugfix > > for waiters being woken by a delayed wake event from a previous > > instantiation of the page. > > > > Signed-off-by: Matthew Wilcox (Oracle) <willy@infradead.org> > > Acked-and-tested-by: David Howells <dhowells@redhat.com> > > Should this be pushed upstream now as well if it's missing out on a bugfix? I would be delighted for you to take these first three patches through your tree and push them for, say, -rc5.
Matthew Wilcox (Oracle) <willy@infradead.org> wrote:
> Open-coding this function meant it missed out on the recent bugfix
Would that be:
c2407cf7d22d0c0d94cf20342b3b8f06f1d904e7
mm: make wait_on_page_writeback() wait for multiple pending writebacks
David
diff --git a/fs/afs/write.c b/fs/afs/write.c index b2e03de09c24..106a864b6a93 100644 --- a/fs/afs/write.c +++ b/fs/afs/write.c @@ -850,8 +850,7 @@ vm_fault_t afs_page_mkwrite(struct vm_fault *vmf) return VM_FAULT_RETRY; #endif - if (PageWriteback(page) && - wait_on_page_bit_killable(page, PG_writeback) < 0) + if (wait_on_page_writeback_killable(page)) return VM_FAULT_RETRY; if (lock_page_killable(page) < 0)
Open-coding this function meant it missed out on the recent bugfix for waiters being woken by a delayed wake event from a previous instantiation of the page. Signed-off-by: Matthew Wilcox (Oracle) <willy@infradead.org> --- fs/afs/write.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-)