From patchwork Thu Apr 1 21:09:09 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Sergei Trofimovich X-Patchwork-Id: 12179553 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-16.8 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 12717C433ED for ; Thu, 1 Apr 2021 21:09:34 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id B5DAF60FE9 for ; Thu, 1 Apr 2021 21:09:33 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org B5DAF60FE9 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=gentoo.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id 4AE276B00BC; Thu, 1 Apr 2021 17:09:33 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 45EE16B00BD; Thu, 1 Apr 2021 17:09:33 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 326356B00BE; Thu, 1 Apr 2021 17:09:33 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0060.hostedemail.com [216.40.44.60]) by kanga.kvack.org (Postfix) with ESMTP id 110106B00BC for ; Thu, 1 Apr 2021 17:09:33 -0400 (EDT) Received: from smtpin16.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay01.hostedemail.com (Postfix) with ESMTP id BE3411819E76F for ; Thu, 1 Apr 2021 21:09:32 +0000 (UTC) X-FDA: 77985039384.16.E42BF88 Received: from smtp.gentoo.org (smtp.gentoo.org [140.211.166.183]) by imf15.hostedemail.com (Postfix) with ESMTP id E6DFCA000392 for ; Thu, 1 Apr 2021 21:09:27 +0000 (UTC) Received: by sf.home (Postfix, from userid 1000) id 729335A22061; Thu, 1 Apr 2021 22:09:22 +0100 (BST) From: Sergei Trofimovich To: Andrew Morton Cc: linux-kernel@vger.kernel.org, Sergei Trofimovich , linux-mm@kvack.org Subject: [PATCH] mm: page_owner: use kstrtobool() to parse bool option Date: Thu, 1 Apr 2021 22:09:09 +0100 Message-Id: <20210401210909.3532086-1-slyfox@gentoo.org> X-Mailer: git-send-email 2.31.1 MIME-Version: 1.0 X-Rspamd-Server: rspam03 X-Rspamd-Queue-Id: E6DFCA000392 X-Stat-Signature: 5jpyfd1h7z944448edg7w6q8b3dcymux Received-SPF: none (gentoo.org>: No applicable sender policy available) receiver=imf15; identity=mailfrom; envelope-from=""; helo=smtp.gentoo.org; client-ip=140.211.166.183 X-HE-DKIM-Result: none/none X-HE-Tag: 1617311367-499507 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: I tried to use page_owner=1 for a while noticed too late it had no effect as opposed to similar init_on_alloc=1 (these work). Let's make them consistent. The change decreses binary size slightly: text data bss dec hex filename 12408 321 17 12746 31ca mm/page_owner.o.before 12320 321 17 12658 3172 mm/page_owner.o.after CC: Andrew Morton CC: linux-mm@kvack.org Signed-off-by: Sergei Trofimovich Reviewed-by: Matthew Wilcox (Oracle) --- mm/page_owner.c | 8 +------- 1 file changed, 1 insertion(+), 7 deletions(-) diff --git a/mm/page_owner.c b/mm/page_owner.c index d15c7c4994f5..63e4ecaba97b 100644 --- a/mm/page_owner.c +++ b/mm/page_owner.c @@ -41,13 +41,7 @@ static void init_early_allocated_pages(void); static int __init early_page_owner_param(char *buf) { - if (!buf) - return -EINVAL; - - if (strcmp(buf, "on") == 0) - page_owner_enabled = true; - - return 0; + return kstrtobool(buf, &page_owner_enabled); } early_param("page_owner", early_page_owner_param);