| Message ID | 20210408035736.883861-2-guro@fb.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | percpu: partial chunk depopulation | expand |
Hello, On Wed, Apr 07, 2021 at 08:57:31PM -0700, Roman Gushchin wrote: > Since the commit 3e54097beb22 ("percpu: manage chunks based on > contig_bits instead of free_bytes") chunks are sorted based on the > size of the biggest continuous free area instead of the total number > of free bytes. Update the corresponding comment to reflect this. > > Signed-off-by: Roman Gushchin <guro@fb.com> > --- > mm/percpu.c | 5 ++++- > 1 file changed, 4 insertions(+), 1 deletion(-) > > diff --git a/mm/percpu.c b/mm/percpu.c > index 6596a0a4286e..2f27123bb489 100644 > --- a/mm/percpu.c > +++ b/mm/percpu.c > @@ -99,7 +99,10 @@ > > #include "percpu-internal.h" > > -/* the slots are sorted by free bytes left, 1-31 bytes share the same slot */ > +/* > + * The slots are sorted by the size of the biggest continuous free area. > + * 1-31 bytes share the same slot. > + */ > #define PCPU_SLOT_BASE_SHIFT 5 > /* chunks in slots below this are subject to being sidelined on failed alloc */ > #define PCPU_SLOT_FAIL_THRESHOLD 3 > -- > 2.30.2 > I've applied this to for-5.14. Thanks, Dennis
diff --git a/mm/percpu.c b/mm/percpu.c index 6596a0a4286e..2f27123bb489 100644 --- a/mm/percpu.c +++ b/mm/percpu.c @@ -99,7 +99,10 @@ #include "percpu-internal.h" -/* the slots are sorted by free bytes left, 1-31 bytes share the same slot */ +/* + * The slots are sorted by the size of the biggest continuous free area. + * 1-31 bytes share the same slot. + */ #define PCPU_SLOT_BASE_SHIFT 5 /* chunks in slots below this are subject to being sidelined on failed alloc */ #define PCPU_SLOT_FAIL_THRESHOLD 3
Since the commit 3e54097beb22 ("percpu: manage chunks based on contig_bits instead of free_bytes") chunks are sorted based on the size of the biggest continuous free area instead of the total number of free bytes. Update the corresponding comment to reflect this. Signed-off-by: Roman Gushchin <guro@fb.com> --- mm/percpu.c | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-)