From patchwork Fri Apr 9 12:29:50 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Muchun Song X-Patchwork-Id: 12194049 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-16.6 required=3.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 3FE97C433B4 for ; Fri, 9 Apr 2021 12:32:47 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id E03A061178 for ; Fri, 9 Apr 2021 12:32:46 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org E03A061178 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=bytedance.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id 7BDC56B007E; Fri, 9 Apr 2021 08:32:46 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 794076B0080; Fri, 9 Apr 2021 08:32:46 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 65BEE6B0081; Fri, 9 Apr 2021 08:32:46 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0118.hostedemail.com [216.40.44.118]) by kanga.kvack.org (Postfix) with ESMTP id 4DDCB6B007E for ; Fri, 9 Apr 2021 08:32:46 -0400 (EDT) Received: from smtpin34.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay03.hostedemail.com (Postfix) with ESMTP id 0AD0E8248047 for ; Fri, 9 Apr 2021 12:32:46 +0000 (UTC) X-FDA: 78012767532.34.0ECCB05 Received: from mail-pl1-f178.google.com (mail-pl1-f178.google.com [209.85.214.178]) by imf30.hostedemail.com (Postfix) with ESMTP id 9D1BCE0001AC for ; Fri, 9 Apr 2021 12:32:38 +0000 (UTC) Received: by mail-pl1-f178.google.com with SMTP id h20so2686473plr.4 for ; Fri, 09 Apr 2021 05:32:45 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bytedance-com.20150623.gappssmtp.com; s=20150623; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=AGnIcRUphb33Z52wrBzQRy2lP1/tCopQL4vrXFnFrmI=; b=S0AxdzbO4aXq30Vi35yMmb1Li/r3E9lW60nwWLlDMZRGKCvNrSuk9f6rMufTdhOyqF uGM5dcZ1TcR1fLjFFyIpJRKkjjDhlTNaqc5Ies/YjdlKakn02dWQ1V9zj1k2tXWloykp KcViVWqi0wDeQZoFgkHypenGAb2l/C8qnB/RTFfInSkCaTPj860ShomNWih9FAhRvtwR dUQj3pch7N74sEvRDw5muZ+tU8TCL9Ks18Tp/EOpqWvNbEPBoKAHXwT5/HHUz3MIeEvg UKnRw93yBCLGcNZUgOQr80Hfj3NdocAyk/VRGGBHm0O+YugvFmpwgS/3TWpCtBReAJON gv4A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=AGnIcRUphb33Z52wrBzQRy2lP1/tCopQL4vrXFnFrmI=; b=rRpaEMVQC/GRpjIZOWyyJhVO1bUJW32TcQ4y6jz3RcLqLWrs72imTEI/iuC0dD0BUC Rg9igpcomGTsLgIuhY5oEYV5i4OF44LUN7+dD9KEkQDX2niWBCvsCgQcJ9jzatTiSuLy Ig8mxpwuu9o+a3wSfHrDCwULCDs5yMUIo7FitJ1RY0SXvGwDQN0IkwkpiY0FDnI2D6sX IMF3KdZNuqOj7IRJo1Nnlbl1gByQu0A5DqT8S3NQw4HuJ3MutyTWFTqhmoRBW24qEMtb FGNTCZTxtjIhJpUX9R95Bm5cEaYeYHOegwaFYkxf9IOXuVlTb0g4pPLv3pEHxmqMO2Yl AAmA== X-Gm-Message-State: AOAM533oIJILENsIBjvcnx+fMHBIz1Jxv5ENQ1y2MoAdo7fM25WDiYQq 9xsZKuTjcxX8/deiFMRwj5s4YcfN8N3BOIQh X-Google-Smtp-Source: ABdhPJwn8UgcJ7e8pfW/StQ/oe2JyK5NB/2gozqFYTM0tv5Cti79xM30O0H5IkxlZ8bpV8sY/ILxdQ== X-Received: by 2002:a17:90a:de89:: with SMTP id n9mr13461586pjv.180.1617971564855; Fri, 09 Apr 2021 05:32:44 -0700 (PDT) Received: from localhost.localdomain ([139.177.225.243]) by smtp.gmail.com with ESMTPSA id t3sm2167785pfg.176.2021.04.09.05.32.39 (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Fri, 09 Apr 2021 05:32:44 -0700 (PDT) From: Muchun Song To: guro@fb.com, hannes@cmpxchg.org, mhocko@kernel.org, akpm@linux-foundation.org, shakeelb@google.com, vdavydov.dev@gmail.com Cc: linux-kernel@vger.kernel.org, linux-mm@kvack.org, duanxiongchun@bytedance.com, fam.zheng@bytedance.com, bsingharora@gmail.com, shy828301@gmail.com, alex.shi@linux.alibaba.com, Muchun Song Subject: [RFC PATCH v2 09/18] mm: vmscan: remove noinline_for_stack Date: Fri, 9 Apr 2021 20:29:50 +0800 Message-Id: <20210409122959.82264-10-songmuchun@bytedance.com> X-Mailer: git-send-email 2.21.0 (Apple Git-122) In-Reply-To: <20210409122959.82264-1-songmuchun@bytedance.com> References: <20210409122959.82264-1-songmuchun@bytedance.com> MIME-Version: 1.0 X-Rspamd-Server: rspam01 X-Rspamd-Queue-Id: 9D1BCE0001AC X-Stat-Signature: ce1sjd93rq7f1rocjrm6zqnjfgmmf1dz Received-SPF: none (bytedance.com>: No applicable sender policy available) receiver=imf30; identity=mailfrom; envelope-from=""; helo=mail-pl1-f178.google.com; client-ip=209.85.214.178 X-HE-DKIM-Result: pass/pass X-HE-Tag: 1617971558-111941 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: The noinline_for_stack is introduced by commit 666356297ec4 ("vmscan: set up pagevec as late as possible in shrink_inactive_list()"), its purpose is to delay the allocation of pagevec as late as possible to save stack memory. But the commit 2bcf88796381 ("mm: take pagevecs off reclaim stack") replace pagevecs by lists of pages_to_free. So we do not need noinline_for_stack, just remove it (let the compiler decide whether to inline). Signed-off-by: Muchun Song Acked-by: Johannes Weiner Acked-by: Roman Gushchin Reviewed-by: Shakeel Butt --- mm/vmscan.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/mm/vmscan.c b/mm/vmscan.c index 64bf07cc20f2..e40b21298d77 100644 --- a/mm/vmscan.c +++ b/mm/vmscan.c @@ -2015,8 +2015,8 @@ static int too_many_isolated(struct pglist_data *pgdat, int file, * * Returns the number of pages moved to the given lruvec. */ -static unsigned noinline_for_stack move_pages_to_lru(struct lruvec *lruvec, - struct list_head *list) +static unsigned int move_pages_to_lru(struct lruvec *lruvec, + struct list_head *list) { int nr_pages, nr_moved = 0; LIST_HEAD(pages_to_free); @@ -2096,7 +2096,7 @@ static int current_may_throttle(void) * shrink_inactive_list() is a helper for shrink_node(). It returns the number * of reclaimed pages */ -static noinline_for_stack unsigned long +static unsigned long shrink_inactive_list(unsigned long nr_to_scan, struct lruvec *lruvec, struct scan_control *sc, enum lru_list lru) {