From patchwork Sat Apr 17 04:35:32 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Muchun Song X-Patchwork-Id: 12209525 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-16.5 required=3.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 71872C433B4 for ; Sat, 17 Apr 2021 04:38:10 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 1B3E5611AB for ; Sat, 17 Apr 2021 04:38:10 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 1B3E5611AB Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=bytedance.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id B413D6B0070; Sat, 17 Apr 2021 00:38:09 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id B17C56B0071; Sat, 17 Apr 2021 00:38:09 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 9B9B56B0072; Sat, 17 Apr 2021 00:38:09 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0246.hostedemail.com [216.40.44.246]) by kanga.kvack.org (Postfix) with ESMTP id 80BB76B0070 for ; Sat, 17 Apr 2021 00:38:09 -0400 (EDT) Received: from smtpin06.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay04.hostedemail.com (Postfix) with ESMTP id 38C5A45BB for ; Sat, 17 Apr 2021 04:38:09 +0000 (UTC) X-FDA: 78040601898.06.6F4C570 Received: from mail-pl1-f169.google.com (mail-pl1-f169.google.com [209.85.214.169]) by imf24.hostedemail.com (Postfix) with ESMTP id CE76AA0000FD for ; Sat, 17 Apr 2021 04:38:01 +0000 (UTC) Received: by mail-pl1-f169.google.com with SMTP id u7so13190786plr.6 for ; Fri, 16 Apr 2021 21:38:08 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bytedance-com.20150623.gappssmtp.com; s=20150623; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=NE/BcoGMuqPyqQGyjWQGMTxC1WpQbz3TqD3QbwUvSZY=; b=HCYBSuWL5lNSfyR1c5D+bsBKj9KEfSpvl6qC9ksYnjL148APwpW4TAUtqKdnJ7pC7A TcpivOKDUXNMLR3P+FWv0R6KBx0FXOHEtaFTOTJjSlGGMEKxleb0kqY6b+3DAzr/+qMO yUn6B0VTyigbyVwQw5NZ3llxK3JzpPsR4mNmCT8d1ttTFw24RIUEdIoPxa7Hr+KPWBxb P8YHj4MA8iPuorRIuQPnQgP4eCAw+CDbYwkVLDQxwWWIhoiTTe8bIpNqwVa1ED87nl6A fW/wJXy4jF0w1hZj+aZIv7N5SUCY68+4Hz3w1OYGvkhz307Khf9vrRxWNo24RfqfKG8A gaRQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=NE/BcoGMuqPyqQGyjWQGMTxC1WpQbz3TqD3QbwUvSZY=; b=XgzIKNnECTV5mTx25HuQwpf7VV894kCV5aMKdeeBjfsFkVrjOpeFO5HR/8jVxxe9Te 7WejnqAaxuf0R53aApMMCVMxvZEkBBSVWu9MK63z+Ond0fV0+eHIe7AGL8JvArCSpXbK 7DCYjKYGALUlhYu9w28WkPghk+RF4a7Gg7hV70/skICsvJ1ti6dSK8unaO6r+rdLNZ3o ewAUnHKkVqCyjFR9/wpNUKAqx6EOq9QrsuVp5qadNYbFf3X6kcAnv7MCeW8ZouJth80t LyQhwzVv0WLBrfclqDfbctWMOa8Kxlj3wzBHXjkGUe9mR4NN3/fiaCJes6wK9ln6GcR+ 4ddQ== X-Gm-Message-State: AOAM531GSudNkzl4arGGI/rq6YabRFoepfJyUP/5lE4Qm/Cpt0asDJAP m3elThh0YM6HY2oldoC3ksl70Q== X-Google-Smtp-Source: ABdhPJzWa9DWpbE9nY7cRes3aa7lKCkPT7KXRZi0kgxvIDJ4A4qJBPj3gK6804vLQ/irrw+KbLogpQ== X-Received: by 2002:a17:902:cec4:b029:e9:58eb:562b with SMTP id d4-20020a170902cec4b02900e958eb562bmr12659796plg.63.1618634288058; Fri, 16 Apr 2021 21:38:08 -0700 (PDT) Received: from localhost.bytedance.net ([139.177.225.228]) by smtp.gmail.com with ESMTPSA id w21sm7064775pjy.21.2021.04.16.21.38.02 (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Fri, 16 Apr 2021 21:38:07 -0700 (PDT) From: Muchun Song To: guro@fb.com, hannes@cmpxchg.org, mhocko@kernel.org, akpm@linux-foundation.org, shakeelb@google.com, vdavydov.dev@gmail.com Cc: linux-kernel@vger.kernel.org, linux-mm@kvack.org, duanxiongchun@bytedance.com, Muchun Song , Michal Hocko Subject: [PATCH v3 2/8] mm: memcontrol: bail out early when !mm in get_mem_cgroup_from_mm Date: Sat, 17 Apr 2021 12:35:32 +0800 Message-Id: <20210417043538.9793-3-songmuchun@bytedance.com> X-Mailer: git-send-email 2.21.0 (Apple Git-122) In-Reply-To: <20210417043538.9793-1-songmuchun@bytedance.com> References: <20210417043538.9793-1-songmuchun@bytedance.com> MIME-Version: 1.0 X-Rspamd-Server: rspam05 X-Rspamd-Queue-Id: CE76AA0000FD X-Stat-Signature: jpesk6jcj8r8tsm6q781k91m3wig6x4p Received-SPF: none (bytedance.com>: No applicable sender policy available) receiver=imf24; identity=mailfrom; envelope-from=""; helo=mail-pl1-f169.google.com; client-ip=209.85.214.169 X-HE-DKIM-Result: pass/pass X-HE-Tag: 1618634281-103563 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: When mm is NULL, we do not need to hold rcu lock and call css_tryget for the root memcg. And we also do not need to check !mm in every loop of while. So bail out early when !mm. Signed-off-by: Muchun Song Acked-by: Johannes Weiner Reviewed-by: Shakeel Butt Acked-by: Roman Gushchin Acked-by: Michal Hocko --- mm/memcontrol.c | 25 ++++++++++++++----------- 1 file changed, 14 insertions(+), 11 deletions(-) diff --git a/mm/memcontrol.c b/mm/memcontrol.c index f229de925aa5..50e3cf1e263e 100644 --- a/mm/memcontrol.c +++ b/mm/memcontrol.c @@ -901,20 +901,23 @@ struct mem_cgroup *get_mem_cgroup_from_mm(struct mm_struct *mm) if (mem_cgroup_disabled()) return NULL; + /* + * Page cache insertions can happen without an + * actual mm context, e.g. during disk probing + * on boot, loopback IO, acct() writes etc. + * + * No need to css_get on root memcg as the reference + * counting is disabled on the root level in the + * cgroup core. See CSS_NO_REF. + */ + if (unlikely(!mm)) + return root_mem_cgroup; + rcu_read_lock(); do { - /* - * Page cache insertions can happen without an - * actual mm context, e.g. during disk probing - * on boot, loopback IO, acct() writes etc. - */ - if (unlikely(!mm)) + memcg = mem_cgroup_from_task(rcu_dereference(mm->owner)); + if (unlikely(!memcg)) memcg = root_mem_cgroup; - else { - memcg = mem_cgroup_from_task(rcu_dereference(mm->owner)); - if (unlikely(!memcg)) - memcg = root_mem_cgroup; - } } while (!css_tryget(&memcg->css)); rcu_read_unlock(); return memcg;